CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
128 lines
3.9 KiB
C++
128 lines
3.9 KiB
C++
//=======- NoDeleteChecker.cpp -----------------------------------*- C++ -*-==//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "DiagOutputUtils.h"
|
|
#include "PtrTypesSemantics.h"
|
|
#include "clang/AST/CXXInheritance.h"
|
|
#include "clang/AST/Decl.h"
|
|
#include "clang/AST/DeclCXX.h"
|
|
#include "clang/AST/DynamicRecursiveASTVisitor.h"
|
|
#include "clang/AST/QualTypeNames.h"
|
|
#include "clang/Analysis/DomainSpecific/CocoaConventions.h"
|
|
#include "clang/Basic/SourceLocation.h"
|
|
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
|
|
namespace {
|
|
|
|
class NoDeleteChecker : public Checker<check::ASTDecl<TranslationUnitDecl>> {
|
|
BugType Bug;
|
|
mutable BugReporter *BR = nullptr;
|
|
mutable TrivialFunctionAnalysis TFA;
|
|
|
|
public:
|
|
NoDeleteChecker()
|
|
: Bug(this,
|
|
"Incorrect [[clang::annotate_type(\"webkit.nodelete\")]] "
|
|
"annotation",
|
|
"WebKit coding guidelines") {}
|
|
|
|
void checkASTDecl(const TranslationUnitDecl *TUD, AnalysisManager &MGR,
|
|
BugReporter &BRArg) const {
|
|
BR = &BRArg;
|
|
|
|
// The calls to checkAST* from AnalysisConsumer don't
|
|
// visit template instantiations or lambda classes. We
|
|
// want to visit those, so we make our own visitor.
|
|
struct LocalVisitor final : public ConstDynamicRecursiveASTVisitor {
|
|
const NoDeleteChecker *Checker;
|
|
Decl *DeclWithIssue{nullptr};
|
|
|
|
explicit LocalVisitor(const NoDeleteChecker *Checker) : Checker(Checker) {
|
|
assert(Checker);
|
|
ShouldVisitTemplateInstantiations = true;
|
|
ShouldWalkTypesOfTypeLocs = true;
|
|
ShouldVisitImplicitCode = false;
|
|
ShouldVisitLambdaBody = true;
|
|
}
|
|
|
|
bool VisitFunctionDecl(const FunctionDecl *FD) override {
|
|
Checker->visitFunctionDecl(FD);
|
|
return true;
|
|
}
|
|
};
|
|
|
|
LocalVisitor visitor(this);
|
|
visitor.TraverseDecl(const_cast<TranslationUnitDecl *>(TUD));
|
|
}
|
|
|
|
void visitFunctionDecl(const FunctionDecl *FD) const {
|
|
if (!FD->doesThisDeclarationHaveABody() || FD->isDependentContext())
|
|
return;
|
|
|
|
if (!isNoDeleteFunction(FD))
|
|
return;
|
|
|
|
auto Body = FD->getBody();
|
|
if (!Body)
|
|
return;
|
|
|
|
NamedDecl *ParamDecl = nullptr;
|
|
for (auto *D : FD->parameters()) {
|
|
if (!TFA.hasTrivialDtor(D)) {
|
|
ParamDecl = D;
|
|
break;
|
|
}
|
|
}
|
|
const Stmt *OffendingStmt = nullptr;
|
|
if (!ParamDecl && TFA.isTrivial(Body, &OffendingStmt))
|
|
return;
|
|
|
|
SmallString<100> Buf;
|
|
llvm::raw_svector_ostream Os(Buf);
|
|
|
|
Os << "A function ";
|
|
printQuotedName(Os, FD);
|
|
Os << " has [[clang::annotate_type(\"webkit.nodelete\")]] but it contains ";
|
|
SourceLocation SrcLocToReport;
|
|
SourceRange Range;
|
|
if (ParamDecl) {
|
|
Os << "a parameter ";
|
|
printQuotedName(Os, ParamDecl);
|
|
Os << " which could destruct an object.";
|
|
SrcLocToReport = FD->getBeginLoc();
|
|
Range = ParamDecl->getSourceRange();
|
|
} else {
|
|
Os << "code that could destruct an object.";
|
|
SrcLocToReport = OffendingStmt->getBeginLoc();
|
|
Range = OffendingStmt->getSourceRange();
|
|
}
|
|
|
|
PathDiagnosticLocation BSLoc(SrcLocToReport, BR->getSourceManager());
|
|
auto Report = std::make_unique<BasicBugReport>(Bug, Os.str(), BSLoc);
|
|
Report->addRange(Range);
|
|
Report->setDeclWithIssue(FD);
|
|
BR->emitReport(std::move(Report));
|
|
}
|
|
};
|
|
|
|
} // namespace
|
|
|
|
void ento::registerNoDeleteChecker(CheckerManager &Mgr) {
|
|
Mgr.registerChecker<NoDeleteChecker>();
|
|
}
|
|
|
|
bool ento::shouldRegisterNoDeleteChecker(const CheckerManager &) {
|
|
return true;
|
|
}
|