Files
derek.holloway 7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
Flatten subprojects into a single base monorepo
2026-09-02 16:34:47 -07:00

165 lines
6.4 KiB
C++

// Copyright Advanced Micro Devices, Inc., or its affiliates.
// SPDX-License-Identifier: MIT
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <catch2/matchers/catch_matchers_string.hpp>
#include <algorithm>
#include "SimpleTest.hpp"
#include "TestContext.hpp"
#include "common/SourceMatcher.hpp"
#include <common/CommonGraphs.hpp>
#include <common/Utilities.hpp>
#include <rocRoller/KernelGraph/Transforms/All.hpp>
#include <rocRoller/KernelGraph/Transforms/OrderMultiplyNodes.hpp>
#include <rocRoller/Utilities/Settings_fwd.hpp>
using namespace rocRoller;
using namespace Catch::Matchers;
namespace OrderMultiplyNodesTest
{
// Helper function to get all multiply nodes from the graph
std::vector<int> getMultiplyNodes(KernelGraph::KernelGraph const& graph)
{
using namespace rocRoller::KernelGraph;
return graph.control.getNodes()
.filter([&graph](int idx) {
return graph.control.get<ControlGraph::Multiply>(idx).has_value();
})
.to<std::vector>();
}
TEST_CASE("OrderMultiplyNodes transformation works.", "[kernel-graph][graph-transforms]")
{
using namespace rocRoller::KernelGraph;
auto context = TestContext::ForDefaultTarget();
auto example = rocRollerTest::Graphs::GEMM(DataType::Float);
example.setTileSize(256, 64, 16);
example.setMFMA(32, 32, 2, 1);
auto lds = GENERATE(true, false);
auto prefetch = false;
auto prefetchInFlight = 0;
auto prefetchLDSFactor = 0;
bool prefetchMixMemOps = false;
if(lds)
{
prefetch = GENERATE(true, false);
if(prefetch)
{
prefetchInFlight = 4;
prefetchLDSFactor = 1;
prefetchMixMemOps = GENERATE(true, false);
}
}
DYNAMIC_SECTION("lds=" << lds << ", prefetch=" << prefetch << ", prefetchInFlight="
<< prefetchInFlight << ", prefetchLDSFactor=" << prefetchLDSFactor
<< ", prefetchMixMemOps=" << prefetchMixMemOps)
{
example.setUseLDS(lds, lds, true);
example.setUnroll(0);
example.setPrefetch(prefetch, prefetchInFlight, prefetchLDSFactor, prefetchMixMemOps);
auto graph = example.getKernelGraph();
auto params = example.getCommandParameters();
// Apply transformations up to OrderMultiplyNodes
graph = transform<IdentifyParallelDimensions>(graph);
graph = transform<OrderMemory>(graph, true);
graph = transform<UpdateParameters>(graph, params);
graph = transform<AddLDS>(graph, params, context.get());
graph = transform<LowerLinear>(graph, context.get());
graph = transform<LowerTile>(graph, params, context.get());
graph = transform<LowerTensorContraction>(graph, params, context.get());
graph = transform<Simplify>(graph);
graph = transform<ConstantPropagation>(graph);
graph = transform<FuseExpressions>(graph);
graph = transform<ConnectWorkgroups>(graph, context.get());
graph = transform<WorkgroupRemapXCC>(graph, context.get(), params->workgroupRemapXCC);
graph = transform<UnrollLoops>(graph, params, context.get());
graph = transform<FuseLoops>(graph);
graph = transform<RemoveDuplicates>(graph);
graph = transform<OrderEpilogueBlocks>(graph);
graph = transform<CleanLoops>(graph);
graph = transform<AddPrefetch>(graph, params, context.get());
graph = transform<AddPRNG>(graph, context.get());
graph = transform<UpdateWavefrontParameters>(graph, params);
graph = transform<AssignIndexExpressions>(graph, context.get(), example.getCommand());
graph = transform<LoadPacked>(graph, context.get());
graph = transform<AddConvert>(graph, context.get());
graph = transform<AddDeallocateDataFlow>(graph);
graph = transform<InlineIncrements>(graph);
graph = transform<Simplify>(graph);
auto multiplyNodesBefore = getMultiplyNodes(graph);
REQUIRE(multiplyNodesBefore.size() > 0);
int unorderedPairsBefore = 0;
for(size_t i = 0; i < multiplyNodesBefore.size(); i++)
{
for(size_t j = i + 1; j < multiplyNodesBefore.size(); j++)
{
auto order = graph.control.compareNodes(
UpdateCache, multiplyNodesBefore[i], multiplyNodesBefore[j]);
if(order == ControlGraph::NodeOrdering::Undefined)
{
unorderedPairsBefore++;
}
}
}
REQUIRE(unorderedPairsBefore > 0);
{
auto check = NoUnorderedMultiplyNodes(graph);
CHECK_FALSE(check.satisfied);
CHECK_THAT(check.explanation, ContainsSubstring("Unordered multiply nodes found"));
}
INFO("Unordered pairs before transformation: " << unorderedPairsBefore);
graph = transform<OrderMultiplyNodes>(graph);
auto multiplyNodesAfter = getMultiplyNodes(graph);
CHECK(multiplyNodesAfter == multiplyNodesBefore);
int unorderedPairsAfter = 0;
for(size_t i = 0; i < multiplyNodesAfter.size(); i++)
{
for(size_t j = i + 1; j < multiplyNodesAfter.size(); j++)
{
auto order = graph.control.compareNodes(
UpdateCache, multiplyNodesAfter[i], multiplyNodesAfter[j]);
if(order == ControlGraph::NodeOrdering::Undefined)
{
unorderedPairsAfter++;
INFO("Nodes " << multiplyNodesAfter[i] << " and " << multiplyNodesAfter[j]
<< " are still unordered");
}
}
}
{
auto check = NoUnorderedMultiplyNodes(graph);
CHECK(check.satisfied);
CHECK(check.explanation == "");
}
INFO("Unordered pairs after transformation: " << unorderedPairsAfter);
CHECK(unorderedPairsAfter == 0);
}
}
}