derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
1.5 KiB
1.5 KiB
Governance
Core reviewers
People who can approve standard PRs (tools, knowledge, fixtures, agents, docs):
@aelwazir(AMD, project lead)@rocm-maintainer-1(AMD, performance domain)@rocm-maintainer-2(AMD, agents/LLM domain)
Security-focused reviewers
People who audit provider and MCP-tool changes:
@security-lead(AMD, security)
Architectural reviewers (3-person gate)
Required for RFCs that touch correctness gates, shared fence, or agent tree:
@aelwazir@rocm-maintainer-1@rocm-maintainer-2
Review SLA
- Standard PR: 2 business days
- Architectural (RFC): 5 business days (includes 1-week discussion + voting)
- Security audit (provider/MCP): 3 business days
Escalation
If a PR stalls:
- Comment with
@aelwazir+ context - Project lead will either review or delegate within 24h
- If lead unavailable, escalate to AMD ROCm team leads
Governance change policy
Changes to this file (adding/removing reviewers, changing SLAs) require:
- 3 core maintainer approvals (architectural change to the project)
- 1-week discussion period
- RFC in
docs/rfcs/with rationale
This ensures continuity and prevents reviewer churn.
Decision precedent
In case of reviewer disagreement:
- Try to reach consensus in the PR thread
- If no consensus after 3 business days, project lead (
@aelwazir) makes final call - Rationale recorded in commit message or PR comment
Related docs
../CONTRIBUTING.md(reviewer requirements table)../rfcs/(RFC process for architectural changes)