CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
48 lines
1.8 KiB
C++
48 lines
1.8 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "MustCheckErrsCheck.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::linuxkernel {
|
|
|
|
void MustCheckErrsCheck::registerMatchers(MatchFinder *Finder) {
|
|
auto ErrFn =
|
|
functionDecl(hasAnyName("ERR_PTR", "PTR_ERR", "IS_ERR", "IS_ERR_OR_NULL",
|
|
"ERR_CAST", "PTR_ERR_OR_ZERO"));
|
|
auto NonCheckingStmts = stmt(anyOf(compoundStmt(), labelStmt()));
|
|
Finder->addMatcher(
|
|
callExpr(callee(ErrFn), hasParent(NonCheckingStmts)).bind("call"), this);
|
|
|
|
auto ReturnToCheck = returnStmt(hasReturnValue(callExpr(callee(ErrFn))));
|
|
auto ReturnsErrFn = functionDecl(hasDescendant(ReturnToCheck));
|
|
Finder->addMatcher(callExpr(callee(ReturnsErrFn), hasParent(NonCheckingStmts))
|
|
.bind("transitive_call"),
|
|
this);
|
|
}
|
|
|
|
void MustCheckErrsCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *MatchedCallExpr = Result.Nodes.getNodeAs<CallExpr>("call");
|
|
if (MatchedCallExpr) {
|
|
diag(MatchedCallExpr->getExprLoc(), "result from function %0 is unused")
|
|
<< MatchedCallExpr->getDirectCallee();
|
|
}
|
|
|
|
const auto *MatchedTransitiveCallExpr =
|
|
Result.Nodes.getNodeAs<CallExpr>("transitive_call");
|
|
if (MatchedTransitiveCallExpr) {
|
|
diag(MatchedTransitiveCallExpr->getExprLoc(),
|
|
"result from function %0 is unused but represents an error value")
|
|
<< MatchedTransitiveCallExpr->getDirectCallee();
|
|
}
|
|
}
|
|
|
|
} // namespace clang::tidy::linuxkernel
|