CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
58 lines
2.1 KiB
C++
58 lines
2.1 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "AssertEqualsCheck.h"
|
|
#include "llvm/ADT/StringMap.h"
|
|
|
|
#include <string>
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::objc {
|
|
|
|
// Mapping from `XCTAssert*Equal` to `XCTAssert*EqualObjects` name.
|
|
static const llvm::StringMap<StringRef> NameMap{
|
|
{"XCTAssertEqual", "XCTAssertEqualObjects"},
|
|
{"XCTAssertNotEqual", "XCTAssertNotEqualObjects"},
|
|
};
|
|
|
|
void AssertEqualsCheck::registerMatchers(MatchFinder *Finder) {
|
|
for (const auto &[CurrName, _] : NameMap) {
|
|
Finder->addMatcher(
|
|
binaryOperator(anyOf(hasOperatorName("!="), hasOperatorName("==")),
|
|
isExpandedFromMacro(std::string(CurrName)),
|
|
anyOf(hasLHS(hasType(qualType(
|
|
hasCanonicalType(asString("NSString *"))))),
|
|
hasRHS(hasType(qualType(
|
|
hasCanonicalType(asString("NSString *")))))))
|
|
.bind(CurrName),
|
|
this);
|
|
}
|
|
}
|
|
|
|
void AssertEqualsCheck::check(
|
|
const ast_matchers::MatchFinder::MatchResult &Result) {
|
|
for (const auto &[CurrName, TargetName] : NameMap) {
|
|
if (const auto *Root = Result.Nodes.getNodeAs<BinaryOperator>(CurrName)) {
|
|
const SourceManager *Sm = Result.SourceManager;
|
|
// The macros are nested two levels, so going up twice.
|
|
auto MacroCallsite = Sm->getImmediateMacroCallerLoc(
|
|
Sm->getImmediateMacroCallerLoc(Root->getBeginLoc()));
|
|
diag(MacroCallsite,
|
|
(Twine("use ") + TargetName + " for comparing objects").str())
|
|
<< FixItHint::CreateReplacement(
|
|
CharSourceRange::getCharRange(
|
|
MacroCallsite,
|
|
MacroCallsite.getLocWithOffset(CurrName.size())),
|
|
TargetName);
|
|
}
|
|
}
|
|
}
|
|
|
|
} // namespace clang::tidy::objc
|