derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
96 lines
6.0 KiB
C++
96 lines
6.0 KiB
C++
// RUN: %check_clang_tidy %s abseil-duration-conversion-cast %t -- -- -I%S/Inputs
|
|
|
|
#include "absl/time/time.h"
|
|
|
|
void f() {
|
|
absl::Duration d1;
|
|
double x;
|
|
int i;
|
|
|
|
i = static_cast<int>(absl::ToDoubleHours(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to an integer rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: i = absl::ToInt64Hours(d1);
|
|
x = static_cast<float>(absl::ToInt64Hours(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to a floating-point number rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: x = absl::ToDoubleHours(d1);
|
|
i = static_cast<int>(absl::ToDoubleMinutes(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to an integer rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: i = absl::ToInt64Minutes(d1);
|
|
x = static_cast<float>(absl::ToInt64Minutes(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to a floating-point number rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: x = absl::ToDoubleMinutes(d1);
|
|
i = static_cast<int>(absl::ToDoubleSeconds(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to an integer rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: i = absl::ToInt64Seconds(d1);
|
|
x = static_cast<float>(absl::ToInt64Seconds(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to a floating-point number rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: x = absl::ToDoubleSeconds(d1);
|
|
i = static_cast<int>(absl::ToDoubleMilliseconds(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to an integer rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: i = absl::ToInt64Milliseconds(d1);
|
|
x = static_cast<float>(absl::ToInt64Milliseconds(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to a floating-point number rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: x = absl::ToDoubleMilliseconds(d1);
|
|
i = static_cast<int>(absl::ToDoubleMicroseconds(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to an integer rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: i = absl::ToInt64Microseconds(d1);
|
|
x = static_cast<float>(absl::ToInt64Microseconds(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to a floating-point number rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: x = absl::ToDoubleMicroseconds(d1);
|
|
i = static_cast<int>(absl::ToDoubleNanoseconds(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to an integer rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: i = absl::ToInt64Nanoseconds(d1);
|
|
x = static_cast<float>(absl::ToInt64Nanoseconds(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to a floating-point number rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: x = absl::ToDoubleNanoseconds(d1);
|
|
|
|
// Functional-style casts
|
|
i = int(absl::ToDoubleHours(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to an integer rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: i = absl::ToInt64Hours(d1);
|
|
x = float(absl::ToInt64Microseconds(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to a floating-point number rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: x = absl::ToDoubleMicroseconds(d1);
|
|
|
|
// C-style casts
|
|
i = (int) absl::ToDoubleHours(d1);
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to an integer rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: i = absl::ToInt64Hours(d1);
|
|
x = (float) absl::ToInt64Microseconds(d1);
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: duration should be converted directly to a floating-point number rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: x = absl::ToDoubleMicroseconds(d1);
|
|
|
|
// Type aliasing
|
|
typedef int FancyInt;
|
|
typedef float FancyFloat;
|
|
|
|
FancyInt j = static_cast<FancyInt>(absl::ToDoubleHours(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: duration should be converted directly to an integer rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: FancyInt j = absl::ToInt64Hours(d1);
|
|
FancyFloat k = static_cast<FancyFloat>(absl::ToInt64Microseconds(d1));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:18: warning: duration should be converted directly to a floating-point number rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: FancyFloat k = absl::ToDoubleMicroseconds(d1);
|
|
|
|
// Macro handling
|
|
// We want to transform things in macro arguments
|
|
#define EXTERNAL(x) (x) + 5
|
|
i = EXTERNAL(static_cast<int>(absl::ToDoubleSeconds(d1)));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: duration should be converted directly to an integer rather than through a type cast [abseil-duration-conversion-cast]
|
|
// CHECK-FIXES: i = EXTERNAL(absl::ToInt64Seconds(d1));
|
|
#undef EXTERNAL
|
|
|
|
// We don't want to transform this which get split across macro boundaries
|
|
#define SPLIT(x) static_cast<int>((x)) + 5
|
|
i = SPLIT(absl::ToDoubleSeconds(d1));
|
|
#undef SPLIT
|
|
|
|
// We also don't want to transform things inside of a macro definition
|
|
#define INTERNAL(x) static_cast<int>(absl::ToDoubleSeconds((x))) + 5
|
|
i = INTERNAL(d1);
|
|
#undef INTERNAL
|
|
|
|
// These shouldn't be converted
|
|
i = static_cast<int>(absl::ToInt64Seconds(d1));
|
|
i = static_cast<float>(absl::ToDoubleSeconds(d1));
|
|
}
|