derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
48 lines
1.6 KiB
Diff
48 lines
1.6 KiB
Diff
From ee6c6faf195dad595909a51a0383653226f23d94 Mon Sep 17 00:00:00 2001
|
|
From: Nick Kuo <139732210+amd-nicknick@users.noreply.github.com>
|
|
Date: Wed, 20 May 2026 16:46:12 +0000
|
|
Subject: [PATCH] Remove hardcoded /Zi and /DEBUG flags from CMake
|
|
|
|
ccache does not support /Zi since it's impossible to track the separate
|
|
PDB file generated during compilation. Projects should not include such
|
|
flags in their CMake files without a clean way to remove them.
|
|
|
|
Explicitly removes the /Zi and /DEBUG compile & link flags. Let upstream
|
|
projects decide and specify them.
|
|
|
|
third-party/host-blas/host-blas
|
|
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
Total compilations: 6961
|
|
Cache hit: 2 ( 0.0%)
|
|
Cache miss: 2324 ( 33.4%)
|
|
Uncacheable: 4635 ( 66.6%)
|
|
Cacheable rate: 33.4% (2326/6961)
|
|
Uncacheable rate: 66.6% (4635/6961)
|
|
|
|
Uncacheable reasons:
|
|
[unsupported_compiler_option] x4635
|
|
-> /Zi (4635 occurrences)
|
|
|
|
See-also: https://github.com/ROCm/TheRock/issues/4519
|
|
See-also: https://github.com/ROCm/TheRock/pull/4419
|
|
---
|
|
CMakeLists.txt | 2 --
|
|
1 file changed, 2 deletions(-)
|
|
|
|
diff --git a/CMakeLists.txt b/CMakeLists.txt
|
|
index 4f0e82096..1d86a1701 100644
|
|
--- a/CMakeLists.txt
|
|
+++ b/CMakeLists.txt
|
|
@@ -231,8 +231,6 @@ if(MSVC)
|
|
if (${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION} VERSION_LESS 3.4)
|
|
set(OpenBLAS_DEF_FILE "${PROJECT_BINARY_DIR}/openblas.def")
|
|
endif()
|
|
- set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} /Zi")
|
|
- set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "${CMAKE_SHARED_LINKER_FLAGS_RELEASE} /DEBUG /OPT:REF /OPT:ICF")
|
|
endif()
|
|
|
|
if (${DYNAMIC_ARCH})
|
|
--
|
|
2.53.0
|
|
|