derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
24 lines
1.2 KiB
Plaintext
24 lines
1.2 KiB
Plaintext
---
|
|
description: Use the rocm-pr-quality skill when authoring, reviewing, or pre-merge-gating a pull request in this repo
|
|
alwaysApply: false
|
|
---
|
|
|
|
# ROCm PR Quality
|
|
|
|
When the user is authoring, reviewing, or deciding whether it is safe to merge a pull request,
|
|
read and apply [`skills/rocm-pr-quality/SKILL.md`](../../skills/rocm-pr-quality/SKILL.md) and its
|
|
`reference.md` before proceeding. It is the library-agnostic base skill; component repositories
|
|
layer thin overlays on top that may tighten but never weaken its MUST rules.
|
|
|
|
For PRs touching TheRock's build itself — the superbuild/CMake, submodules and patches,
|
|
`artifact-*.toml` / `BUILD_TOPOLOGY.toml`, or reusable CI workflows — also read and apply the
|
|
TheRock overlay [`skills/therock-pr-quality/SKILL.md`](../../skills/therock-pr-quality/SKILL.md),
|
|
which extends the base and defers to the canonical `docs/development/style_guides/`.
|
|
|
|
Key behaviors the skill enforces:
|
|
|
|
- One entry point, three actions: author assist, review assist, pre-merge gate.
|
|
- Advisory and paved-road, not a compliance cop.
|
|
- Never post PR descriptions, review comments, labels, or merges to GitHub/Jira without explicit
|
|
human approval — draft the text and wait.
|