Files
TheRock/compiler/amd-llvm/amd/comgr/test-unit/hotswap/rewriter/HotswapOccupancyTest.cpp
T
derek.holloway 7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
Flatten subprojects into a single base monorepo
2026-09-02 16:34:47 -07:00

212 lines
7.8 KiB
C++

//===- HotswapOccupancyTest.cpp - HotSwap capacity policy tests ----------===//
//
// Part of Comgr, under the Apache License v2.0 with LLVM Exceptions. See
// amd/comgr/LICENSE.TXT in this repository for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "comgr-test-elf-utils.h"
#include "hotswap/rewriter/internal.h"
#include "gtest/gtest.h"
#include <cassert>
using namespace COMGR::hotswap;
namespace {
RewriteConfig makeOccupancyConfig() {
RewriteConfig Config;
Config.TargetCpu = "gfx1250";
Config.VgprGranuleSize = 16;
return Config;
}
comgr_test::KernelDescriptorElf makeOccupancyElf(unsigned VgprCount) {
namespace hsa = llvm::amdhsa;
constexpr unsigned VgprGranule = 16;
assert(VgprCount != 0 && (VgprCount % VgprGranule) == 0);
uint32_t Rsrc1 = 0;
AMDHSA_BITS_SET(Rsrc1, hsa::COMPUTE_PGM_RSRC1_GRANULATED_WORKITEM_VGPR_COUNT,
VgprCount / VgprGranule - 1);
comgr_test::KernelDescriptorElfOptions Options;
Options.ComputePgmRsrc1 = Rsrc1;
Options.MetadataVgprCount = VgprCount;
Options.MetadataMaxFlatWorkgroupSize = 1024;
Options.MetadataWavefrontSize = 32;
return comgr_test::makeKernelDescriptorElf(std::vector<uint8_t>(4), Options);
}
class KernelVgprBumpFixture {
public:
explicit KernelVgprBumpFixture(unsigned VgprCount)
: Config(makeOccupancyConfig()), Obj(makeOccupancyElf(VgprCount)),
Elf(llvm::cantFail(
ElfView::create(Obj.Bytes.data(), Obj.Bytes.size()))),
Prof(/*Enabled=*/false), Ctx{Config,
Decoded,
Elf.textData(),
Elf.textSize(),
/*PoolBaseOffset=*/0,
LS,
Trampolines,
Sleds,
Elf,
Liveness,
KernelStats,
ScratchPatches,
ControlFlow,
Prof} {}
RewriteConfig Config;
comgr_test::KernelDescriptorElf Obj;
ElfView Elf;
LLVMState LS;
std::vector<InternalDecodedInst> Decoded;
std::vector<Trampoline> Trampolines;
std::vector<NopSled> Sleds;
LivenessInfo Liveness;
llvm::StringMap<KernelPatchStats> KernelStats;
std::vector<ScratchPatchInfo> ScratchPatches;
DirectControlFlowInfo ControlFlow;
HotswapProfile Prof;
PatchContext Ctx;
};
} // namespace
TEST(HotswapOccupancy, LoadsGfx1250LimitsFromComgrIsaMetadata) {
std::optional<SubtargetOccupancyLimits> Limits =
getSubtargetOccupancyLimits("gfx1250");
ASSERT_TRUE(Limits.has_value());
EXPECT_EQ(Limits->EUsPerCU, 4u);
EXPECT_EQ(Limits->MaxWavesPerCU, 40u);
EXPECT_EQ(Limits->MaxFlatWorkgroupSize, 1024u);
EXPECT_EQ(Limits->VgprAllocGranule, 16u);
EXPECT_EQ(Limits->TotalNumVgprs, 1024u);
EXPECT_TRUE(Limits->Wave64HalvesVgprCapacity);
}
TEST(HotswapOccupancy, PreservesExactWave32WorkgroupBoundary) {
const SubtargetOccupancyLimits Limits{4, 40, 1024, 16, 1024, true};
std::optional<WorkgroupCapacity> Capacity =
computeWorkgroupCapacity(128, 1024, 32, Limits);
ASSERT_TRUE(Capacity.has_value());
EXPECT_EQ(Capacity->RequiredWavesPerEU, 8u);
EXPECT_EQ(Capacity->AchievableWavesPerEU, 8u);
EXPECT_EQ(decideVgprBump(PatchRequirement::Optional, *Capacity),
VgprBumpDecision::Apply);
EXPECT_EQ(decideVgprBump(PatchRequirement::Required, *Capacity),
VgprBumpDecision::Apply);
}
TEST(HotswapOccupancy, DetectsOneVgprAcrossGranuleBoundary) {
const SubtargetOccupancyLimits Limits{4, 40, 1024, 16, 1024, true};
std::optional<WorkgroupCapacity> Capacity =
computeWorkgroupCapacity(129, 1024, 32, Limits);
ASSERT_TRUE(Capacity.has_value());
EXPECT_EQ(Capacity->RequiredWavesPerEU, 8u);
EXPECT_EQ(Capacity->AchievableWavesPerEU, 7u);
EXPECT_EQ(decideVgprBump(PatchRequirement::Optional, *Capacity),
VgprBumpDecision::Decline);
EXPECT_EQ(decideVgprBump(PatchRequirement::Required, *Capacity),
VgprBumpDecision::Fail);
}
TEST(HotswapOccupancy, HandlesWave64Workgroups) {
const SubtargetOccupancyLimits Limits{4, 40, 1024, 16, 1024, true};
std::optional<WorkgroupCapacity> Capacity =
computeWorkgroupCapacity(128, 1024, 64, Limits);
ASSERT_TRUE(Capacity.has_value());
EXPECT_EQ(Capacity->RequiredWavesPerEU, 4u);
EXPECT_EQ(Capacity->AchievableWavesPerEU, 4u);
std::optional<WorkgroupCapacity> TooMany =
computeWorkgroupCapacity(129, 1024, 64, Limits);
ASSERT_TRUE(TooMany.has_value());
EXPECT_EQ(TooMany->RequiredWavesPerEU, 4u);
EXPECT_EQ(TooMany->AchievableWavesPerEU, 3u);
}
TEST(HotswapOccupancy, RejectsInvalidMetadata) {
const SubtargetOccupancyLimits Limits{4, 40, 1024, 16, 1024, true};
EXPECT_EQ(computeWorkgroupCapacity(128, 0, 32, Limits), std::nullopt);
EXPECT_EQ(computeWorkgroupCapacity(128, 2048, 32, Limits), std::nullopt);
EXPECT_EQ(computeWorkgroupCapacity(128, 1024, 0, Limits), std::nullopt);
EXPECT_EQ(getSubtargetOccupancyLimits("not-a-gpu"), std::nullopt);
}
TEST(HotswapOccupancy, CheckKernelAllowsOccupancyNeutral176PlusOne) {
KernelVgprBumpFixture Fixture(/*VgprCount=*/176);
EXPECT_EQ(checkKernelVgprBump(Fixture.Ctx, "kernel", /*ExtraVgprs=*/1,
PatchRequirement::Optional),
VgprBumpDecision::Apply);
EXPECT_EQ(checkKernelVgprBump(Fixture.Ctx, "kernel", /*ExtraVgprs=*/1,
PatchRequirement::Required),
VgprBumpDecision::Apply);
EXPECT_FALSE(Fixture.Ctx.RequiredPatchFailed);
}
TEST(HotswapOccupancy, CheckKernelRejectsFirstDropAt128PlusOne) {
KernelVgprBumpFixture Fixture(/*VgprCount=*/128);
EXPECT_EQ(checkKernelVgprBump(Fixture.Ctx, "kernel", /*ExtraVgprs=*/1,
PatchRequirement::Optional),
VgprBumpDecision::Decline);
EXPECT_FALSE(Fixture.Ctx.RequiredPatchFailed);
EXPECT_EQ(checkKernelVgprBump(Fixture.Ctx, "kernel", /*ExtraVgprs=*/1,
PatchRequirement::Required),
VgprBumpDecision::Fail);
EXPECT_TRUE(Fixture.Ctx.RequiredPatchFailed);
}
TEST(HotswapOccupancy, RejectsPatchOutsideKnownKernelWithZeroReportedGrowth) {
const std::vector<uint8_t> Text(4);
comgr_test::KernelDescriptorElf Obj =
comgr_test::makeKernelDescriptorElf(Text);
llvm::Expected<ElfView> ViewOrErr =
ElfView::create(Obj.Bytes.data(), Obj.Bytes.size());
ASSERT_TRUE((bool)ViewOrErr) << llvm::toString(ViewOrErr.takeError());
RewriteConfig Config;
LLVMState LS;
std::vector<InternalDecodedInst> Decoded;
std::vector<Trampoline> Trampolines;
std::vector<NopSled> Sleds;
LivenessInfo Liveness;
llvm::StringMap<KernelPatchStats> KernelStats;
std::vector<ScratchPatchInfo> ScratchPatches;
DirectControlFlowInfo ControlFlow;
HotswapProfile Prof(/*Enabled=*/false);
PatchContext Ctx{Config,
Decoded,
ViewOrErr->textData(),
ViewOrErr->textSize(),
/*PoolBaseOffset=*/0,
LS,
Trampolines,
Sleds,
*ViewOrErr,
Liveness,
KernelStats,
ScratchPatches,
ControlFlow,
Prof};
EXPECT_EQ(checkKernelVgprBump(Ctx, /*KernelName=*/{}, /*ExtraVgprs=*/0,
PatchRequirement::Optional),
VgprBumpDecision::Decline);
EXPECT_FALSE(Ctx.RequiredPatchFailed);
EXPECT_EQ(checkKernelVgprBump(Ctx, /*KernelName=*/{}, /*ExtraVgprs=*/0,
PatchRequirement::Required),
VgprBumpDecision::Fail);
EXPECT_TRUE(Ctx.RequiredPatchFailed);
}