CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
62 lines
2.2 KiB
C++
62 lines
2.2 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "AvoidGotoCheck.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::cppcoreguidelines {
|
|
|
|
namespace {
|
|
AST_MATCHER(GotoStmt, isForwardJumping) {
|
|
return Node.getBeginLoc() < Node.getLabel()->getBeginLoc();
|
|
}
|
|
|
|
AST_MATCHER(GotoStmt, isInMacro) {
|
|
return Node.getBeginLoc().isMacroID() && Node.getEndLoc().isMacroID();
|
|
}
|
|
} // namespace
|
|
|
|
AvoidGotoCheck::AvoidGotoCheck(StringRef Name, ClangTidyContext *Context)
|
|
: ClangTidyCheck(Name, Context),
|
|
IgnoreMacros(Options.get("IgnoreMacros", false)) {}
|
|
|
|
void AvoidGotoCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
|
|
Options.store(Opts, "IgnoreMacros", IgnoreMacros);
|
|
}
|
|
|
|
void AvoidGotoCheck::registerMatchers(MatchFinder *Finder) {
|
|
// TODO: This check does not recognize `IndirectGotoStmt` which is a
|
|
// GNU extension. These must be matched separately and an AST matcher
|
|
// is currently missing for them.
|
|
|
|
// Check if the 'goto' is used for control flow other than jumping
|
|
// out of a nested loop.
|
|
auto Loop = mapAnyOf(forStmt, cxxForRangeStmt, whileStmt, doStmt);
|
|
auto NestedLoop = Loop.with(hasAncestor(Loop));
|
|
|
|
const ast_matchers::internal::Matcher<GotoStmt> Anything = anything();
|
|
|
|
Finder->addMatcher(gotoStmt(IgnoreMacros ? unless(isInMacro()) : Anything,
|
|
anyOf(unless(hasAncestor(NestedLoop)),
|
|
unless(isForwardJumping())))
|
|
.bind("goto"),
|
|
this);
|
|
}
|
|
|
|
void AvoidGotoCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *Goto = Result.Nodes.getNodeAs<GotoStmt>("goto");
|
|
|
|
diag(Goto->getGotoLoc(), "avoid using 'goto' for flow control")
|
|
<< Goto->getSourceRange();
|
|
diag(Goto->getLabel()->getBeginLoc(), "label defined here",
|
|
DiagnosticIDs::Note);
|
|
}
|
|
} // namespace clang::tidy::cppcoreguidelines
|