CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
88 lines
3.2 KiB
C++
88 lines
3.2 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include <string>
|
|
|
|
#include "AvoidUnderscoreInGoogletestNameCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/Frontend/CompilerInstance.h"
|
|
#include "clang/Lex/MacroArgs.h"
|
|
#include "clang/Lex/PPCallbacks.h"
|
|
#include "clang/Lex/Preprocessor.h"
|
|
|
|
namespace clang::tidy::google::readability {
|
|
|
|
constexpr StringRef KDisabledTestPrefix = "DISABLED_";
|
|
|
|
// Determines whether the macro is a Googletest test macro.
|
|
static bool isGoogletestTestMacro(StringRef MacroName) {
|
|
static const llvm::StringSet<> MacroNames = {"TEST", "TEST_F", "TEST_P",
|
|
"TYPED_TEST", "TYPED_TEST_P"};
|
|
return MacroNames.contains(MacroName);
|
|
}
|
|
|
|
namespace {
|
|
|
|
class AvoidUnderscoreInGoogletestNameCallback : public PPCallbacks {
|
|
public:
|
|
AvoidUnderscoreInGoogletestNameCallback(
|
|
Preprocessor *PP, AvoidUnderscoreInGoogletestNameCheck *Check)
|
|
: PP(PP), Check(Check) {}
|
|
|
|
// Detects expansions of the TEST, TEST_F, TEST_P, TYPED_TEST, TYPED_TEST_P
|
|
// macros and checks that their arguments do not have any underscores.
|
|
void MacroExpands(const Token &MacroNameToken,
|
|
const MacroDefinition &MacroDefinition, SourceRange Range,
|
|
const MacroArgs *Args) override {
|
|
const IdentifierInfo *NameIdentifierInfo =
|
|
MacroNameToken.getIdentifierInfo();
|
|
if (!NameIdentifierInfo)
|
|
return;
|
|
const StringRef MacroName = NameIdentifierInfo->getName();
|
|
if (!isGoogletestTestMacro(MacroName) || !Args ||
|
|
Args->getNumMacroArguments() < 2)
|
|
return;
|
|
const Token *TestSuiteNameToken = Args->getUnexpArgument(0);
|
|
const Token *TestNameToken = Args->getUnexpArgument(1);
|
|
if (!TestSuiteNameToken || !TestNameToken)
|
|
return;
|
|
const std::string TestSuiteNameMaybeDisabled =
|
|
PP->getSpelling(*TestSuiteNameToken);
|
|
StringRef TestSuiteName = TestSuiteNameMaybeDisabled;
|
|
TestSuiteName.consume_front(KDisabledTestPrefix);
|
|
if (TestSuiteName.contains('_'))
|
|
Check->diag(TestSuiteNameToken->getLocation(),
|
|
"avoid using \"_\" in test suite name \"%0\" according to "
|
|
"Googletest FAQ")
|
|
<< TestSuiteName;
|
|
|
|
const std::string TestNameMaybeDisabled = PP->getSpelling(*TestNameToken);
|
|
StringRef TestName = TestNameMaybeDisabled;
|
|
TestName.consume_front(KDisabledTestPrefix);
|
|
if (TestName.contains('_'))
|
|
Check->diag(TestNameToken->getLocation(),
|
|
"avoid using \"_\" in test name \"%0\" according to "
|
|
"Googletest FAQ")
|
|
<< TestName;
|
|
}
|
|
|
|
private:
|
|
Preprocessor *PP;
|
|
AvoidUnderscoreInGoogletestNameCheck *Check;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
void AvoidUnderscoreInGoogletestNameCheck::registerPPCallbacks(
|
|
const SourceManager &SM, Preprocessor *PP, Preprocessor *ModuleExpanderPP) {
|
|
PP->addPPCallbacks(
|
|
std::make_unique<AvoidUnderscoreInGoogletestNameCallback>(PP, this));
|
|
}
|
|
|
|
} // namespace clang::tidy::google::readability
|