CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
63 lines
2.3 KiB
C++
63 lines
2.3 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "UseAnonymousNamespaceCheck.h"
|
|
#include "../utils/FileExtensionsUtils.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::misc {
|
|
namespace {
|
|
AST_POLYMORPHIC_MATCHER_P(isInHeaderFile,
|
|
AST_POLYMORPHIC_SUPPORTED_TYPES(FunctionDecl,
|
|
VarDecl),
|
|
const FileExtensionsSet *, HeaderFileExtensions) {
|
|
return utils::isExpansionLocInHeaderFile(
|
|
Node.getBeginLoc(), Finder->getASTContext().getSourceManager(),
|
|
*HeaderFileExtensions);
|
|
}
|
|
|
|
AST_MATCHER(FunctionDecl, isMemberFunction) {
|
|
return isa<CXXMethodDecl>(&Node);
|
|
}
|
|
AST_MATCHER(VarDecl, isStaticDataMember) { return Node.isStaticDataMember(); }
|
|
} // namespace
|
|
|
|
UseAnonymousNamespaceCheck::UseAnonymousNamespaceCheck(
|
|
StringRef Name, ClangTidyContext *Context)
|
|
: ClangTidyCheck(Name, Context) {}
|
|
|
|
void UseAnonymousNamespaceCheck::registerMatchers(MatchFinder *Finder) {
|
|
Finder->addMatcher(
|
|
functionDecl(isStaticStorageClass(),
|
|
unless(anyOf(isInHeaderFile(&getHeaderFileExtensions()),
|
|
isInAnonymousNamespace(), isMemberFunction())))
|
|
.bind("x"),
|
|
this);
|
|
Finder->addMatcher(
|
|
varDecl(isStaticStorageClass(),
|
|
unless(anyOf(isInHeaderFile(&getHeaderFileExtensions()),
|
|
isInAnonymousNamespace(), isStaticLocal(),
|
|
isStaticDataMember(), hasType(isConstQualified()))))
|
|
.bind("x"),
|
|
this);
|
|
}
|
|
|
|
void UseAnonymousNamespaceCheck::check(const MatchFinder::MatchResult &Result) {
|
|
if (const auto *MatchedDecl = Result.Nodes.getNodeAs<NamedDecl>("x")) {
|
|
const StringRef Type = isa<VarDecl>(MatchedDecl) ? "variable" : "function";
|
|
diag(MatchedDecl->getLocation(),
|
|
"%0 %1 declared 'static', move to anonymous namespace instead")
|
|
<< Type << MatchedDecl;
|
|
}
|
|
}
|
|
|
|
} // namespace clang::tidy::misc
|