CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
80 lines
3.0 KiB
C++
80 lines
3.0 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "InefficientStringConcatenationCheck.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::performance {
|
|
|
|
void InefficientStringConcatenationCheck::storeOptions(
|
|
ClangTidyOptions::OptionMap &Opts) {
|
|
Options.store(Opts, "StrictMode", StrictMode);
|
|
}
|
|
|
|
InefficientStringConcatenationCheck::InefficientStringConcatenationCheck(
|
|
StringRef Name, ClangTidyContext *Context)
|
|
: ClangTidyCheck(Name, Context),
|
|
StrictMode(Options.get("StrictMode", false)) {}
|
|
|
|
void InefficientStringConcatenationCheck::registerMatchers(
|
|
MatchFinder *Finder) {
|
|
const auto BasicStringType =
|
|
hasType(qualType(hasUnqualifiedDesugaredType(recordType(
|
|
hasDeclaration(cxxRecordDecl(hasName("::std::basic_string")))))));
|
|
|
|
const auto BasicStringPlusOperator = cxxOperatorCallExpr(
|
|
hasOverloadedOperatorName("+"),
|
|
hasAnyArgument(ignoringImpCasts(declRefExpr(BasicStringType))));
|
|
|
|
const auto PlusOperator =
|
|
cxxOperatorCallExpr(
|
|
hasOverloadedOperatorName("+"),
|
|
hasAnyArgument(ignoringImpCasts(declRefExpr(BasicStringType))),
|
|
hasDescendant(BasicStringPlusOperator))
|
|
.bind("plusOperator");
|
|
|
|
const auto AssignOperator = cxxOperatorCallExpr(
|
|
hasOverloadedOperatorName("="),
|
|
hasArgument(0, declRefExpr(BasicStringType,
|
|
hasDeclaration(decl().bind("lhsStrT")))
|
|
.bind("lhsStr")),
|
|
hasArgument(1, stmt(hasDescendant(declRefExpr(
|
|
hasDeclaration(decl(equalsBoundNode("lhsStrT"))))))),
|
|
hasDescendant(BasicStringPlusOperator));
|
|
|
|
if (StrictMode) {
|
|
Finder->addMatcher(cxxOperatorCallExpr(anyOf(AssignOperator, PlusOperator)),
|
|
this);
|
|
} else {
|
|
Finder->addMatcher(cxxOperatorCallExpr(anyOf(AssignOperator, PlusOperator),
|
|
hasAncestor(stmt(anyOf(
|
|
cxxForRangeStmt(), whileStmt(),
|
|
forStmt(), doStmt())))),
|
|
this);
|
|
}
|
|
}
|
|
|
|
void InefficientStringConcatenationCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
const auto *LhsStr = Result.Nodes.getNodeAs<DeclRefExpr>("lhsStr");
|
|
const auto *PlusOperator =
|
|
Result.Nodes.getNodeAs<CXXOperatorCallExpr>("plusOperator");
|
|
const char *DiagMsg =
|
|
"string concatenation results in allocation of unnecessary temporary "
|
|
"strings; consider using 'operator+=' or 'string::append()' instead";
|
|
|
|
if (LhsStr)
|
|
diag(LhsStr->getExprLoc(), DiagMsg);
|
|
else if (PlusOperator)
|
|
diag(PlusOperator->getExprLoc(), DiagMsg);
|
|
}
|
|
|
|
} // namespace clang::tidy::performance
|