CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
67 lines
2.2 KiB
C++
67 lines
2.2 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "RedundantLambdaParameterListCheck.h"
|
|
#include "../utils/LexerUtils.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::readability {
|
|
|
|
namespace {
|
|
|
|
AST_MATCHER(LambdaExpr, hasRedundantParens) {
|
|
return Node.hasExplicitParameters() &&
|
|
Node.getCallOperator()->getNumParams() == 0 &&
|
|
!Node.getCallOperator()->getTrailingRequiresClause();
|
|
}
|
|
|
|
} // namespace
|
|
|
|
void RedundantLambdaParameterListCheck::registerMatchers(MatchFinder *Finder) {
|
|
Finder->addMatcher(lambdaExpr(hasRedundantParens()).bind("lambda"), this);
|
|
}
|
|
|
|
void RedundantLambdaParameterListCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
const auto *Lambda = Result.Nodes.getNodeAs<LambdaExpr>("lambda");
|
|
|
|
const LangOptions &LangOpts = getLangOpts();
|
|
|
|
const FunctionTypeLoc FTL = Lambda->getCallOperator()->getFunctionTypeLoc();
|
|
const SourceLocation LParenLoc = FTL.getLParenLoc();
|
|
const SourceLocation RParenLoc = FTL.getRParenLoc();
|
|
|
|
if (LParenLoc.isInvalid() || RParenLoc.isInvalid())
|
|
return;
|
|
|
|
// Ensure parens are truly empty (reject "(void)")
|
|
const std::optional<Token> FirstInParens =
|
|
utils::lexer::findNextTokenSkippingComments(
|
|
LParenLoc, *Result.SourceManager, LangOpts);
|
|
|
|
if (!FirstInParens || FirstInParens->getLocation() != RParenLoc)
|
|
return;
|
|
|
|
const std::optional<Token> NextAfterParenTok =
|
|
utils::lexer::findNextTokenSkippingComments(
|
|
RParenLoc, *Result.SourceManager, LangOpts);
|
|
|
|
if (!NextAfterParenTok || NextAfterParenTok->is(tok::l_square))
|
|
return;
|
|
|
|
if (!LangOpts.CPlusPlus23 && NextAfterParenTok->isNot(tok::l_brace))
|
|
return;
|
|
|
|
diag(LParenLoc, "redundant empty parameter list in lambda expression")
|
|
<< FixItHint::CreateRemoval(LParenLoc)
|
|
<< FixItHint::CreateRemoval(RParenLoc);
|
|
}
|
|
|
|
} // namespace clang::tidy::readability
|