Files
TheRock/compiler/amd-llvm/clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp
T
derek.holloway 7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
Flatten subprojects into a single base monorepo
2026-09-02 16:34:47 -07:00

894 lines
33 KiB
C++

//===--- DefineOutline.cpp ---------------------------------------*- C++-*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "AST.h"
#include "FindSymbols.h"
#include "FindTarget.h"
#include "HeaderSourceSwitch.h"
#include "ParsedAST.h"
#include "Selection.h"
#include "SourceCode.h"
#include "refactor/Tweak.h"
#include "support/Logger.h"
#include "support/Path.h"
#include "clang/AST/ASTTypeTraits.h"
#include "clang/AST/Attr.h"
#include "clang/AST/Decl.h"
#include "clang/AST/DeclBase.h"
#include "clang/AST/DeclCXX.h"
#include "clang/AST/DeclTemplate.h"
#include "clang/AST/Stmt.h"
#include "clang/Basic/SourceLocation.h"
#include "clang/Basic/SourceManager.h"
#include "clang/Basic/TokenKinds.h"
#include "clang/Tooling/Core/Replacement.h"
#include "clang/Tooling/Syntax/Tokens.h"
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Casting.h"
#include "llvm/Support/Error.h"
#include <cstddef>
#include <optional>
#include <string>
#include <tuple>
namespace clang {
namespace clangd {
namespace {
// Deduces the FunctionDecl from a selection. Requires either the function body
// or the function decl to be selected. Returns null if none of the above
// criteria is met.
// FIXME: This is shared with define inline, move them to a common header once
// we have a place for such.
const FunctionDecl *getSelectedFunction(const SelectionTree::Node *SelNode) {
if (!SelNode)
return nullptr;
const DynTypedNode &AstNode = SelNode->ASTNode;
if (const FunctionDecl *FD = AstNode.get<FunctionDecl>())
return FD;
if (AstNode.get<CompoundStmt>() &&
SelNode->Selected == SelectionTree::Complete) {
if (const SelectionTree::Node *P = SelNode->Parent)
return P->ASTNode.get<FunctionDecl>();
}
return nullptr;
}
std::optional<Path> getSourceFile(llvm::StringRef FileName,
const Tweak::Selection &Sel) {
assert(Sel.FS);
if (auto Source = getCorrespondingHeaderOrSource(FileName, Sel.FS))
return *Source;
return getCorrespondingHeaderOrSource(FileName, *Sel.AST, Sel.Index);
}
// Synthesize a DeclContext for TargetNS from CurContext. TargetNS must be empty
// for global namespace, and endwith "::" otherwise.
// Returns std::nullopt if TargetNS is not a prefix of CurContext.
std::optional<const DeclContext *>
findContextForNS(llvm::StringRef TargetNS, const DeclContext *CurContext) {
assert(TargetNS.empty() || TargetNS.ends_with("::"));
// Skip any non-namespace contexts, e.g. TagDecls, functions/methods.
CurContext = CurContext->getEnclosingNamespaceContext();
// If TargetNS is empty, it means global ns, which is translation unit.
if (TargetNS.empty()) {
while (!CurContext->isTranslationUnit())
CurContext = CurContext->getParent();
return CurContext;
}
// Otherwise we need to drop any trailing namespaces from CurContext until
// we reach TargetNS.
std::string TargetContextNS =
CurContext->isNamespace()
? llvm::cast<NamespaceDecl>(CurContext)->getQualifiedNameAsString()
: "";
TargetContextNS.append("::");
llvm::StringRef CurrentContextNS(TargetContextNS);
// If TargetNS is not a prefix of CurrentContext, there's no way to reach
// it.
if (!CurrentContextNS.starts_with(TargetNS))
return std::nullopt;
while (CurrentContextNS != TargetNS) {
CurContext = CurContext->getParent();
// These colons always exists since TargetNS is a prefix of
// CurrentContextNS, it ends with "::" and they are not equal.
CurrentContextNS = CurrentContextNS.take_front(
CurrentContextNS.drop_back(2).rfind("::") + 2);
}
return CurContext;
}
// Returns source code for FD after applying Replacements.
// FIXME: Make the function take a parameter to return only the function body,
// afterwards it can be shared with define-inline code action.
llvm::Expected<std::string>
getFunctionSourceAfterReplacements(const FunctionDecl *FD,
const tooling::Replacements &Replacements,
bool TargetFileIsHeader) {
const auto &SM = FD->getASTContext().getSourceManager();
auto OrigFuncRange = toHalfOpenFileRange(
SM, FD->getASTContext().getLangOpts(), FD->getSourceRange());
if (!OrigFuncRange)
return error("Couldn't get range for function.");
// Get new begin and end positions for the qualified function definition.
unsigned FuncBegin = SM.getFileOffset(OrigFuncRange->getBegin());
unsigned FuncEnd = Replacements.getShiftedCodePosition(
SM.getFileOffset(OrigFuncRange->getEnd()));
// Trim the result to function definition.
auto QualifiedFunc = tooling::applyAllReplacements(
SM.getBufferData(SM.getMainFileID()), Replacements);
if (!QualifiedFunc)
return QualifiedFunc.takeError();
auto Source = QualifiedFunc->substr(FuncBegin, FuncEnd - FuncBegin + 1);
std::string TemplatePrefix;
auto AddToTemplatePrefixIfApplicable = [&](const Decl *D) {
const TemplateParameterList *Params = D->getDescribedTemplateParams();
if (!Params)
return;
for (Decl *P : *Params) {
if (auto *TTP = dyn_cast<TemplateTypeParmDecl>(P))
TTP->removeDefaultArgument();
else if (auto *NTTP = dyn_cast<NonTypeTemplateParmDecl>(P))
NTTP->removeDefaultArgument();
else if (auto *TTPD = dyn_cast<TemplateTemplateParmDecl>(P))
TTPD->removeDefaultArgument();
}
std::string S;
llvm::raw_string_ostream Stream(S);
Params->print(Stream, FD->getASTContext());
if (!S.empty())
*S.rbegin() = '\n'; // Replace space with newline
TemplatePrefix.insert(0, S);
};
AddToTemplatePrefixIfApplicable(FD);
if (auto *MD = llvm::dyn_cast<CXXMethodDecl>(FD)) {
for (const CXXRecordDecl *Parent = MD->getParent(); Parent;
Parent =
llvm::dyn_cast_or_null<const CXXRecordDecl>(Parent->getParent())) {
AddToTemplatePrefixIfApplicable(Parent);
}
}
if (TargetFileIsHeader)
Source.insert(0, "inline ");
if (!TemplatePrefix.empty())
Source.insert(0, TemplatePrefix);
if (!FD->hasBody() && !FD->isExplicitlyDefaulted()) {
Source.pop_back(); // The semicolon finishing the declaration.
Source += " {";
if (!FD->getReturnType()->isVoidType())
Source += " return {}; ";
Source += "}";
}
return Source;
}
// Returns replacements to delete tokens with kind `Kind` in the range
// `FromRange`. Removes matching instances of given token preceeding the
// function defition.
llvm::Expected<tooling::Replacements>
deleteTokensWithKind(const syntax::TokenBuffer &TokBuf, tok::TokenKind Kind,
SourceRange FromRange) {
tooling::Replacements DelKeywordCleanups;
llvm::Error Errors = llvm::Error::success();
bool FoundAny = false;
for (const auto &Tok : TokBuf.expandedTokens(FromRange)) {
if (Tok.kind() != Kind)
continue;
FoundAny = true;
auto Spelling = TokBuf.spelledForExpanded(llvm::ArrayRef(Tok));
if (!Spelling) {
Errors = llvm::joinErrors(
std::move(Errors),
error("define outline: couldn't remove `{0}` keyword.",
tok::getKeywordSpelling(Kind)));
break;
}
auto &SM = TokBuf.sourceManager();
CharSourceRange DelRange =
syntax::Token::range(SM, Spelling->front(), Spelling->back())
.toCharRange(SM);
if (auto Err =
DelKeywordCleanups.add(tooling::Replacement(SM, DelRange, "")))
Errors = llvm::joinErrors(std::move(Errors), std::move(Err));
}
if (!FoundAny) {
Errors = llvm::joinErrors(
std::move(Errors),
error("define outline: couldn't find `{0}` keyword to remove.",
tok::getKeywordSpelling(Kind)));
}
if (Errors)
return std::move(Errors);
return DelKeywordCleanups;
}
// Creates a modified version of function definition that can be inserted at a
// different location, qualifies return value and function name to achieve that.
// Contains function signature, except defaulted parameter arguments, body and
// template parameters if applicable. No need to qualify parameters, as they are
// looked up in the context containing the function/method.
// FIXME: Drop attributes in function signature.
llvm::Expected<std::string>
getFunctionSourceCode(const FunctionDecl *FD, const DeclContext *TargetContext,
const syntax::TokenBuffer &TokBuf,
const HeuristicResolver *Resolver,
bool TargetFileIsHeader) {
auto &AST = FD->getASTContext();
auto &SM = AST.getSourceManager();
llvm::Error Errors = llvm::Error::success();
tooling::Replacements DeclarationCleanups;
// Finds the first unqualified name in function return type and name, then
// qualifies those to be valid in TargetContext.
findExplicitReferences(
FD,
[&](ReferenceLoc Ref) {
// It is enough to qualify the first qualifier, so skip references with
// a qualifier. Also we can't do much if there are no targets or name is
// inside a macro body.
if (Ref.Qualifier || Ref.Targets.empty() || Ref.NameLoc.isMacroID())
return;
// Only qualify return type and function name.
if (auto ReturnTypeRange = FD->getReturnTypeSourceRange();
Ref.NameLoc != FD->getLocation() &&
(ReturnTypeRange.isInvalid() ||
SM.isBeforeInTranslationUnit(Ref.NameLoc,
ReturnTypeRange.getBegin()) ||
SM.isBeforeInTranslationUnit(ReturnTypeRange.getEnd(),
Ref.NameLoc)))
return;
for (const NamedDecl *ND : Ref.Targets) {
if (ND->getKind() == Decl::TemplateTypeParm)
return;
if (ND->getDeclContext() != Ref.Targets.front()->getDeclContext()) {
elog("Targets from multiple contexts: {0}, {1}",
printQualifiedName(*Ref.Targets.front()),
printQualifiedName(*ND));
return;
}
}
const NamedDecl *ND = Ref.Targets.front();
std::string Qualifier =
getQualification(AST, TargetContext,
SM.getLocForStartOfFile(SM.getMainFileID()), ND);
if (ND->getDeclContext()->isDependentContext() &&
llvm::isa<TypeDecl>(ND)) {
Qualifier.insert(0, "typename ");
}
if (auto Err = DeclarationCleanups.add(
tooling::Replacement(SM, Ref.NameLoc, 0, Qualifier)))
Errors = llvm::joinErrors(std::move(Errors), std::move(Err));
},
Resolver);
// findExplicitReferences doesn't provide references to
// constructor/destructors, it only provides references to type names inside
// them.
// this works for constructors, but doesn't work for destructor as type name
// doesn't cover leading `~`, so handle it specially.
if (const auto *Destructor = llvm::dyn_cast<CXXDestructorDecl>(FD)) {
if (auto Err = DeclarationCleanups.add(tooling::Replacement(
SM, Destructor->getLocation(), 0,
getQualification(AST, TargetContext,
SM.getLocForStartOfFile(SM.getMainFileID()),
Destructor))))
Errors = llvm::joinErrors(std::move(Errors), std::move(Err));
}
// Get rid of default arguments, since they should not be specified in
// out-of-line definition.
for (const auto *PVD : FD->parameters()) {
if (!PVD->hasDefaultArg())
continue;
// Deletion range spans the initializer, usually excluding the `=`.
auto DelRange = CharSourceRange::getTokenRange(PVD->getDefaultArgRange());
// Get all tokens before the default argument.
auto Tokens = TokBuf.expandedTokens(PVD->getSourceRange())
.take_while([&SM, &DelRange](const syntax::Token &Tok) {
return SM.isBeforeInTranslationUnit(
Tok.location(), DelRange.getBegin());
});
if (TokBuf.expandedTokens(DelRange.getAsRange()).front().kind() !=
tok::equal) {
// Find the last `=` if it isn't included in the initializer, and update
// the DelRange to include it.
auto Tok =
llvm::find_if(llvm::reverse(Tokens), [](const syntax::Token &Tok) {
return Tok.kind() == tok::equal;
});
assert(Tok != Tokens.rend());
DelRange.setBegin(Tok->location());
}
if (auto Err =
DeclarationCleanups.add(tooling::Replacement(SM, DelRange, "")))
Errors = llvm::joinErrors(std::move(Errors), std::move(Err));
}
auto DelAttr = [&](const Attr *A) {
if (!A)
return;
auto AttrTokens =
TokBuf.spelledForExpanded(TokBuf.expandedTokens(A->getRange()));
assert(A->getLocation().isValid());
if (!AttrTokens || AttrTokens->empty()) {
Errors = llvm::joinErrors(
std::move(Errors), error("define outline: Can't move out of line as "
"function has a macro `{0}` specifier.",
A->getSpelling()));
return;
}
CharSourceRange DelRange =
syntax::Token::range(SM, AttrTokens->front(), AttrTokens->back())
.toCharRange(SM);
if (auto Err =
DeclarationCleanups.add(tooling::Replacement(SM, DelRange, "")))
Errors = llvm::joinErrors(std::move(Errors), std::move(Err));
};
DelAttr(FD->getAttr<OverrideAttr>());
DelAttr(FD->getAttr<FinalAttr>());
auto DelKeyword = [&](tok::TokenKind Kind, SourceRange FromRange) {
auto DelKeywords = deleteTokensWithKind(TokBuf, Kind, FromRange);
if (!DelKeywords) {
Errors = llvm::joinErrors(std::move(Errors), DelKeywords.takeError());
return;
}
DeclarationCleanups = DeclarationCleanups.merge(*DelKeywords);
};
if (FD->isInlineSpecified())
DelKeyword(tok::kw_inline, {FD->getBeginLoc(), FD->getLocation()});
if (const auto *MD = dyn_cast<CXXMethodDecl>(FD)) {
if (MD->isVirtualAsWritten())
DelKeyword(tok::kw_virtual, {FD->getBeginLoc(), FD->getLocation()});
if (MD->isStatic())
DelKeyword(tok::kw_static, {FD->getBeginLoc(), FD->getLocation()});
}
if (const auto *CD = dyn_cast<CXXConstructorDecl>(FD)) {
if (CD->isExplicit())
DelKeyword(tok::kw_explicit, {FD->getBeginLoc(), FD->getLocation()});
}
if (Errors)
return std::move(Errors);
return getFunctionSourceAfterReplacements(FD, DeclarationCleanups,
TargetFileIsHeader);
}
struct InsertionPoint {
const DeclContext *EnclosingNamespace = nullptr;
size_t Offset;
};
enum class RelativeInsertPos { Before, After };
struct InsertionAnchor {
Location Loc;
RelativeInsertPos RelInsertPos = RelativeInsertPos::Before;
};
// Returns the range that should be deleted from declaration, which always
// contains function body. In addition to that it might contain constructor
// initializers.
SourceRange getDeletionRange(const FunctionDecl *FD,
const syntax::TokenBuffer &TokBuf) {
if (!FD->hasBody()) {
if (!FD->isExplicitlyDefaulted())
return {};
auto Tokens = TokBuf.expandedTokens(FD->getSourceRange());
for (auto It = std::rbegin(Tokens); It != std::rend(Tokens); ++It) {
if (It->kind() == tok::kw_default) {
const auto NextIt = std::next(It);
if (NextIt == std::rend(Tokens))
return {};
const auto &ExpandedEquals = *NextIt;
if (ExpandedEquals.kind() != tok::equal)
return {};
auto SpelledEquals =
TokBuf.spelledForExpanded(llvm::ArrayRef(ExpandedEquals));
if (!SpelledEquals)
return {};
return {SpelledEquals->front().location(),
FD->getDefaultLoc().getLocWithOffset(1)};
}
}
return {};
}
auto DeletionRange = FD->getBody()->getSourceRange();
if (auto *CD = llvm::dyn_cast<CXXConstructorDecl>(FD)) {
// AST doesn't contain the location for ":" in ctor initializers. Therefore
// we find it by finding the first ":" before the first ctor initializer.
SourceLocation InitStart;
// Find the first initializer.
for (const auto *CInit : CD->inits()) {
// SourceOrder is -1 for implicit initializers.
if (CInit->getSourceOrder() != 0)
continue;
InitStart = CInit->getSourceLocation();
break;
}
if (InitStart.isValid()) {
auto Toks = TokBuf.expandedTokens(CD->getSourceRange());
// Drop any tokens after the initializer.
Toks = Toks.take_while([&TokBuf, &InitStart](const syntax::Token &Tok) {
return TokBuf.sourceManager().isBeforeInTranslationUnit(Tok.location(),
InitStart);
});
// Look for the first colon.
auto Tok =
llvm::find_if(llvm::reverse(Toks), [](const syntax::Token &Tok) {
return Tok.kind() == tok::colon;
});
assert(Tok != Toks.rend());
DeletionRange.setBegin(Tok->location());
}
}
return DeletionRange;
}
/// Moves definition of a function/method to an appropriate implementation file.
///
/// Before:
/// a.h
/// void foo() { return; }
/// a.cc
/// #include "a.h"
///
/// ----------------
///
/// After:
/// a.h
/// void foo();
/// a.cc
/// #include "a.h"
/// void foo() { return; }
class DefineOutline : public Tweak {
public:
const char *id() const override;
bool hidden() const override { return false; }
llvm::StringLiteral kind() const override {
return CodeAction::REFACTOR_KIND;
}
std::string title() const override {
if (Source->doesThisDeclarationHaveABody())
return "Move function body to out-of-line";
return "Create function body out-of-line";
}
bool prepare(const Selection &Sel) override {
SameFile = !isHeaderFile(Sel.AST->tuPath(), Sel.AST->getLangOpts());
Source = getSelectedFunction(Sel.ASTSelection.commonAncestor());
// Bail out if the selection is not a function declaration.
if (!Source || Source->isDeleted() || Source->isOutOfLine())
return false;
// Bail out if a definition exists somewhere else.
if (!Source->hasBody() && !Source->isExplicitlyDefaulted()) {
// Check AST first.
if (Source->getDefinition())
return false;
// Then consult the index.
if (Sel.Index) {
bool HasDefinition = false;
// Note: Once other code actions want to start querying the index for
// the symbol under the cursor in their prepare() function, this look-up
// should get consolidated in some manner (e.g. a cache).
Sel.Index->lookup({{getSymbolID(Source)}},
[&HasDefinition](const Symbol &S) {
if (S.Definition)
HasDefinition = true;
});
if (HasDefinition)
return false;
}
}
// Bail out if this is a function template or specialization, as their
// definitions need to be visible in all including translation units.
if (Source->getTemplateSpecializationInfo())
return false;
auto *MD = llvm::dyn_cast<CXXMethodDecl>(Source);
if (!MD) {
if (Source->getDescribedFunctionTemplate())
return false;
// Can't outline free-standing functions in the same file.
return !SameFile;
}
for (const CXXRecordDecl *Parent = MD->getParent(); Parent;
Parent =
llvm::dyn_cast_or_null<const CXXRecordDecl>(Parent->getParent())) {
if (const TemplateParameterList *Params =
Parent->getDescribedTemplateParams()) {
// Class template member functions must be defined in the
// same file.
SameFile = true;
// Bail out if the template parameter is unnamed.
for (NamedDecl *P : *Params) {
if (!P->getIdentifier())
return false;
}
}
}
// Function templates must be defined in the same file.
if (MD->getDescribedTemplate())
SameFile = true;
// The refactoring is meaningless for unnamed classes and namespaces,
// unless we're outlining in the same file
for (const DeclContext *DC = MD->getParent(); DC; DC = DC->getParent()) {
if (auto *ND = llvm::dyn_cast<NamedDecl>(DC)) {
if (ND->getDeclName().isEmpty() &&
(!SameFile || !llvm::dyn_cast<NamespaceDecl>(ND)))
return false;
}
}
// Note that we don't check whether an implementation file exists or not in
// the prepare, since performing disk IO on each prepare request might be
// expensive.
return true;
}
Expected<Effect> apply(const Selection &Sel) override {
const SourceManager &SM = Sel.AST->getSourceManager();
std::optional<Path> CCFile;
auto Anchor = getDefinitionOfAdjacentDecl(Sel);
if (Anchor) {
CCFile = Anchor->Loc.uri.file();
} else {
CCFile = SameFile ? Sel.AST->tuPath().str()
: getSourceFile(Sel.AST->tuPath(), Sel);
}
if (!CCFile)
return error("Couldn't find a suitable implementation file.");
assert(Sel.FS && "FS Must be set in apply");
auto Buffer = Sel.FS->getBufferForFile(*CCFile);
// FIXME: Maybe we should consider creating the implementation file if it
// doesn't exist?
if (!Buffer)
return llvm::errorCodeToError(Buffer.getError());
auto Contents = Buffer->get()->getBuffer();
SourceManagerForFile SMFF(*CCFile, Contents);
std::optional<Position> InsertionPos;
if (Anchor) {
if (auto P = getInsertionPointFromExistingDefinition(
SMFF, **Buffer, Anchor->Loc, Anchor->RelInsertPos, Sel.AST)) {
InsertionPos = *P;
}
}
std::optional<std::size_t> Offset;
const DeclContext *EnclosingNamespace = nullptr;
std::string EnclosingNamespaceName;
if (InsertionPos) {
EnclosingNamespaceName = getNamespaceAtPosition(Contents, *InsertionPos,
Sel.AST->getLangOpts());
} else if (SameFile) {
auto P = getInsertionPointInMainFile(Sel.AST);
if (!P)
return P.takeError();
Offset = P->Offset;
EnclosingNamespace = P->EnclosingNamespace;
} else {
auto Region = getEligiblePoints(
Contents, Source->getQualifiedNameAsString(), Sel.AST->getLangOpts());
assert(!Region.EligiblePoints.empty());
EnclosingNamespaceName = Region.EnclosingNamespace;
InsertionPos = Region.EligiblePoints.back();
}
if (InsertionPos) {
auto O = positionToOffset(Contents, *InsertionPos);
if (!O)
return O.takeError();
Offset = *O;
auto TargetContext =
findContextForNS(EnclosingNamespaceName, Source->getDeclContext());
if (!TargetContext)
return error("define outline: couldn't find a context for target");
EnclosingNamespace = *TargetContext;
}
assert(Offset);
assert(EnclosingNamespace);
auto FuncDef = getFunctionSourceCode(
Source, EnclosingNamespace, Sel.AST->getTokens(),
Sel.AST->getHeuristicResolver(),
SameFile && isHeaderFile(Sel.AST->tuPath(), Sel.AST->getLangOpts()));
if (!FuncDef)
return FuncDef.takeError();
const tooling::Replacement InsertFunctionDef(*CCFile, *Offset, 0, *FuncDef);
auto Effect = Effect::mainFileEdit(
SMFF.get(), tooling::Replacements(InsertFunctionDef));
if (!Effect)
return Effect.takeError();
tooling::Replacements HeaderUpdates;
auto DeletionRange = getDeletionRange(Source, Sel.AST->getTokens());
if (DeletionRange.isValid()) {
if (auto Error = HeaderUpdates.add(tooling::Replacement(
Sel.AST->getSourceManager(),
CharSourceRange::getTokenRange(*toHalfOpenFileRange(
SM, Sel.AST->getLangOpts(), DeletionRange)),
";"))) {
return Error;
}
}
if (Source->isInlineSpecified()) {
auto DelInline =
deleteTokensWithKind(Sel.AST->getTokens(), tok::kw_inline,
{Source->getBeginLoc(), Source->getLocation()});
if (!DelInline)
return DelInline.takeError();
HeaderUpdates = HeaderUpdates.merge(*DelInline);
}
if (SameFile) {
tooling::Replacements &R = Effect->ApplyEdits[*CCFile].Replacements;
R = R.merge(HeaderUpdates);
} else {
auto HeaderFE = Effect::fileEdit(SM, SM.getMainFileID(), HeaderUpdates);
if (!HeaderFE)
return HeaderFE.takeError();
Effect->ApplyEdits.try_emplace(HeaderFE->first,
std::move(HeaderFE->second));
}
return std::move(*Effect);
}
std::optional<InsertionAnchor>
getDefinitionOfAdjacentDecl(const Selection &Sel) {
if (!Sel.Index)
return {};
std::optional<Location> Anchor;
std::string TuURI = URI::createFile(Sel.AST->tuPath()).toString();
auto CheckCandidate = [&](Decl *Candidate) {
assert(Candidate != Source);
if (auto Func = llvm::dyn_cast_or_null<FunctionDecl>(Candidate);
!Func || Func->isThisDeclarationADefinition()) {
return;
}
std::optional<Location> CandidateLoc;
Sel.Index->lookup({{getSymbolID(Candidate)}}, [&](const Symbol &S) {
if (S.Definition) {
if (auto Loc = indexToLSPLocation(S.Definition, Sel.AST->tuPath()))
CandidateLoc = *Loc;
else
log("getDefinitionOfAdjacentDecl: {0}", Loc.takeError());
}
});
if (!CandidateLoc)
return;
// If our definition is constrained to the same file, ignore
// definitions that are not located there.
// If our definition is not constrained to the same file, but
// our anchor definition is in the same file, then we also put our
// definition there, because that appears to be the user preference.
// Exception: If the existing definition is a template, then the
// location is likely due to technical necessity rather than preference,
// so ignore that definition.
bool CandidateSameFile = TuURI == CandidateLoc->uri.uri();
if (SameFile && !CandidateSameFile)
return;
if (!SameFile && CandidateSameFile) {
if (Candidate->isTemplateDecl())
return;
SameFile = true;
}
Anchor = *CandidateLoc;
};
// Try to find adjacent function declarations.
// Determine the closest one by alternatingly going "up" and "down"
// from our function in increasing steps.
const DeclContext *ParentContext = Source->getParent();
const auto SourceIt = llvm::find_if(
ParentContext->decls(), [this](const Decl *D) { return D == Source; });
if (SourceIt == ParentContext->decls_end())
return {};
const int Preceding = std::distance(ParentContext->decls_begin(), SourceIt);
const int Following =
std::distance(SourceIt, ParentContext->decls_end()) - 1;
for (int Offset = 1; Offset <= Preceding || Offset <= Following; ++Offset) {
if (Offset <= Preceding)
CheckCandidate(
*std::next(ParentContext->decls_begin(), Preceding - Offset));
if (Anchor)
return InsertionAnchor{*Anchor, RelativeInsertPos::After};
if (Offset <= Following)
CheckCandidate(*std::next(SourceIt, Offset));
if (Anchor)
return InsertionAnchor{*Anchor, RelativeInsertPos::Before};
}
return {};
}
// Helper function to skip over a matching pair of tokens (e.g., parentheses
// or braces). Returns an iterator to the matching closing token, or the end
// iterator if no matching pair is found.
template <typename Iterator>
Iterator skipTokenPair(Iterator Begin, Iterator End, tok::TokenKind StartKind,
tok::TokenKind EndKind) {
int Count = 0;
for (auto It = Begin; It != End; ++It) {
if (It->kind() == StartKind) {
++Count;
} else if (It->kind() == EndKind) {
if (--Count == 0)
return It;
if (Count < 0)
// We encountered a closing token without a matching opening token.
return End;
}
}
return End;
}
// We don't know the actual start or end of the definition, only the position
// of the name. Therefore, we heuristically try to locate the last token
// before or in this function, respectively. Adapt as required by user code.
std::optional<Position> getInsertionPointFromExistingDefinition(
SourceManagerForFile &SMFF, const llvm::MemoryBuffer &Buffer,
const Location &Loc, RelativeInsertPos RelInsertPos, ParsedAST *AST) {
auto StartOffset = positionToOffset(Buffer.getBuffer(), Loc.range.start);
if (!StartOffset)
return {};
SourceLocation InsertionLoc;
SourceManager &SM = SMFF.get();
auto InsertBefore = [&] {
// Go backwards until we encounter one of the following:
// - An opening brace (of a namespace).
// - A closing brace (of a function definition).
// - A semicolon (of a declaration).
// If no such token was found, then the first token in the file starts the
// definition.
auto Tokens = syntax::tokenize(
syntax::FileRange(SM.getMainFileID(), 0, *StartOffset), SM,
AST->getLangOpts());
if (Tokens.empty())
return;
for (auto I = std::rbegin(Tokens);
InsertionLoc.isInvalid() && I != std::rend(Tokens); ++I) {
switch (I->kind()) {
case tok::l_brace:
case tok::r_brace:
case tok::semi:
if (I != std::rbegin(Tokens))
InsertionLoc = std::prev(I)->location();
else
InsertionLoc = I->endLocation();
break;
default:
break;
}
}
if (InsertionLoc.isInvalid())
InsertionLoc = Tokens.front().location();
};
if (RelInsertPos == RelativeInsertPos::Before) {
InsertBefore();
} else {
// Skip over one top-level pair of parentheses (for the parameter list)
// and one pair of curly braces (for the code block), or `= default`.
// If that fails, insert before the function instead.
auto Tokens =
syntax::tokenize(syntax::FileRange(SM.getMainFileID(), *StartOffset,
Buffer.getBuffer().size()),
SM, AST->getLangOpts());
std::optional<syntax::Token> Tok;
// Skip parameter list (parentheses)
auto ClosingParen = skipTokenPair(Tokens.begin(), Tokens.end(),
tok::l_paren, tok::r_paren);
if (ClosingParen != Tokens.end()) {
// After the closing paren, check for `= default`
auto AfterParams = std::next(ClosingParen);
if (AfterParams != Tokens.end() && AfterParams->kind() == tok::equal) {
auto NextIt = std::next(AfterParams);
if (NextIt != Tokens.end() && NextIt->kind() == tok::kw_default) {
// Find the semicolon after `default`.
auto SemiIt = std::next(NextIt);
if (SemiIt != Tokens.end() && SemiIt->kind() == tok::semi) {
Tok = *SemiIt;
}
}
}
// If not `= default`, skip function body (braces)
if (!Tok && AfterParams != Tokens.end()) {
auto ClosingBrace = skipTokenPair(AfterParams, Tokens.end(),
tok::l_brace, tok::r_brace);
if (ClosingBrace != Tokens.end()) {
Tok = *ClosingBrace;
}
}
}
if (Tok)
InsertionLoc = Tok->endLocation();
else
InsertBefore();
}
if (!InsertionLoc.isValid())
return {};
return sourceLocToPosition(SM, InsertionLoc);
}
// Returns the most natural insertion point in this file.
// This is a fallback for when we failed to find an existing definition to
// place the new one next to. It only considers namespace proximity.
llvm::Expected<InsertionPoint> getInsertionPointInMainFile(ParsedAST *AST) {
// If the definition goes to the same file and there is a namespace,
// we should (and, in the case of anonymous namespaces, need to)
// put the definition into the original namespace block.
auto *Klass = Source->getDeclContext()->getOuterLexicalRecordContext();
if (!Klass)
return error("moving to same file not supported for free functions");
const SourceLocation EndLoc = Klass->getBraceRange().getEnd();
const auto &TokBuf = AST->getTokens();
auto Tokens = TokBuf.expandedTokens();
auto It = llvm::lower_bound(
Tokens, EndLoc, [](const syntax::Token &Tok, SourceLocation EndLoc) {
return Tok.location() < EndLoc;
});
while (It != Tokens.end()) {
if (It->kind() != tok::semi) {
++It;
continue;
}
unsigned Offset =
AST->getSourceManager().getDecomposedLoc(It->endLocation()).second;
return InsertionPoint{Klass->getEnclosingNamespaceContext(), Offset};
}
return error(
"failed to determine insertion location: no end of class found");
}
private:
const FunctionDecl *Source = nullptr;
bool SameFile = false;
};
REGISTER_TWEAK(DefineOutline)
} // namespace
} // namespace clangd
} // namespace clang