CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
74 lines
1.8 KiB
ReStructuredText
74 lines
1.8 KiB
ReStructuredText
.. title:: clang-tidy - llvm-prefer-static-over-anonymous-namespace
|
|
|
|
llvm-prefer-static-over-anonymous-namespace
|
|
===========================================
|
|
|
|
Finds function and variable declarations inside anonymous namespace and
|
|
suggests replacing them with ``static`` declarations.
|
|
|
|
The `LLVM Coding Standards <https://llvm.org/docs/CodingStandards.html#restrict-visibility>`_
|
|
recommend keeping anonymous namespaces as small as possible and only use them
|
|
for class declarations. For functions and variables the ``static`` specifier
|
|
should be preferred for restricting visibility.
|
|
|
|
For example non-compliant code:
|
|
|
|
.. code-block:: c++
|
|
|
|
namespace {
|
|
|
|
class StringSort {
|
|
public:
|
|
StringSort(...)
|
|
bool operator<(const char *RHS) const;
|
|
};
|
|
|
|
// warning: place method definition outside of an anonymous namespace
|
|
bool StringSort::operator<(const char *RHS) const {}
|
|
|
|
// warning: prefer using 'static' for restricting visibility
|
|
void runHelper() {}
|
|
|
|
// warning: prefer using 'static' for restricting visibility
|
|
int myVariable = 42;
|
|
|
|
}
|
|
|
|
Should become:
|
|
|
|
.. code-block:: c++
|
|
|
|
// Small anonymous namespace for class declaration
|
|
namespace {
|
|
|
|
class StringSort {
|
|
public:
|
|
StringSort(...)
|
|
bool operator<(const char *RHS) const;
|
|
};
|
|
|
|
}
|
|
|
|
// placed method definition outside of the anonymous namespace
|
|
bool StringSort::operator<(const char *RHS) const {}
|
|
|
|
// used 'static' instead of an anonymous namespace
|
|
static void runHelper() {}
|
|
|
|
// used 'static' instead of an anonymous namespace
|
|
static int myVariable = 42;
|
|
|
|
|
|
Options
|
|
-------
|
|
|
|
.. option:: AllowVariableDeclarations
|
|
|
|
When `true`, allow variable declarations to be in anonymous namespace.
|
|
Default value is `true`.
|
|
|
|
.. option:: AllowMemberFunctionsInClass
|
|
|
|
When `true`, only methods defined in anonymous namespace outside of the
|
|
corresponding class will be warned. Default value is `true`.
|