CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
40 lines
1.2 KiB
ReStructuredText
40 lines
1.2 KiB
ReStructuredText
.. title:: clang-tidy - objc-nsinvocation-argument-lifetime
|
|
|
|
objc-nsinvocation-argument-lifetime
|
|
===================================
|
|
|
|
Finds calls to ``NSInvocation`` methods under ARC that don't have proper
|
|
argument object lifetimes. When passing Objective-C objects as parameters
|
|
to the ``NSInvocation`` methods ``getArgument:atIndex:`` and
|
|
``getReturnValue:``, the values are copied by value into the argument pointer,
|
|
which leads to incorrect releasing behavior if the object pointers are
|
|
not declared ``__unsafe_unretained``.
|
|
|
|
For code:
|
|
|
|
.. code-block:: objc
|
|
|
|
id arg;
|
|
[invocation getArgument:&arg atIndex:2];
|
|
|
|
__strong id returnValue;
|
|
[invocation getReturnValue:&returnValue];
|
|
|
|
The fix will be:
|
|
|
|
.. code-block:: objc
|
|
|
|
__unsafe_unretained id arg;
|
|
[invocation getArgument:&arg atIndex:2];
|
|
|
|
__unsafe_unretained id returnValue;
|
|
[invocation getReturnValue:&returnValue];
|
|
|
|
The check will warn on being passed instance variable references that have
|
|
lifetimes other than ``__unsafe_unretained``, but does not propose a fix:
|
|
|
|
.. code-block:: objc
|
|
|
|
// "id _returnValue" is declaration of instance variable of class.
|
|
[invocation getReturnValue:&self->_returnValue];
|