CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
105 lines
1.5 KiB
C++
105 lines
1.5 KiB
C++
// RUN: %check_clang_tidy %s bugprone-bool-pointer-implicit-conversion %t
|
|
|
|
bool *SomeFunction();
|
|
void SomeOtherFunction(bool*);
|
|
bool F();
|
|
void G(bool);
|
|
|
|
|
|
template <typename T>
|
|
void t(T b) {
|
|
if (b) {
|
|
}
|
|
}
|
|
|
|
void foo() {
|
|
bool *b = SomeFunction();
|
|
if (b) {
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: dubious check of 'bool *' against 'nullptr'
|
|
// CHECK-FIXES: if (*b) {
|
|
}
|
|
|
|
if (F() && b) {
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:14: warning: dubious check of 'bool *' against 'nullptr'
|
|
// CHECK-FIXES: if (F() && *b) {
|
|
}
|
|
|
|
// TODO: warn here.
|
|
if (b) {
|
|
G(b);
|
|
}
|
|
|
|
#define TESTMACRO if (b || F())
|
|
|
|
TESTMACRO {
|
|
}
|
|
|
|
t(b);
|
|
|
|
if (!b) {
|
|
// no-warning
|
|
}
|
|
|
|
if (SomeFunction()) {
|
|
// no-warning
|
|
}
|
|
|
|
bool *c = SomeFunction();
|
|
if (c) {
|
|
(void)c;
|
|
(void)*c; // no-warning
|
|
}
|
|
|
|
if (c) {
|
|
*c = true; // no-warning
|
|
}
|
|
|
|
if (c) {
|
|
c[0] = false; // no-warning
|
|
}
|
|
|
|
if (c) {
|
|
SomeOtherFunction(c); // no-warning
|
|
}
|
|
|
|
if (c) {
|
|
delete[] c; // no-warning
|
|
}
|
|
|
|
if (c) {
|
|
*(c) = false; // no-warning
|
|
}
|
|
|
|
struct {
|
|
bool *b;
|
|
} d = { SomeFunction() };
|
|
|
|
if (d.b) {
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: dubious check of 'bool *' against 'nullptr'
|
|
// CHECK-FIXES: if (*d.b) {
|
|
}
|
|
|
|
if (d.b) {
|
|
(void)*d.b; // no-warning
|
|
}
|
|
|
|
#define CHECK(b) \
|
|
if (b) { \
|
|
}
|
|
CHECK(c)
|
|
}
|
|
|
|
struct H {
|
|
bool *b;
|
|
void foo() const {
|
|
if (b) {
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: dubious check of 'bool *' against 'nullptr'
|
|
// CHECK-FIXES: if (*b) {
|
|
}
|
|
|
|
if (b) {
|
|
(void)*b; // no-warning
|
|
}
|
|
}
|
|
};
|