derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
41 lines
1.8 KiB
C++
41 lines
1.8 KiB
C++
// RUN: %check_clang_tidy -std=c++11-or-later %s bugprone-missing-end-comparison %t \
|
|
// RUN: -config="{CheckOptions: {bugprone-missing-end-comparison.ExtraAlgorithms: '::my_lib::find;::my_lib::find_range'}}"
|
|
|
|
#include <algorithm>
|
|
#include <vector>
|
|
|
|
namespace my_lib {
|
|
template<typename Iter, typename T>
|
|
Iter find(Iter first, Iter last, const T& value) {
|
|
return first;
|
|
}
|
|
|
|
template<typename Range, typename T>
|
|
auto find_range(Range&& range, const T& value)
|
|
-> decltype(range.begin()) {
|
|
return range.begin();
|
|
}
|
|
}
|
|
|
|
void test_custom_algorithms() {
|
|
std::vector<int> v;
|
|
if (my_lib::find(v.begin(), v.end(), 42)) {}
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: result of standard algorithm used as 'bool'; did you mean to compare with the end iterator? [bugprone-missing-end-comparison]
|
|
// CHECK-FIXES: if ((my_lib::find(v.begin(), v.end(), 42) != v.end())) {}
|
|
|
|
if (my_lib::find_range(v, 42)) {}
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: result of standard algorithm used as 'bool'; did you mean to compare with the end iterator? [bugprone-missing-end-comparison]
|
|
// CHECK-FIXES: if ((my_lib::find_range(v, 42) != std::end(v))) {}
|
|
}
|
|
|
|
void test_still_checks_standard() {
|
|
std::vector<int> v;
|
|
if (std::find(v.begin(), v.end(), 2)) {}
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: result of standard algorithm used as 'bool'; did you mean to compare with the end iterator? [bugprone-missing-end-comparison]
|
|
// CHECK-FIXES: if ((std::find(v.begin(), v.end(), 2) != v.end())) {}
|
|
|
|
if (std::min_element(v.begin(), v.end())) {}
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: result of standard algorithm used as 'bool'; did you mean to compare with the end iterator? [bugprone-missing-end-comparison]
|
|
// CHECK-FIXES: if ((std::min_element(v.begin(), v.end()) != v.end())) {}
|
|
}
|