CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
58 lines
1.8 KiB
C++
58 lines
1.8 KiB
C++
// RUN: %check_clang_tidy %s misc-uniqueptr-reset-release %t
|
|
|
|
// CHECK-FIXES: #include <utility>
|
|
|
|
#include <memory>
|
|
|
|
struct Foo {};
|
|
struct Bar : Foo {};
|
|
|
|
std::unique_ptr<Foo> Create();
|
|
std::unique_ptr<Foo> &Look();
|
|
std::unique_ptr<Foo> *Get();
|
|
|
|
using FooFunc = void (*)(Foo *);
|
|
using BarFunc = void (*)(Bar *);
|
|
|
|
void f() {
|
|
std::unique_ptr<Foo> a, b;
|
|
std::unique_ptr<Bar> c;
|
|
std::unique_ptr<Foo> *x = &a;
|
|
std::unique_ptr<Foo> *y = &b;
|
|
|
|
a.reset(b.release());
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: prefer 'unique_ptr<>' assignment over 'release' and 'reset' [misc-uniqueptr-reset-release]
|
|
// CHECK-FIXES: a = std::move(b);
|
|
a.reset(c.release());
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: prefer 'unique_ptr<>' assignment
|
|
// CHECK-FIXES: a = std::move(c);
|
|
a.reset(Create().release());
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: prefer 'unique_ptr<>' assignment
|
|
// CHECK-FIXES: a = Create();
|
|
x->reset(y->release());
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: prefer 'unique_ptr<>' assignment
|
|
// CHECK-FIXES: *x = std::move(*y);
|
|
Look().reset(Look().release());
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: prefer 'unique_ptr<>' assignment
|
|
// CHECK-FIXES: Look() = std::move(Look());
|
|
Get()->reset(Get()->release());
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: prefer 'unique_ptr<>' assignment
|
|
// CHECK-FIXES: *Get() = std::move(*Get());
|
|
|
|
std::unique_ptr<Bar, FooFunc> func_a, func_b;
|
|
func_a.reset(func_b.release());
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: prefer 'unique_ptr<>' assignment
|
|
// CHECK-FIXES: func_a = std::move(func_b);
|
|
}
|
|
|
|
void negatives() {
|
|
std::unique_ptr<Foo> src;
|
|
struct OtherDeleter {};
|
|
std::unique_ptr<Foo, OtherDeleter> dest;
|
|
dest.reset(src.release());
|
|
|
|
std::unique_ptr<Bar, FooFunc> func_a;
|
|
std::unique_ptr<Bar, BarFunc> func_b;
|
|
func_a.reset(func_b.release());
|
|
}
|