derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
186 lines
13 KiB
C++
186 lines
13 KiB
C++
// RUN: %check_clang_tidy -check-suffix=DONTCHECK \
|
|
// RUN: -std=c++17-or-later %s modernize-use-string-view %t -- \
|
|
// RUN: --config="{CheckOptions: {modernize-use-string-view.CheckOverloadedFunctions: false}}"
|
|
|
|
// RUN: %check_clang_tidy -check-suffix=CHECK \
|
|
// RUN: -std=c++17-or-later %s modernize-use-string-view %t -- \
|
|
// RUN: --config="{CheckOptions: {modernize-use-string-view.CheckOverloadedFunctions: true}}"
|
|
|
|
// RUN: %check_clang_tidy -check-suffix=CHECK-CXX20 \
|
|
// RUN: -std=c++20-or-later %s modernize-use-string-view %t -- \
|
|
// RUN: --config="{CheckOptions: {modernize-use-string-view.CheckOverloadedFunctions: true}}" \
|
|
// RUN: -- -DUSE_CXX20=1
|
|
|
|
#include <string>
|
|
#include <utility>
|
|
|
|
namespace overload_funcs_redeclared {
|
|
std::basic_string<char> overload(int);
|
|
std::string overload(int);
|
|
std::string overload(int) { return "int"; }
|
|
// CHECK-MESSAGES-DONTCHECK:[[@LINE-1]]:1: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-2]]:1: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-3]]:1: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-DONTCHECK: std::string_view overload(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK: std::string_view overload(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(int) { return "int"; }
|
|
}
|
|
|
|
namespace overload_non_func {
|
|
struct overload {};
|
|
std::string overload(int) { return "int"; }
|
|
// CHECK-MESSAGES-DONTCHECK:[[@LINE-1]]:1: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-2]]:1: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-3]]:1: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-DONTCHECK: std::string_view overload(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK: std::string_view overload(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(int) { return "int"; }
|
|
}
|
|
|
|
namespace overload_with_inline {
|
|
inline namespace inline_namespace {
|
|
std::string overload1(int) { return "int"; }
|
|
// CHECK-MESSAGES-DONTCHECK:[[@LINE-1]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-2]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-3]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-DONTCHECK: std::string_view overload1(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK: std::string_view overload1(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload1(int) { return "int"; }
|
|
}
|
|
inline namespace regular_namespace {
|
|
std::string overload1(int) { return "int"; }
|
|
// CHECK-MESSAGES-DONTCHECK:[[@LINE-1]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-2]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-3]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-DONTCHECK: std::string_view overload1(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK: std::string_view overload1(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload1(int) { return "int"; }
|
|
}
|
|
}
|
|
|
|
namespace overload_funcs {
|
|
std::string dbl2str(double f);
|
|
std::string overload(int) { return "int"; }
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-1]]:1: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-2]]:1: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK: std::string_view overload(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(int) { return "int"; }
|
|
std::string overload(double f) { return "f=" + dbl2str(f); }
|
|
std::string overload(std::string) { return "string"; }
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-1]]:1: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-2]]:1: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK: std::string_view overload(std::string) { return "string"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(std::string) { return "string"; }
|
|
}
|
|
|
|
namespace overload_methods {
|
|
struct Foo {
|
|
// Skip overloaded methods
|
|
std::string overload(int) { return "int"; }
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-1]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-2]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK: std::string_view overload(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(int) { return "int"; }
|
|
std::string overload(double f) { return "double"; }
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-1]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-2]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK: std::string_view overload(double f) { return "double"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(double f) { return "double"; }
|
|
std::string overload(std::string) { return "string"; }
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-1]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-2]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK: std::string_view overload(std::string) { return "string"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(std::string) { return "string"; }
|
|
};
|
|
}
|
|
|
|
namespace overload_methods_nested_classes {
|
|
struct Bar {
|
|
std::string overload(int) { return "int"; }
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-1]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-2]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK: std::string_view overload(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(int) { return "int"; }
|
|
std::string overload(std::string) { return "string"; }
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-1]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-2]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK: std::string_view overload(std::string) { return "string"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(std::string) { return "string"; }
|
|
struct FooBar {
|
|
std::string overload(char*) { return "char*"; }
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-1]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-2]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK: std::string_view overload(char*) { return "char*"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(char*) { return "char*"; }
|
|
std::string overload(double f) { return "double"; }
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-1]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-2]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK: std::string_view overload(double f) { return "double"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(double f) { return "double"; }
|
|
};
|
|
};
|
|
}
|
|
|
|
namespace two_overloads_with_inline {
|
|
inline namespace inline_namespace {
|
|
std::string overload(int) { return "int"; }
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-1]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-2]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK: std::string_view overload(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(int) { return "int"; }
|
|
std::string overload(double) { return "double"; }
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-1]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-2]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK: std::string_view overload(double) { return "double"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(double) { return "double"; }
|
|
}
|
|
std::string overload(int) { return "int"; }
|
|
// CHECK-MESSAGES-CHECK:[[@LINE-1]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-2]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK: std::string_view overload(int) { return "int"; }
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(int) { return "int"; }
|
|
}
|
|
|
|
#if USE_CXX20
|
|
|
|
namespace overload_with_outer {
|
|
namespace overload_with_templates {
|
|
template <typename T>
|
|
std::string overload(T) { return "T"; }
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-1]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
std::string overload(std::string) { return "string"; }
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-1]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(std::string) { return "string"; }
|
|
}
|
|
using overload_with_templates::overload;
|
|
std::string overload(char*) { return "char*"; }
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-1]]:1: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(char*) { return "char*"; }
|
|
}
|
|
|
|
namespace overload_methods_nested_namespaces {
|
|
namespace foo {
|
|
std::string overload(int) { return "int"; }
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-1]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(int) { return "int"; }
|
|
std::string overload(std::string) { return "string"; }
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-1]]:3: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(std::string) { return "string"; }
|
|
}
|
|
using foo::overload;
|
|
std::string overload(char*) { return "char*"; }
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-1]]:1: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(char*) { return "char*"; }
|
|
}
|
|
|
|
namespace overload_methods_templated {
|
|
template <typename T>
|
|
std::string overload(T value) { return "T";}
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-1]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(T value) { return "T";}
|
|
std::string overload(int value) { return "int"; }
|
|
// CHECK-MESSAGES-CHECK-CXX20:[[@LINE-1]]:5: warning: consider using 'std::string_view' to avoid unnecessary copying and allocations [modernize-use-string-view]
|
|
// CHECK-FIXES-CHECK-CXX20: std::string_view overload(int value) { return "int"; }
|
|
}
|
|
#endif
|