CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
133 lines
5.5 KiB
C++
133 lines
5.5 KiB
C++
// RUN: %check_clang_tidy -check-suffixes=,CLASSIC %s readability-container-data-pointer %t -- -- -fno-delayed-template-parsing
|
|
// RUN: %check_clang_tidy -check-suffixes=,WITH-CONFIG %s readability-container-data-pointer %t -- -config="{CheckOptions: {readability-container-data-pointer.IgnoredContainers: '::std::basic_string'}}" -- -fno-delayed-template-parsing
|
|
|
|
#include <string>
|
|
#include <type_traits>
|
|
#include <vector>
|
|
#include <memory>
|
|
|
|
template <typename T>
|
|
void f(const T *);
|
|
|
|
#define z (0)
|
|
|
|
void g(size_t s) {
|
|
std::vector<unsigned char> b(s);
|
|
f(&((b)[(z)]));
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
// CHECK-FIXES: f(b.data());
|
|
}
|
|
|
|
void h() {
|
|
std::string s;
|
|
f(&((s).operator[]((z))));
|
|
// CHECK-MESSAGES-CLASSIC: :[[@LINE-1]]:5: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
// CHECK-FIXES-CLASSIC: f(s.data());
|
|
// CHECK-MESSAGES-WITH-CONFIG-NOT: :[[@LINE-3]]:5: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
|
|
std::wstring w;
|
|
f(&((&(w))->operator[]((z))));
|
|
// CHECK-MESSAGES-CLASSIC: :[[@LINE-1]]:5: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
// CHECK-FIXES-CLASSIC: f(w.data());
|
|
// CHECK-MESSAGES-WITH-CONFIG-NOT: :[[@LINE-3]]:5: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
}
|
|
|
|
template <typename T, typename U,
|
|
typename = typename std::enable_if<std::is_integral<U>::value>::type>
|
|
void i(U s) {
|
|
std::vector<T> b(s);
|
|
f(&b[0]);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
// CHECK-FIXES: f(b.data());
|
|
}
|
|
|
|
template void i<unsigned char, size_t>(size_t);
|
|
|
|
void j(std::vector<unsigned char> * const v) {
|
|
f(&(*v)[0]);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
// CHECK-FIXES: f(v->data());
|
|
}
|
|
|
|
void k(const std::vector<unsigned char> &v) {
|
|
f(&v[0]);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
// CHECK-FIXES: f(v.data());
|
|
}
|
|
|
|
void l() {
|
|
unsigned char b[32];
|
|
f(&b[0]);
|
|
// CHECK-MESSAGES-NOT: :[[@LINE-1]]:5: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
}
|
|
|
|
template <typename T>
|
|
void m(const std::vector<T> &v) {
|
|
return &v[0];
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
// CHECK-FIXES: return v.data();
|
|
}
|
|
|
|
template <typename T>
|
|
struct container_without_data {
|
|
using size_type = size_t;
|
|
T &operator[](size_type);
|
|
const T &operator[](size_type) const;
|
|
};
|
|
|
|
template <typename T>
|
|
const T *n(const container_without_data<T> &c) {
|
|
// c has no "data" member function, so there should not be a warning here:
|
|
return &c[0];
|
|
}
|
|
|
|
const int *o(const std::vector<std::vector<std::vector<int>>> &v, const size_t idx1, const size_t idx2) {
|
|
return &v[idx1][idx2][0];
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
// CHECK-FIXES: return v[idx1][idx2].data();
|
|
}
|
|
|
|
std::vector<int> &select(std::vector<int> &u, std::vector<int> &v) {
|
|
return v;
|
|
}
|
|
|
|
int *p(std::vector<int> &v1, std::vector<int> &v2) {
|
|
return &select(*&v1, v2)[0];
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
// CHECK-FIXES: return select(*&v1, v2).data();
|
|
}
|
|
|
|
int *q(std::vector<int> ***v) {
|
|
return &(***v)[0];
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
// CHECK-FIXES: return (**v)->data();
|
|
}
|
|
|
|
struct VectorHolder {
|
|
std::vector<int> v;
|
|
};
|
|
|
|
int *r() {
|
|
VectorHolder holder;
|
|
return &holder.v[0];
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
// CHECK-FIXES: return holder.v.data();
|
|
}
|
|
|
|
void s(std::unique_ptr<std::vector<unsigned char>> p) {
|
|
f(&(*p)[0]);
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
|
|
// CHECK-FIXES: f((*p).data());
|
|
}
|
|
|
|
void t(std::unique_ptr<container_without_data<unsigned char>> p) {
|
|
// p has no "data" member function, so no warning
|
|
f(&(*p)[0]);
|
|
}
|
|
|
|
template <typename T>
|
|
void u(std::unique_ptr<T> p) {
|
|
// we don't know if 'T' will always have "data" member function, so no warning
|
|
f(&(*p)[0]);
|
|
}
|