CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
123 lines
4.4 KiB
C++
123 lines
4.4 KiB
C++
// RUN: %check_clang_tidy -std=c++17-or-later %s readability-inconsistent-ifelse-braces %t
|
|
|
|
constexpr bool cond(const char *) { return false; }
|
|
constexpr void do_something(const char *) {}
|
|
|
|
// Positive tests.
|
|
void f() {
|
|
if constexpr (cond("if0") /*comment*/) do_something("if-same-line");
|
|
else {
|
|
}
|
|
// CHECK-MESSAGES: :[[@LINE-3]]:41: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-FIXES: if constexpr (cond("if0") /*comment*/) { do_something("if-same-line");
|
|
// CHECK-FIXES: } else {
|
|
|
|
if constexpr (cond("if0.1") /*comment*/) {
|
|
} else do_something("else-same-line");
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-FIXES: } else { do_something("else-same-line");
|
|
// CHECK-FIXES: }
|
|
|
|
if constexpr (cond("if1"))
|
|
do_something("if-single-line");
|
|
else {
|
|
}
|
|
// CHECK-MESSAGES: :[[@LINE-4]]:29: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-FIXES: if constexpr (cond("if1")) {
|
|
// CHECK-FIXES: } else {
|
|
|
|
if constexpr (cond("if1.1")) {
|
|
} else
|
|
do_something("else-single-line");
|
|
// CHECK-MESSAGES: :[[@LINE-2]]:9: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-FIXES: } else {
|
|
// CHECK-FIXES: }
|
|
|
|
if constexpr (cond("if2") /*comment*/)
|
|
// some comment
|
|
do_something("if-multi-line");
|
|
else {
|
|
}
|
|
// CHECK-MESSAGES: :[[@LINE-5]]:41: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-FIXES: if constexpr (cond("if2") /*comment*/) {
|
|
// CHECK-FIXES: } else {
|
|
|
|
if constexpr (cond("if2.1") /*comment*/) {
|
|
} else
|
|
// some comment
|
|
do_something("else-multi-line");
|
|
// CHECK-MESSAGES: :[[@LINE-3]]:9: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-FIXES: } else {
|
|
// CHECK-FIXES: }
|
|
|
|
if constexpr (cond("if3")) do_something("elseif-same-line");
|
|
else if constexpr (cond("if3")) {
|
|
} else {
|
|
}
|
|
// CHECK-MESSAGES: :[[@LINE-4]]:29: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-FIXES: if constexpr (cond("if3")) { do_something("elseif-same-line");
|
|
// CHECK-FIXES: } else if constexpr (cond("if3")) {
|
|
|
|
if constexpr (cond("if3.1")) {
|
|
} else if constexpr (cond("if3.1")) do_something("elseif-same-line");
|
|
else {
|
|
}
|
|
// CHECK-MESSAGES: :[[@LINE-3]]:38: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-FIXES: } else if constexpr (cond("if3.1")) { do_something("elseif-same-line");
|
|
// CHECK-FIXES: } else {
|
|
|
|
if constexpr (cond("if3.2")) {
|
|
} else if constexpr (cond("if3.2")) {
|
|
} else do_something("else-same-line");
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-FIXES: } else { do_something("else-same-line");
|
|
// CHECK-FIXES: }
|
|
|
|
if constexpr (cond("if4-outer"))
|
|
if constexpr (cond("if4-inner"))
|
|
do_something("if-single-line");
|
|
else {
|
|
}
|
|
else {
|
|
}
|
|
// CHECK-MESSAGES: :[[@LINE-7]]:35: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-MESSAGES: :[[@LINE-7]]:37: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-FIXES: if constexpr (cond("if4-outer")) {
|
|
// CHECK-FIXES: if constexpr (cond("if4-inner")) {
|
|
// CHECK-FIXES: } else {
|
|
// CHECK-FIXES: } else {
|
|
|
|
if constexpr (cond("if5"))
|
|
do_something("if-single-line");
|
|
else if constexpr (cond("if5")) {
|
|
}
|
|
// CHECK-MESSAGES: :[[@LINE-4]]:29: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-FIXES: if constexpr (cond("if5")) {
|
|
// CHECK-FIXES: } else if constexpr (cond("if5")) {
|
|
|
|
if constexpr (cond("if5.1")) {
|
|
} else if constexpr (cond("if5.1"))
|
|
do_something("elseif-single-line");
|
|
// CHECK-MESSAGES: :[[@LINE-2]]:38: warning: statement should have braces [readability-inconsistent-ifelse-braces]
|
|
// CHECK-FIXES: } else if constexpr (cond("if5.1")) {
|
|
// CHECK-FIXES: }
|
|
}
|
|
|
|
// Negative tests.
|
|
void g() {
|
|
if constexpr (cond("if0")) {
|
|
do_something("if-single-line");
|
|
} else if constexpr (cond("if0")) {
|
|
do_something("elseif-single-line");
|
|
} else {
|
|
do_something("else-single-line");
|
|
}
|
|
|
|
if constexpr (cond("if1"))
|
|
do_something("if-single-line");
|
|
else if constexpr (cond("if1"))
|
|
do_something("elseif-single-line");
|
|
else
|
|
do_something("else-single-line");
|
|
}
|