CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
48 lines
1.3 KiB
C++
48 lines
1.3 KiB
C++
// RUN: %check_clang_tidy %s readability-redundant-string-cstr %t
|
|
|
|
namespace std {
|
|
template <typename T>
|
|
class allocator {};
|
|
template <typename T>
|
|
class char_traits {};
|
|
template <typename C, typename T, typename A>
|
|
struct basic_string {
|
|
basic_string();
|
|
// MSVC headers define two constructors instead of using optional arguments.
|
|
basic_string(const C *p);
|
|
basic_string(const C *p, const A &a);
|
|
const C *c_str() const;
|
|
const C *data() const;
|
|
};
|
|
typedef basic_string<char, std::char_traits<char>, std::allocator<char>> string;
|
|
}
|
|
namespace llvm {
|
|
struct StringRef {
|
|
StringRef(const char *p);
|
|
StringRef(const std::string &);
|
|
};
|
|
}
|
|
|
|
void f1(const std::string &s) {
|
|
f1(s.c_str());
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
|
|
// CHECK-FIXES: f1(s);
|
|
f1(s.data());
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: redundant call to 'data' [readability-redundant-string-cstr]
|
|
// CHECK-FIXES: f1(s);
|
|
}
|
|
void f2(const llvm::StringRef r) {
|
|
std::string s;
|
|
f2(s.c_str());
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: redundant call {{.*}}
|
|
// CHECK-FIXES: std::string s;
|
|
// CHECK-FIXES-NEXT: f2(s);
|
|
}
|
|
void f3(const llvm::StringRef &r) {
|
|
std::string s;
|
|
f3(s.c_str());
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: redundant call {{.*}}
|
|
// CHECK-FIXES: std::string s;
|
|
// CHECK-FIXES-NEXT: f3(s);
|
|
}
|