CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
242 lines
5.2 KiB
C++
242 lines
5.2 KiB
C++
// RUN: %check_clang_tidy -std=c++14,c++17 %s readability-use-anyofallof %t -- -- -fexceptions
|
|
// FIXME: Fix the checker to work in C++20 mode.
|
|
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
bool good_any_of() {
|
|
int v[] = {1, 2, 3};
|
|
// CHECK-MESSAGES: :[[@LINE+1]]:3: warning: replace loop by 'std::any_of()' [readability-use-anyofallof]
|
|
for (int i : v)
|
|
if (i)
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
bool cond(int i);
|
|
|
|
bool good_any_of2() {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v) {
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: replace loop by 'std::any_of()'
|
|
int k = i / 2;
|
|
if (cond(k))
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool good_any_of3() {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v) {
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: replace loop by 'std::any_of()'
|
|
if (i == 3)
|
|
continue;
|
|
if (i)
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool good_any_of_use_external(int comp) {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v) {
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: replace loop by 'std::any_of()'
|
|
if (i == comp)
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool good_any_of_no_cond() {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v) {
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: replace loop by 'std::any_of()'
|
|
return true; // Not a real loop, but technically can become any_of.
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool good_any_of_local_modification() {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v) {
|
|
int j = i;
|
|
j++; // FIXME: Any non-const use disables check.
|
|
if (j > 3)
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool good_any_of_throw() {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v) {
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: replace loop by 'std::any_of()'
|
|
if (i > 3)
|
|
return true;
|
|
if (i == 42)
|
|
throw 0;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool bad_any_of1() {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v) {
|
|
if (i)
|
|
return false; // bad constant
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool bad_any_of2() {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v)
|
|
if (i)
|
|
return true;
|
|
|
|
return true; // bad return
|
|
}
|
|
|
|
bool bad_any_of3() {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v)
|
|
if (i)
|
|
return true;
|
|
else
|
|
return i / 2; // bad return
|
|
|
|
return false;
|
|
}
|
|
|
|
bool bad_any_of_control_flow1() {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v) {
|
|
break; // bad control flow
|
|
if (i)
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool bad_any_of_control_flow2() {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v) {
|
|
goto end; // bad control flow
|
|
if (i)
|
|
return true;
|
|
}
|
|
|
|
end:
|
|
return false;
|
|
}
|
|
|
|
bool bad_any_of4() {
|
|
return false; // wrong order
|
|
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v) {
|
|
if (i)
|
|
return true;
|
|
}
|
|
}
|
|
|
|
bool bad_any_of5() {
|
|
int v[] = {1, 2, 3};
|
|
int j = 0;
|
|
for (int i : v) {
|
|
j++; // modifications
|
|
if (i)
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool bad_any_of6() {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v) {
|
|
if (i)
|
|
return true;
|
|
}
|
|
int j = 0; // Statements between loop and return
|
|
j++;
|
|
return false;
|
|
}
|
|
|
|
bool bad_any_of7() {
|
|
int v[] = {1, 2, 3};
|
|
for (int i : v) {
|
|
i; // No 'return true' in body.
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool good_all_of() {
|
|
int v[] = {1, 2, 3};
|
|
// CHECK-MESSAGES: :[[@LINE+1]]:3: warning: replace loop by 'std::all_of()' [readability-use-anyofallof]
|
|
for (int i : v)
|
|
if (i)
|
|
return false;
|
|
return true;
|
|
}
|
|
|
|
std::vector<int> get_dummy_vec();
|
|
|
|
bool good_any_of_temporary_vector() {
|
|
// CHECK-MESSAGES: :[[@LINE+2]]:3: warning: replace loop by 'std::any_of()'
|
|
// CHECK-MESSAGES: :[[@LINE+1]]:16: note: reusing the temporary range directly in the replacement may be unsafe; consider materializing it in a local variable first
|
|
for (int i : get_dummy_vec())
|
|
if (i)
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
bool all_of_temporary_vector() {
|
|
// CHECK-MESSAGES: :[[@LINE+2]]:3: warning: replace loop by 'std::all_of()'
|
|
// CHECK-MESSAGES: :[[@LINE+1]]:16: note: reusing the temporary range directly in the replacement may be unsafe; consider materializing it in a local variable first
|
|
for (int i : get_dummy_vec())
|
|
if (i)
|
|
return false;
|
|
return true;
|
|
}
|
|
|
|
bool any_of_initializer_list(int a, int b, int c) {
|
|
// CHECK-MESSAGES: :[[@LINE+2]]:3: warning: replace loop by 'std::any_of()'
|
|
// CHECK-MESSAGES: :[[@LINE+1]]:23: note: reusing the temporary range directly in the replacement may be unsafe; consider materializing it in a local variable first
|
|
for (const auto i : {a, b, c})
|
|
if (i == 0)
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
bool all_of_initializer_list(int a, int b, int c) {
|
|
// CHECK-MESSAGES: :[[@LINE+2]]:3: warning: replace loop by 'std::all_of()'
|
|
// CHECK-MESSAGES: :[[@LINE+1]]:23: note: reusing the temporary range directly in the replacement may be unsafe; consider materializing it in a local variable first
|
|
for (const auto i : {a, b, c})
|
|
if (i == 0)
|
|
return false;
|
|
return true;
|
|
}
|
|
|
|
bool good_xvalue(std::vector<int>& v) {
|
|
// CHECK-MESSAGES: :[[@LINE+1]]:3: warning: replace loop by 'std::any_of()' [readability-use-anyofallof]
|
|
for (int i : std::move(v))
|
|
if (i)
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
bool good_xvalue_all_of(std::vector<int>& v) {
|
|
// CHECK-MESSAGES: :[[@LINE+1]]:3: warning: replace loop by 'std::all_of()' [readability-use-anyofallof]
|
|
for (int i : std::move(v))
|
|
if (i)
|
|
return false;
|
|
return true;
|
|
}
|