CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
131 lines
4.5 KiB
C++
131 lines
4.5 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
|
|
#include "CheckerRegistration.h"
|
|
#include "clang/Basic/LLVM.h"
|
|
#include "clang/Frontend/CompilerInstance.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/CommonBugCategories.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h"
|
|
#include "clang/StaticAnalyzer/Frontend/AnalysisConsumer.h"
|
|
#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h"
|
|
#include "clang/Tooling/Tooling.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
namespace clang {
|
|
namespace ento {
|
|
namespace {
|
|
|
|
void reportBug(const CheckerBase *Checker, const CallEvent &Call,
|
|
CheckerContext &C, StringRef WarningMsg) {
|
|
C.getBugReporter().EmitBasicReport(
|
|
nullptr, Checker, "", categories::LogicError, WarningMsg,
|
|
PathDiagnosticLocation(Call.getOriginExpr(), C.getSourceManager(),
|
|
C.getStackFrame()),
|
|
{});
|
|
}
|
|
|
|
class CXXDeallocatorChecker : public Checker<check::PreCall> {
|
|
public:
|
|
void checkPreCall(const CallEvent &Call, CheckerContext &C) const {
|
|
const auto *DC = dyn_cast<CXXDeallocatorCall>(&Call);
|
|
if (!DC) {
|
|
return;
|
|
}
|
|
|
|
SmallString<100> WarningBuf;
|
|
llvm::raw_svector_ostream WarningOS(WarningBuf);
|
|
WarningOS << "NumArgs: " << DC->getNumArgs();
|
|
|
|
reportBug(this, *DC, C, WarningBuf);
|
|
}
|
|
};
|
|
|
|
void addCXXDeallocatorChecker(AnalysisASTConsumer &AnalysisConsumer,
|
|
AnalyzerOptions &AnOpts) {
|
|
AnOpts.CheckersAndPackages = {{"test.CXXDeallocator", true}};
|
|
AnalysisConsumer.AddCheckerRegistrationFn([](CheckerRegistry &Registry) {
|
|
Registry.addChecker<CXXDeallocatorChecker>("test.CXXDeallocator",
|
|
"MockDescription");
|
|
});
|
|
}
|
|
|
|
// TODO: What we should really be testing here is all the different varieties
|
|
// of delete operators, and whether the retrieval of their arguments works as
|
|
// intended. At the time of writing this file, CXXDeallocatorCall doesn't pick
|
|
// up on much of those due to the AST not containing CXXDeleteExpr for most of
|
|
// the standard/custom deletes.
|
|
TEST(CXXDeallocatorCall, SimpleDestructor) {
|
|
std::string Diags;
|
|
EXPECT_TRUE(runCheckerOnCode<addCXXDeallocatorChecker>(R"(
|
|
struct A {};
|
|
|
|
void f() {
|
|
A *a = new A;
|
|
delete a;
|
|
}
|
|
)",
|
|
Diags));
|
|
#if defined(_AIX) || defined(__MVS__) || defined(__MINGW32__)
|
|
// AIX, ZOS and MinGW default to -fno-sized-deallocation.
|
|
EXPECT_EQ(Diags, "test.CXXDeallocator: NumArgs: 1\n");
|
|
#else
|
|
EXPECT_EQ(Diags, "test.CXXDeallocator: NumArgs: 2\n");
|
|
#endif
|
|
}
|
|
|
|
TEST(PrivateMethodCache, NeverReturnDanglingPointersWithMultipleASTs) {
|
|
// Each iteration will load and unload an AST multiple times. Since the code
|
|
// is always the same, we increase the chance of hitting a bug in the private
|
|
// method cache, returning a dangling pointer and crashing the process. If the
|
|
// cache is properly cleared between runs, the test should pass.
|
|
for (int I = 0; I < 100; ++I) {
|
|
auto const *Code = R"(
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
|
|
extern void *malloc(size_t size);
|
|
extern void *memcpy(void *dest, const void *src, size_t n);
|
|
|
|
@interface SomeMoreData {
|
|
char const* _buffer;
|
|
int _size;
|
|
}
|
|
@property(nonatomic, readonly) const char* buffer;
|
|
@property(nonatomic) int size;
|
|
|
|
- (void)appendData:(SomeMoreData*)other;
|
|
|
|
@end
|
|
|
|
@implementation SomeMoreData
|
|
@synthesize size = _size;
|
|
@synthesize buffer = _buffer;
|
|
|
|
- (void)appendData:(SomeMoreData*)other {
|
|
int const len = (_size + other.size); // implicit self._length
|
|
char* d = malloc(sizeof(char) * len);
|
|
memcpy(d + 20, other.buffer, len);
|
|
}
|
|
|
|
@end
|
|
)";
|
|
std::string Diags;
|
|
EXPECT_TRUE(runCheckerOnCodeWithArgs<addCXXDeallocatorChecker>(
|
|
Code, {"-x", "objective-c", "-Wno-objc-root-class"}, Diags));
|
|
}
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace ento
|
|
} // namespace clang
|