derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
46 lines
2.0 KiB
Plaintext
46 lines
2.0 KiB
Plaintext
Date: Sat, 19 May 2001 19:09:13 -0500 (CDT)
|
|
From: Chris Lattner <sabre@nondot.org>
|
|
To: Vikram S. Adve <vadve@cs.uiuc.edu>
|
|
Subject: RE: Meeting writeup
|
|
|
|
> I read it through and it looks great!
|
|
|
|
Thanks!
|
|
|
|
> The finally clause in Java may need more thought. The code for this clause
|
|
> is like a subroutine because it needs to be entered from many points (end of
|
|
> try block and beginning of each catch block), and then needs to *return to
|
|
> the place from where the code was entered*. That's why JVM has the
|
|
> jsr/jsr_w instruction.
|
|
|
|
Hrm... I guess that is an implementation decision. It can either be
|
|
modelled as a subroutine (as java bytecodes do), which is really
|
|
gross... or it can be modelled as code duplication (emitted once inline,
|
|
then once in the exception path). Because this could, at worst,
|
|
slightly less than double the amount of code in a function (it is
|
|
bounded) I don't think this is a big deal. One of the really nice things
|
|
about the LLVM representation is that it still allows for runtime code
|
|
generation for exception paths (exceptions paths are not compiled until
|
|
needed). Obviously a static compiler couldn't do this though. :)
|
|
|
|
In this case, only one copy of the code would be compiled... until the
|
|
other one is needed on demand. Also this strategy fits with the "zero
|
|
cost" exception model... the standard case is not burdened with extra
|
|
branches or "call"s.
|
|
|
|
> I suppose you could save the return address in a particular register
|
|
> (specific to this finally block), jump to the finally block, and then at the
|
|
> end of the finally block, jump back indirectly through this register. It
|
|
> will complicate building the CFG but I suppose that can be handled. It is
|
|
> also unsafe in terms of checking where control returns (which is I suppose
|
|
> why the JVM doesn't use this).
|
|
|
|
I think that a code duplication method would be cleaner, and would avoid
|
|
the caveats that you mention. Also, it does not slow down the normal case
|
|
with an indirect branch...
|
|
|
|
Like everything, we can probably defer a final decision until later. :)
|
|
|
|
-Chris
|
|
|