derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
1.9 KiB
1.9 KiB
name, description
| name | description |
|---|---|
| verification-before-completion | Verification checklist before marking work complete. Use when: finishing a fix, completing a review finding, validating a build, confirming a refactor. |
Verification Before Completion
Ensures fixes and changes are actually validated before declaring success. Prevents "it compiles so it works" thinking.
Core Principle
Never mark work done based on absence of errors. Verify the positive — confirm the expected behavior exists.
Verification Checklist
Before marking any task complete, verify:
1. Build Verification
- Code compiles without new warnings
- All existing tests still pass
- Package builds successfully (if applicable)
2. Behavioral Verification
- The fix actually addresses the reported problem (not just a related symptom)
- Expected output is produced (not just "no error")
- Edge cases considered: empty input, null handles, max values, concurrent access
3. Regression Check
- No existing functionality broken by the change
- API contract preserved (same inputs → compatible outputs)
- No new warnings from static analysis or formatters
4. Integration Verification
- Changes work across all affected layers (C → Python → CLI if applicable)
- Both system-installed and pip-installed paths work (for Python changes)
- Both RPM and DEB packaging still work (for build changes)
Anti-Patterns
| Anti-Pattern | Reality |
|---|---|
| "It compiles" | Compilation proves syntax, not correctness |
| "Tests pass" | Tests may not cover the changed path |
| "No errors in output" | Silent failures are the worst failures |
| "Works on my machine" | Check both install contexts |
| "The diff looks right" | Run the code, don't just read it |
When to Use
- After fixing a review finding
- After completing a build/install cycle
- After refactoring code
- Before marking a subagent task as done