CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
82 lines
3.1 KiB
C++
82 lines
3.1 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ProBoundsArrayToPointerDecayCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/AST/ParentMapContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "clang/ASTMatchers/ASTMatchers.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::cppcoreguidelines {
|
|
|
|
namespace {
|
|
AST_MATCHER_P(CXXForRangeStmt, hasRangeBeginEndStmt,
|
|
ast_matchers::internal::Matcher<DeclStmt>, InnerMatcher) {
|
|
return llvm::any_of(llvm::ArrayRef{Node.getBeginStmt(), Node.getEndStmt()},
|
|
[&](const DeclStmt *Stmt) {
|
|
return Stmt &&
|
|
InnerMatcher.matches(*Stmt, Finder, Builder);
|
|
});
|
|
}
|
|
|
|
AST_MATCHER(Stmt, isInsideOfRangeBeginEndStmt) {
|
|
return stmt(hasAncestor(cxxForRangeStmt(
|
|
hasRangeBeginEndStmt(hasDescendant(equalsNode(&Node))))))
|
|
.matches(Node, Finder, Builder);
|
|
}
|
|
|
|
AST_MATCHER_P(Expr, hasParentIgnoringImpCasts,
|
|
ast_matchers::internal::Matcher<Expr>, InnerMatcher) {
|
|
const Expr *E = &Node;
|
|
do {
|
|
const DynTypedNodeList Parents = Finder->getASTContext().getParents(*E);
|
|
if (Parents.size() != 1)
|
|
return false;
|
|
E = Parents[0].get<Expr>();
|
|
if (!E)
|
|
return false;
|
|
} while (isa<ImplicitCastExpr>(E));
|
|
|
|
return InnerMatcher.matches(*E, Finder, Builder);
|
|
}
|
|
} // namespace
|
|
|
|
void ProBoundsArrayToPointerDecayCheck::registerMatchers(MatchFinder *Finder) {
|
|
// The only allowed array to pointer decay
|
|
// 1) just before array subscription
|
|
// 2) inside a range-for over an array
|
|
// 3) if it converts a string literal to a pointer
|
|
Finder->addMatcher(
|
|
traverse(
|
|
TK_AsIs,
|
|
implicitCastExpr(
|
|
hasCastKind(CK_ArrayToPointerDecay),
|
|
unless(hasParent(arraySubscriptExpr())),
|
|
unless(hasSourceExpression(predefinedExpr())),
|
|
unless(hasParentIgnoringImpCasts(explicitCastExpr())),
|
|
unless(isInsideOfRangeBeginEndStmt()),
|
|
unless(hasSourceExpression(ignoringParens(stringLiteral()))),
|
|
unless(hasSourceExpression(ignoringParens(
|
|
conditionalOperator(hasTrueExpression(stringLiteral()),
|
|
hasFalseExpression(stringLiteral()))))))
|
|
.bind("cast")),
|
|
this);
|
|
}
|
|
|
|
void ProBoundsArrayToPointerDecayCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
const auto *MatchedCast = Result.Nodes.getNodeAs<ImplicitCastExpr>("cast");
|
|
diag(MatchedCast->getExprLoc(), "do not implicitly decay an array into a "
|
|
"pointer; consider using gsl::array_view or "
|
|
"an explicit cast instead");
|
|
}
|
|
|
|
} // namespace clang::tidy::cppcoreguidelines
|