derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
65 lines
3.4 KiB
C++
65 lines
3.4 KiB
C++
// RUN: %check_clang_tidy %s abseil-duration-subtraction %t -- -- -I %S/Inputs
|
|
|
|
#include "absl/time/time.h"
|
|
|
|
void f() {
|
|
double x;
|
|
absl::Duration d, d1, d2;
|
|
|
|
x = absl::ToDoubleSeconds(d) - 1.0;
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtraction in the duration domain [abseil-duration-subtraction]
|
|
// CHECK-FIXES: x = absl::ToDoubleSeconds(d - absl::Seconds(1));
|
|
x = absl::ToDoubleSeconds(d) - absl::ToDoubleSeconds(d1);
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtraction in the duration domain [abseil-duration-subtraction]
|
|
// CHECK-FIXES: x = absl::ToDoubleSeconds(d - d1);
|
|
x = absl::ToDoubleSeconds(d) - 6.5 - 8.0;
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtraction in the duration domain [abseil-duration-subtraction]
|
|
// CHECK-FIXES: x = absl::ToDoubleSeconds(d - absl::Seconds(6.5)) - 8.0;
|
|
x = absl::ToDoubleHours(d) - 1.0;
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtraction in the duration domain [abseil-duration-subtraction]
|
|
// CHECK-FIXES: x = absl::ToDoubleHours(d - absl::Hours(1));
|
|
x = absl::ToDoubleMinutes(d) - 1;
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtraction in the duration domain [abseil-duration-subtraction]
|
|
// CHECK-FIXES: x = absl::ToDoubleMinutes(d - absl::Minutes(1));
|
|
x = absl::ToDoubleMilliseconds(d) - 9;
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtraction in the duration domain [abseil-duration-subtraction]
|
|
// CHECK-FIXES: x = absl::ToDoubleMilliseconds(d - absl::Milliseconds(9));
|
|
x = absl::ToDoubleMicroseconds(d) - 9;
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtraction in the duration domain [abseil-duration-subtraction]
|
|
// CHECK-FIXES: x = absl::ToDoubleMicroseconds(d - absl::Microseconds(9));
|
|
x = absl::ToDoubleNanoseconds(d) - 42;
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtraction in the duration domain [abseil-duration-subtraction]
|
|
// CHECK-FIXES: x = absl::ToDoubleNanoseconds(d - absl::Nanoseconds(42));
|
|
|
|
// We can rewrite the argument of the duration conversion
|
|
#define THIRTY absl::Seconds(30)
|
|
x = absl::ToDoubleSeconds(THIRTY) - 1.0;
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtraction in the duration domain [abseil-duration-subtraction]
|
|
// CHECK-FIXES: x = absl::ToDoubleSeconds(THIRTY - absl::Seconds(1));
|
|
#undef THIRTY
|
|
|
|
// Some other contexts
|
|
if (absl::ToDoubleSeconds(d) - 1.0 > 10) {}
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtraction in the duration domain [abseil-duration-subtraction]
|
|
// CHECK-FIXES: if (absl::ToDoubleSeconds(d - absl::Seconds(1)) > 10) {}
|
|
|
|
// A nested occurrence
|
|
x = absl::ToDoubleSeconds(d) - absl::ToDoubleSeconds(absl::Seconds(5));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtraction in the duration domain [abseil-duration-subtraction]
|
|
// CHECK-FIXES: x = absl::ToDoubleSeconds(d - absl::Seconds(5));
|
|
x = absl::ToDoubleSeconds(d) - absl::ToDoubleSeconds(absl::Seconds(absl::ToDoubleSeconds(d1)));
|
|
// CHECK-MESSAGES: [[@LINE-1]]:7: warning: perform subtraction in the duration domain [abseil-duration-subtraction]
|
|
// CHECK-FIXES: x = absl::ToDoubleSeconds(d - absl::Seconds(absl::ToDoubleSeconds(d1)));
|
|
|
|
// These should not match
|
|
x = 5 - 6;
|
|
x = 4 - absl::ToDoubleSeconds(d) - 6.5 - 8.0;
|
|
x = absl::ToDoubleSeconds(d) + 1.0;
|
|
x = absl::ToDoubleSeconds(d) * 1.0;
|
|
x = absl::ToDoubleSeconds(d) / 1.0;
|
|
|
|
#define MINUS_FIVE(z) absl::ToDoubleSeconds(z) - 5
|
|
x = MINUS_FIVE(d);
|
|
#undef MINUS_FIVE
|
|
}
|