CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
142 lines
4.1 KiB
C++
142 lines
4.1 KiB
C++
// RUN: %check_clang_tidy %s bugprone-pointer-arithmetic-on-polymorphic-object %t -- \
|
|
// RUN: -config="{CheckOptions: \
|
|
// RUN: {bugprone-pointer-arithmetic-on-polymorphic-object.IgnoreInheritedVirtualFunctions: true}}"
|
|
|
|
class Base {
|
|
public:
|
|
virtual ~Base() {}
|
|
};
|
|
|
|
class Derived : public Base {};
|
|
|
|
class FinalDerived final : public Base {};
|
|
|
|
class AbstractBase {
|
|
public:
|
|
virtual void f() = 0;
|
|
virtual ~AbstractBase() {}
|
|
};
|
|
|
|
class AbstractInherited : public AbstractBase {};
|
|
|
|
class AbstractOverride : public AbstractInherited {
|
|
public:
|
|
void f() override {}
|
|
};
|
|
|
|
void operators() {
|
|
Base *b = new Derived[10];
|
|
|
|
b += 1;
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: pointer arithmetic on polymorphic object of type 'Base' can result in undefined behavior if the dynamic type differs from the pointer type [bugprone-pointer-arithmetic-on-polymorphic-object]
|
|
|
|
b = b + 1;
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: pointer arithmetic on polymorphic object of type 'Base' can result in undefined behavior if the dynamic type differs from the pointer type [bugprone-pointer-arithmetic-on-polymorphic-object]
|
|
|
|
b++;
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: pointer arithmetic on polymorphic object of type 'Base' can result in undefined behavior if the dynamic type differs from the pointer type [bugprone-pointer-arithmetic-on-polymorphic-object]
|
|
|
|
--b;
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: pointer arithmetic on polymorphic object of type 'Base' can result in undefined behavior if the dynamic type differs from the pointer type [bugprone-pointer-arithmetic-on-polymorphic-object]
|
|
|
|
b[1];
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: pointer arithmetic on polymorphic object of type 'Base' can result in undefined behavior if the dynamic type differs from the pointer type [bugprone-pointer-arithmetic-on-polymorphic-object]
|
|
|
|
delete[] static_cast<Derived*>(b);
|
|
}
|
|
|
|
void subclassWarnings() {
|
|
Base *b = new Base[10];
|
|
|
|
// False positive that's impossible to distinguish without
|
|
// path-sensitive analysis, but the code is bug-prone regardless.
|
|
b += 1;
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: pointer arithmetic on polymorphic object of type 'Base'
|
|
|
|
delete[] b;
|
|
|
|
// Common false positive is a class that overrides all parent functions.
|
|
Derived *d = new Derived[10];
|
|
|
|
d += 1;
|
|
// no-warning
|
|
|
|
delete[] d;
|
|
|
|
// Final classes cannot have a dynamic type.
|
|
FinalDerived *fd = new FinalDerived[10];
|
|
|
|
fd += 1;
|
|
// no-warning
|
|
|
|
delete[] fd;
|
|
}
|
|
|
|
void abstractWarnings() {
|
|
// Classes with an abstract member funtion are always matched.
|
|
AbstractBase *ab = new AbstractOverride[10];
|
|
|
|
ab += 1;
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: pointer arithmetic on polymorphic object of type 'AbstractBase'
|
|
|
|
delete[] static_cast<AbstractOverride*>(ab);
|
|
|
|
AbstractInherited *ai = new AbstractOverride[10];
|
|
|
|
ai += 1;
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: pointer arithmetic on polymorphic object of type 'AbstractInherited'
|
|
|
|
delete[] static_cast<AbstractOverride*>(ai);
|
|
|
|
// If all abstract member functions are overridden, the class is not matched.
|
|
AbstractOverride *ao = new AbstractOverride[10];
|
|
|
|
ao += 1;
|
|
// no-warning
|
|
|
|
delete[] ao;
|
|
}
|
|
|
|
template <typename T>
|
|
void templateWarning(T *t) {
|
|
// FIXME: Tidy doesn't support template instantiation locations properly.
|
|
t += 1;
|
|
// no-warning
|
|
}
|
|
|
|
void functionArgument(Base *b) {
|
|
b += 1;
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: pointer arithmetic on polymorphic object of type 'Base'
|
|
|
|
templateWarning(b);
|
|
}
|
|
|
|
using BaseAlias = Base;
|
|
using DerivedAlias = Derived;
|
|
using FinalDerivedAlias = FinalDerived;
|
|
|
|
using BasePtr = Base*;
|
|
using DerivedPtr = Derived*;
|
|
using FinalDerivedPtr = FinalDerived*;
|
|
|
|
void typeAliases(BaseAlias *b, DerivedAlias *d, FinalDerivedAlias *fd,
|
|
BasePtr bp, DerivedPtr dp, FinalDerivedPtr fdp) {
|
|
b += 1;
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: pointer arithmetic on polymorphic object of type 'Base'
|
|
|
|
d += 1;
|
|
// no-warning
|
|
|
|
fd += 1;
|
|
// no-warning
|
|
|
|
bp += 1;
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: pointer arithmetic on polymorphic object of type 'Base'
|
|
|
|
dp += 1;
|
|
// no-warning
|
|
|
|
fdp += 1;
|
|
// no-warning
|
|
}
|