Files
TheRock/rocm-libraries/shared/rocroller/lib/source/ExpressionTransformations/LaunchTimeSubExpressions.cpp
T
derek.holloway 7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
Flatten subprojects into a single base monorepo
2026-09-02 16:34:47 -07:00

311 lines
11 KiB
C++

// Copyright Advanced Micro Devices, Inc., or its affiliates.
// SPDX-License-Identifier: MIT
#include <rocRoller/ExpressionTransformations.hpp>
#include <rocRoller/AssemblyKernel.hpp>
#include <rocRoller/Expression.hpp>
#include <rocRoller/KernelOptions_detail.hpp>
template <typename T>
constexpr auto cast_to_unsigned(T val)
{
return static_cast<typename std::make_unsigned<T>::type>(val);
}
namespace rocRoller
{
namespace Expression
{
/**
* Launch-time subexpressions
*
* Attempt to replace complex operations found within an expression with
* pre-calculated kernel arguments.
*
* Challenge: By the time we see most expressions, most launch-time known
* values have already been converted to kernel arguments and are seen as
* KernelExecute time. For now this is solved by applying this optimization
* as soon as the expression is made. We could in theory work backward from
* the kernel argument to the command argument.
* TODO: Apply this to every expression by working backward from the kernel argument.
*
*/
struct LaunchTimeExpressionVisitor
{
LaunchTimeExpressionVisitor(ContextPtr ctx, bool allowNewArgs)
: m_context(ctx)
, m_allowNewArgs(allowNewArgs)
, m_minComplexity(ctx->kernelOptions()->minLaunchTimeExpressionComplexity)
{
}
/**
* Return an argument for `expr`, if one exists.
*/
ExpressionPtr existingLaunchEval(ExpressionPtr expr)
{
return m_context->kernel()->findArgumentForExpression(expr);
}
ExpressionPtr addLaunchEval(ExpressionPtr expr)
{
auto kernel = m_context->kernel();
auto varType = resultVariableType(expr);
auto argName = kernel->uniqueArgName(argumentName(expr));
Log::debug("LTSE: Adding arg {} complexity {}, varType {}, expr {}",
argName,
complexity(expr),
toString(varType),
toString(expr));
return kernel->addArgument({argName, varType, DataDirection::ReadOnly, expr});
}
ExpressionPtr maybeLaunchEval(ExpressionPtr expr, bool ignoreComplexity)
{
auto evalTimes = evaluationTimes(expr);
if(evalTimes[EvaluationTime::Translate] || !evalTimes[EvaluationTime::KernelLaunch])
{
return nullptr;
}
{
auto arg = existingLaunchEval(expr);
if(arg)
return arg;
}
if(!m_allowNewArgs)
return nullptr;
bool isMagicOperation = std::holds_alternative<MagicMultiple>(*expr)
|| std::holds_alternative<MagicShifts>(*expr)
|| std::holds_alternative<MagicShiftAndSign>(*expr);
if(ignoreComplexity || isMagicOperation || complexity(expr) >= m_minComplexity)
return addLaunchEval(expr);
return nullptr;
}
template <CExpression T>
ExpressionPtr maybeLaunchEval(T const& expr, bool ignoreComplexity = false)
{
return maybeLaunchEval(std::make_shared<Expression>(expr), ignoreComplexity);
}
ExpressionPtr operator()(ScaledMatrixMultiply const& expr)
{
{
auto launchResult = maybeLaunchEval(expr);
if(launchResult)
return launchResult;
}
{
ScaledMatrixMultiply cpy = expr;
cpy.matA = call(expr.matA);
cpy.matB = call(expr.matB);
cpy.matC = call(expr.matC);
cpy.scaleA = call(expr.scaleA);
cpy.scaleB = call(expr.scaleB);
return std::make_shared<Expression>(cpy);
}
}
template <CTernary Expr>
ExpressionPtr operator()(Expr const& expr)
{
{
auto launchResult = maybeLaunchEval(expr);
if(launchResult)
return launchResult;
}
{
Expr cpy = expr;
cpy.lhs = call(expr.lhs);
cpy.r1hs = call(expr.r1hs);
cpy.r2hs = call(expr.r2hs);
return std::make_shared<Expression>(cpy);
}
}
template <CBinary Expr>
ExpressionPtr operator()(Expr const& expr)
{
{
auto launchResult = maybeLaunchEval(expr);
if(launchResult)
return launchResult;
}
{
Expr cpy = expr;
cpy.lhs = call(expr.lhs);
cpy.rhs = call(expr.rhs);
return std::make_shared<Expression>(cpy);
}
}
template <CUnary Expr>
ExpressionPtr operator()(Expr const& expr)
{
{
auto launchResult = maybeLaunchEval(expr);
if(launchResult)
return launchResult;
}
{
Expr cpy = expr;
cpy.arg = call(expr.arg);
return std::make_shared<Expression>(cpy);
}
}
template <CNary Expr>
ExpressionPtr operator()(Expr const& expr)
{
{
auto launchResult = maybeLaunchEval(expr);
if(launchResult)
return launchResult;
}
{
auto cpy = expr;
std::ranges::for_each(cpy.operands, [this](auto& op) { op = call(op); });
return std::make_shared<Expression>(std::move(cpy));
}
}
ExpressionPtr operator()(CommandArgumentPtr const& expr)
{
// For a Value, if we still have a CommandArgument, we need to
// convert it to a KernelArgument, regardless of complexity.
auto launchResult = maybeLaunchEval(expr, true);
if(launchResult)
return launchResult;
return std::make_shared<Expression>(expr);
}
template <CValue Value>
ExpressionPtr operator()(Value const& expr)
{
return std::make_shared<Expression>(expr);
}
ExpressionPtr call(ExpressionPtr expr)
{
if(!expr)
return expr;
return std::visit(*this, *expr);
}
private:
ContextPtr m_context;
int m_minComplexity;
bool m_allowNewArgs;
};
ExpressionPtr launchTimeSubExpressions(ExpressionPtr expr, ContextPtr ctx)
{
auto startStr = toString(expr);
if(ctx->kernel()->startedCodeGeneration())
{
auto visitor = LaunchTimeExpressionVisitor(ctx, false);
// Since code gen has started, we can't add any new kernel arguments. So our
// goal is to find the largest subexpressions that exist as kernel arguments.
// The following might exist:
// kernArg0: comArg0
// kernArg1: comArg0 / comArg1
// kernArg2: kernArg0 / kernArg1
// If our expression is:
// initial: ((kernArg0 / comArg1) + (comArg0 / kernArg1))
// restore: ((comArg0 / comArg1) + (comArg0 / (comArg0 / comArg1))
// pass 1: (kernArg1 + (kernArg0 / kernArg1))
// pass 2: (kernArg1 + kernArg2)
// Maybe this can be done more efficiently?
auto v0 = restoreCommandArguments(expr);
auto v1 = visitor.call(v0);
auto v2 = visitor.call(v1);
Log::trace("launchTimeSubExpressions: {} -> {} -> {} -> {}",
toString(expr),
toString(v0),
toString(v1),
toString(v2));
AssertFatal(resultVariableType(expr) == resultVariableType(v2),
ShowValue(expr),
ShowValue(v0),
ShowValue(v1),
ShowValue(v2));
return v2;
}
else
{
auto v0 = restoreCommandArguments(expr);
// Challenge: Find subexpressions that are *actually* nontrivial to calculate.
// Example:
// kernArg0: comArg0 * comArg1 + comArg0 / comArg2
// If our expression is:
// 4 + comArg0 * comArg1 + comArg0 / comArg2
// Then the initial pass could gauge the complexity of the whole expression
// including the part that is already a kernel argument, and it will add a new
// argument for this whole expression.
// If we first substitute existing args without adding any new ones:
// 4 + kernArg0
// Then the complexity will be low and we won't add a new arg just to save this
// single addition.
// This should restore any existing subexpressions that are more complex than
// just a single value.
auto visitor1 = LaunchTimeExpressionVisitor(ctx, false);
auto v1 = visitor1.call(v0);
// That allows this call to have an accurate picture of complexity.
auto visitor2 = LaunchTimeExpressionVisitor(ctx, true);
auto v2 = visitor2.call(v1);
Log::trace("launchTimeSubExpressions: {} -> {} -> {} -> {}",
toString(expr),
toString(v0),
toString(v1),
toString(v2));
AssertFatal(resultVariableType(expr) == resultVariableType(v2),
ShowValue(expr),
ShowValue(v2));
return v2;
}
}
}
}