Files
TheRock/rocm-libraries/shared/rocroller/test/unit/KernelGraphTest/Simplify.cpp
T
derek.holloway 7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
Flatten subprojects into a single base monorepo
2026-09-02 16:34:47 -07:00

212 lines
7.2 KiB
C++

// Copyright Advanced Micro Devices, Inc., or its affiliates.
// SPDX-License-Identifier: MIT
#include <rocRoller/Graph/GraphUtilities.hpp>
#include <rocRoller/KernelGraph/KernelGraph.hpp>
#include <rocRoller/KernelGraph/Transforms/Simplify.hpp>
#include <rocRoller/KernelGraph/Utils.hpp>
#include "../GenericContextFixture.hpp"
using namespace rocRoller;
using namespace rocRoller::KernelGraph::ControlGraph;
namespace KernelGraphTest
{
class KernelGraphSimplifyTest : public GenericContextFixture
{
};
TEST_F(KernelGraphSimplifyTest, RemoveRedundantEdges)
{
auto graph0 = KernelGraph::KernelGraph();
auto A = graph0.control.addElement(NOP());
auto B = graph0.control.addElement(NOP());
auto C = graph0.control.addElement(NOP());
auto b0 = graph0.control.addElement(Body(), {A}, {B});
auto b1 = graph0.control.addElement(Body(), {B}, {C});
auto b2 = graph0.control.addElement(Body(), {A}, {C});
auto s0 = graph0.control.addElement(Sequence(), {A}, {C});
EXPECT_EQ(graph0.control.getEdges().to<std::vector>().size(), 4);
auto isBody = graph0.control.isElemType<Body>();
Graph::removeRedundantEdges(graph0.control, isBody);
EXPECT_EQ(graph0.control.getEdges().to<std::vector>().size(), 3);
EXPECT_ANY_THROW(graph0.control.getEdge(b2));
}
TEST_F(KernelGraphSimplifyTest, RemoveRedundantEdgesFullyDescribed)
{
auto graph0 = KernelGraph::KernelGraph();
auto A = graph0.control.addElement(NOP());
auto B = graph0.control.addElement(NOP());
auto C = graph0.control.addElement(NOP());
auto D = graph0.control.addElement(NOP());
auto E = graph0.control.addElement(NOP());
// Input: Graph with the following sequence but with every possible edge
// A -> C -> D
// B / \ E
// i.e. A->D, A->E, B->D, B->E
std::vector<int> keep;
std::vector<int> toss;
keep.push_back(graph0.control.addElement(Sequence(), {A}, {C}));
toss.push_back(graph0.control.addElement(Sequence(), {A}, {D}));
toss.push_back(graph0.control.addElement(Sequence(), {A}, {E}));
keep.push_back(graph0.control.addElement(Sequence(), {B}, {C}));
toss.push_back(graph0.control.addElement(Sequence(), {B}, {D}));
toss.push_back(graph0.control.addElement(Sequence(), {B}, {E}));
keep.push_back(graph0.control.addElement(Sequence(), {C}, {D}));
keep.push_back(graph0.control.addElement(Sequence(), {C}, {E}));
// Add a node that shouldn't be considered at all.
keep.push_back(graph0.control.addElement(Body(), {A}, {C}));
for(auto idx : keep)
EXPECT_NO_THROW(graph0.control.getEdge(idx)) << idx;
for(auto idx : toss)
EXPECT_NO_THROW(graph0.control.getEdge(idx)) << idx;
auto isSequence = graph0.control.isElemType<Sequence>();
EXPECT_EQ(Graph::findRedundantEdges(graph0.control, isSequence).to<std::vector>(), toss);
Graph::removeRedundantEdges(graph0.control, isSequence);
for(auto idx : keep)
EXPECT_NO_THROW(graph0.control.getEdge(idx)) << idx;
for(auto idx : toss)
EXPECT_ANY_THROW(graph0.control.getEdge(idx)) << idx;
}
TEST_F(KernelGraphSimplifyTest, BasicRedundantSequence)
{
auto graph0 = KernelGraph::KernelGraph();
auto A = graph0.control.addElement(NOP());
auto B = graph0.control.addElement(NOP());
auto C = graph0.control.addElement(NOP());
auto s0 = graph0.control.addElement(Sequence(), {A}, {B});
auto s1 = graph0.control.addElement(Sequence(), {B}, {C});
auto s2 = graph0.control.addElement(Sequence(), {A}, {C});
auto graph1 = KernelGraph::Simplify().apply(graph0);
EXPECT_EQ(graph0.control.getEdges().to<std::vector>().size(), 3);
EXPECT_EQ(graph1.control.getEdges().to<std::vector>().size(), 2);
EXPECT_ANY_THROW(graph1.control.getEdge(s2));
}
TEST_F(KernelGraphSimplifyTest, BasicRedundantBody)
{
auto graph0 = KernelGraph::KernelGraph();
auto A = graph0.control.addElement(NOP());
auto B = graph0.control.addElement(NOP());
auto C = graph0.control.addElement(NOP());
auto b0 = graph0.control.addElement(Body(), {A}, {B});
auto s0 = graph0.control.addElement(Sequence(), {B}, {C});
auto b1 = graph0.control.addElement(Body(), {A}, {C});
auto graph1 = KernelGraph::Simplify().apply(graph0);
EXPECT_EQ(graph0.control.getEdges().to<std::vector>().size(), 3);
EXPECT_EQ(graph1.control.getEdges().to<std::vector>().size(), 2);
EXPECT_ANY_THROW(graph1.control.getEdge(b1));
}
TEST_F(KernelGraphSimplifyTest, DoubleRedundantBody)
{
auto graph0 = KernelGraph::KernelGraph();
auto A = graph0.control.addElement(NOP());
auto B = graph0.control.addElement(NOP());
auto C = graph0.control.addElement(NOP());
auto b0 = graph0.control.addElement(Body(), {A}, {B});
auto b1 = graph0.control.addElement(Body(), {A}, {B});
auto s0 = graph0.control.addElement(Sequence(), {B}, {C});
auto b2 = graph0.control.addElement(Body(), {A}, {C});
auto graph1 = KernelGraph::Simplify().apply(graph0);
EXPECT_EQ(graph0.control.getEdges().to<std::vector>().size(), 4);
EXPECT_EQ(graph1.control.getEdges().to<std::vector>().size(), 2);
// Either b0 or b1 could be removed.
EXPECT_ANY_THROW({
graph1.control.getEdge(b0);
graph1.control.getEdge(b1);
});
EXPECT_ANY_THROW(graph1.control.getEdge(b2));
}
TEST_F(KernelGraphSimplifyTest, MultipleRedundantBody)
{
//
// graph0's control graph is like this:
//
// A
// | (body)
// ------------------------------
// | | | |
// | | | | ...
// v v v v
// NOP ---> NOP ---> NOP ---> NOP
// (seq) (seq) (seq)
//
auto graph0 = KernelGraph::KernelGraph();
auto A = graph0.control.addElement(NOP());
std::vector<int> bodyNodes;
std::vector<int> bodyEdges;
for(int i = 0; i < 10; i++)
{
auto nop = graph0.control.addElement(NOP());
bodyEdges.push_back(graph0.control.addElement(Body(), {A}, {nop}));
bodyNodes.push_back(nop);
}
//
// Chain the Body nodes with Sequence edges
//
for(int i = 1; i < bodyNodes.size(); i++)
graph0.control.addElement(Sequence(), {bodyNodes[i - 1]}, {bodyNodes[i]});
auto graph1 = KernelGraph::Simplify().apply(graph0);
//
// Use the result of baseline method as verification
//
rocRoller::KernelGraph::removeRedundantBodyEdgesBaselineMethod(graph0);
EXPECT_EQ(graph0.control.getEdges().to<std::vector>(),
graph1.control.getEdges().to<std::vector>());
//
// Verify only the first Body edge remains
//
for(int i = 1; i < bodyEdges.size(); i++)
EXPECT_ANY_THROW(graph1.control.getEdge(bodyEdges[i]));
}
}