CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
60 lines
1.3 KiB
ReStructuredText
60 lines
1.3 KiB
ReStructuredText
.. title:: clang-tidy - performance-inefficient-string-concatenation
|
|
|
|
performance-inefficient-string-concatenation
|
|
============================================
|
|
|
|
This check warns about the performance overhead arising from concatenating
|
|
strings using the ``operator+``, for instance:
|
|
|
|
.. code-block:: c++
|
|
|
|
std::string a("Foo"), b("Bar");
|
|
a = a + b;
|
|
|
|
Instead of this structure you should use ``operator+=`` or ``std::string``'s
|
|
(``std::basic_string``) class member function ``append()``. For instance:
|
|
|
|
.. code-block:: c++
|
|
|
|
std::string a("Foo"), b("Baz");
|
|
for (int i = 0; i < 20000; ++i) {
|
|
a = a + "Bar" + b;
|
|
}
|
|
|
|
Could be rewritten in a greatly more efficient way like:
|
|
|
|
.. code-block:: c++
|
|
|
|
std::string a("Foo"), b("Baz");
|
|
for (int i = 0; i < 20000; ++i) {
|
|
a.append("Bar").append(b);
|
|
}
|
|
|
|
And this can be rewritten too:
|
|
|
|
.. code-block:: c++
|
|
|
|
void f(const std::string&) {}
|
|
std::string a("Foo"), b("Baz");
|
|
void g() {
|
|
f(a + "Bar" + b);
|
|
}
|
|
|
|
In a slightly more efficient way like:
|
|
|
|
.. code-block:: c++
|
|
|
|
void f(const std::string&) {}
|
|
std::string a("Foo"), b("Baz");
|
|
void g() {
|
|
f(std::string(a).append("Bar").append(b));
|
|
}
|
|
|
|
Options
|
|
-------
|
|
|
|
.. option:: StrictMode
|
|
|
|
When `false`, the check will only warn on inefficient string usage inside loops.
|
|
Default is `false`.
|