Files
derek.holloway 7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
Flatten subprojects into a single base monorepo
2026-09-02 16:34:47 -07:00

712 lines
28 KiB
C++

/* ************************************************************************
* Copyright (C) 2020-2025 Advanced Micro Devices, Inc. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell cop-
* ies of the Software, and to permit persons to whom the Software is furnished
* to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IM-
* PLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNE-
* CTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*
*
* ************************************************************************ */
#pragma once
#include "clientcommon.hpp"
template <testAPI_t API, typename T, typename U, typename V>
void sytrf_checkBadArgs(const hipsolverHandle_t handle,
const hipsolverFillMode_t uplo,
const int n,
T dA,
const int lda,
const int stA,
U dIpiv,
const int stP,
V dWork,
const int lwork,
U dinfo,
const int bc)
{
// handle
EXPECT_ROCBLAS_STATUS(
hipsolver_sytrf(API, nullptr, uplo, n, dA, lda, stA, dIpiv, stP, dWork, lwork, dinfo, bc),
HIPSOLVER_STATUS_NOT_INITIALIZED);
// values
EXPECT_ROCBLAS_STATUS(hipsolver_sytrf(API,
handle,
hipsolverFillMode_t(-1),
n,
dA,
lda,
stA,
dIpiv,
stP,
dWork,
lwork,
dinfo,
bc),
HIPSOLVER_STATUS_INVALID_ENUM);
#if defined(__HIP_PLATFORM_HCC__) || defined(__HIP_PLATFORM_AMD__)
// pointers
EXPECT_ROCBLAS_STATUS(
hipsolver_sytrf(
API, handle, uplo, n, (T) nullptr, lda, stA, dIpiv, stP, dWork, lwork, dinfo, bc),
HIPSOLVER_STATUS_INVALID_VALUE);
EXPECT_ROCBLAS_STATUS(
hipsolver_sytrf(
API, handle, uplo, n, dA, lda, stA, (U) nullptr, stP, dWork, lwork, dinfo, bc),
HIPSOLVER_STATUS_INVALID_VALUE);
EXPECT_ROCBLAS_STATUS(
hipsolver_sytrf(
API, handle, uplo, n, dA, lda, stA, dIpiv, stP, dWork, lwork, (U) nullptr, bc),
HIPSOLVER_STATUS_INVALID_VALUE);
#endif
}
template <testAPI_t API, bool BATCHED, bool STRIDED, typename T>
void testing_sytrf_bad_arg()
{
// safe arguments
hipsolver_local_handle handle;
hipsolverFillMode_t uplo = HIPSOLVER_FILL_MODE_UPPER;
int n = 1;
int lda = 1;
int stA = 1;
int stP = 1;
int bc = 1;
if(BATCHED)
{
// // memory allocations
// device_batch_vector<T> dA(1, 1, 1);
// device_strided_batch_vector<int> dIpiv(1, 1, 1, 1);
// device_strided_batch_vector<int> dInfo(1, 1, 1, 1);
// CHECK_HIP_ERROR(dA.memcheck());
// CHECK_HIP_ERROR(dIpiv.memcheck());
// CHECK_HIP_ERROR(dInfo.memcheck());
// int size_W;
// hipsolver_sytrf_bufferSize(API, handle, n, dA.data(), lda, &size_W);
// size_t bytes_W = std::getenv("HIPSOLVER_BUFFERSIZE_RETURN_BYTES") != nullptr ? size_W : sizeof(T) * size_W;
// device_strided_batch_vector<T> dWork(bytes_W, 1, bytes_W, 1);
// if(size_W)
// CHECK_HIP_ERROR(dWork.memcheck());
// // check bad arguments
// sytrf_checkBadArgs<API>(handle,
// uplo,
// n,
// dA.data(),
// lda,
// stA,
// dIpiv.data(),
// stP,
// dWork.data(),
// size_W,
// dInfo.data(),
// bc);
}
else
{
// memory allocations
device_strided_batch_vector<T> dA(1, 1, 1, 1);
device_strided_batch_vector<int> dIpiv(1, 1, 1, 1);
device_strided_batch_vector<int> dInfo(1, 1, 1, 1);
CHECK_HIP_ERROR(dA.memcheck());
CHECK_HIP_ERROR(dIpiv.memcheck());
CHECK_HIP_ERROR(dInfo.memcheck());
int size_W;
hipsolver_sytrf_bufferSize(API, handle, n, dA.data(), lda, &size_W);
size_t bytes_W = std::getenv("HIPSOLVER_BUFFERSIZE_RETURN_BYTES") != nullptr
? size_W
: sizeof(T) * size_W;
device_strided_batch_vector<T> dWork(bytes_W, 1, bytes_W, 1);
if(size_W)
CHECK_HIP_ERROR(dWork.memcheck());
// check bad arguments
sytrf_checkBadArgs<API>(handle,
uplo,
n,
dA.data(),
lda,
stA,
dIpiv.data(),
stP,
dWork.data(),
size_W,
dInfo.data(),
bc);
}
}
template <bool CPU, bool GPU, typename T, typename Td, typename Ud, typename Th, typename Uh>
void sytrf_initData(const hipsolverHandle_t handle,
const hipsolverFillMode_t uplo,
const int n,
Td& dA,
const int lda,
const int stA,
Ud& dIpiv,
const int stP,
Ud& dInfo,
const int bc,
Th& hA,
Uh& hIpiv,
Uh& hInfo)
{
if(CPU)
{
T tmp;
rocblas_init<T>(hA, true);
for(int b = 0; b < bc; ++b)
{
// scale A to avoid singularities
for(int i = 0; i < n; i++)
{
for(int j = 0; j < n; j++)
{
if(i == j)
hA[b][i + j * lda] += 400;
else
hA[b][i + j * lda] -= 4;
}
}
// shuffle rows to test pivoting
// always the same permutation for debugging purposes
for(int i = 0; i < n / 2; i++)
{
for(int j = 0; j < n; j++)
{
tmp = hA[b][i + j * lda];
hA[b][i + j * lda] = hA[b][n - 1 - i + j * lda];
hA[b][n - 1 - i + j * lda] = tmp;
}
}
}
}
if(GPU)
{
// now copy data to the GPU
CHECK_HIP_ERROR(dA.transfer_from(hA));
}
}
template <testAPI_t API,
typename T,
typename Td,
typename Ud,
typename Vd,
typename Th,
typename Uh>
void sytrf_getError(const hipsolverHandle_t handle,
const hipsolverFillMode_t uplo,
const int n,
Td& dA,
const int lda,
const int stA,
Ud& dIpiv,
const int stP,
Vd& dWork,
const int lwork,
Ud& dInfo,
const int bc,
Th& hA,
Th& hARes,
Uh& hIpiv,
Uh& hIpivRes,
Uh& hInfo,
Uh& hInfoRes,
double* max_err)
{
int size_W = 64 * n;
std::vector<T> hW(size_W);
// input data initialization
sytrf_initData<true, true, T>(
handle, uplo, n, dA, lda, stA, dIpiv, stP, dInfo, bc, hA, hIpiv, hInfo);
// execute computations
// GPU lapack
CHECK_ROCBLAS_ERROR(hipsolver_sytrf(API,
handle,
uplo,
n,
dA.data(),
lda,
stA,
dIpiv.data(),
stP,
dWork.data(),
lwork,
dInfo.data(),
bc));
CHECK_HIP_ERROR(hARes.transfer_from(dA));
CHECK_HIP_ERROR(hIpivRes.transfer_from(dIpiv));
CHECK_HIP_ERROR(hInfoRes.transfer_from(dInfo));
// CPU lapack
for(int b = 0; b < bc; ++b)
cpu_sytrf(uplo, n, hA[b], lda, hIpiv[b], hW.data(), size_W, hInfo[b]);
// error is ||hA - hARes|| / ||hA||
// (THIS DOES NOT ACCOUNT FOR NUMERICAL REPRODUCIBILITY ISSUES.
// IT MIGHT BE REVISITED IN THE FUTURE)
// using frobenius norm
double err;
*max_err = 0;
for(int b = 0; b < bc; ++b)
{
err = norm_error('F', n, n, lda, hA[b], hARes[b]);
*max_err = err > *max_err ? err : *max_err;
// also check pivoting (count the number of incorrect pivots)
err = 0;
for(int i = 0; i < n; ++i)
{
EXPECT_EQ(hIpiv[b][i], hIpivRes[b][i]) << "where b = " << b << ", i = " << i;
if(hIpiv[b][i] != hIpivRes[b][i])
err++;
}
*max_err = err > *max_err ? err : *max_err;
}
// also check info
err = 0;
for(int b = 0; b < bc; ++b)
{
EXPECT_EQ(hInfo[b][0], hInfoRes[b][0]) << "where b = " << b;
if(hInfo[b][0] != hInfoRes[b][0])
err++;
}
*max_err += err;
}
template <testAPI_t API,
typename T,
typename Td,
typename Ud,
typename Vd,
typename Th,
typename Uh>
void sytrf_getPerfData(const hipsolverHandle_t handle,
const hipsolverFillMode_t uplo,
const int n,
Td& dA,
const int lda,
const int stA,
Ud& dIpiv,
const int stP,
Vd& dWork,
const int lwork,
Ud& dInfo,
const int bc,
Th& hA,
Uh& hIpiv,
Uh& hInfo,
double* gpu_time_used,
double* cpu_time_used,
const int hot_calls,
const bool perf)
{
int size_W = 64 * n;
std::vector<T> hW(size_W);
if(!perf)
{
sytrf_initData<true, false, T>(
handle, uplo, n, dA, lda, stA, dIpiv, stP, dInfo, bc, hA, hIpiv, hInfo);
// cpu-lapack performance (only if not in perf mode)
*cpu_time_used = get_time_us_no_sync();
for(int b = 0; b < bc; ++b)
cpu_sytrf(uplo, n, hA[b], lda, hIpiv[b], hW.data(), size_W, hInfo[b]);
*cpu_time_used = get_time_us_no_sync() - *cpu_time_used;
}
sytrf_initData<true, false, T>(
handle, uplo, n, dA, lda, stA, dIpiv, stP, dInfo, bc, hA, hIpiv, hInfo);
// cold calls
for(int iter = 0; iter < 2; iter++)
{
sytrf_initData<false, true, T>(
handle, uplo, n, dA, lda, stA, dIpiv, stP, dInfo, bc, hA, hIpiv, hInfo);
CHECK_ROCBLAS_ERROR(hipsolver_sytrf(API,
handle,
uplo,
n,
dA.data(),
lda,
stA,
dIpiv.data(),
stP,
dWork.data(),
lwork,
dInfo.data(),
bc));
}
// gpu-lapack performance
hipStream_t stream;
CHECK_ROCBLAS_ERROR(hipsolverGetStream(handle, &stream));
double start;
for(int iter = 0; iter < hot_calls; iter++)
{
sytrf_initData<false, true, T>(
handle, uplo, n, dA, lda, stA, dIpiv, stP, dInfo, bc, hA, hIpiv, hInfo);
start = get_time_us_sync(stream);
hipsolver_sytrf(API,
handle,
uplo,
n,
dA.data(),
lda,
stA,
dIpiv.data(),
stP,
dWork.data(),
lwork,
dInfo.data(),
bc);
*gpu_time_used += get_time_us_sync(stream) - start;
}
*gpu_time_used /= hot_calls;
}
template <testAPI_t API, bool BATCHED, bool STRIDED, typename T>
void testing_sytrf(Arguments& argus)
{
// get arguments
hipsolver_local_handle handle;
char uploC = argus.get<char>("uplo");
int n = argus.get<int>("n");
int lda = argus.get<int>("lda", n);
int stA = argus.get<int>("strideA", lda * n);
int stP = argus.get<int>("strideP", n);
hipsolverFillMode_t uplo = char2hipsolver_fill(uploC);
int bc = argus.batch_count;
int hot_calls = argus.iters;
int stARes = (argus.unit_check || argus.norm_check) ? stA : 0;
int stPRes = (argus.unit_check || argus.norm_check) ? stP : 0;
// check non-supported values
if(uplo != HIPSOLVER_FILL_MODE_UPPER && uplo != HIPSOLVER_FILL_MODE_LOWER)
{
if(BATCHED)
{
// EXPECT_ROCBLAS_STATUS(hipsolver_sytrf(API,
// handle,
// uplo,
// n,
// (T* const*)nullptr,
// lda,
// stA,
// (int*)nullptr,
// stP,
// (T*)nullptr,
// 0,
// (int*)nullptr,
// bc),
// HIPSOLVER_STATUS_INVALID_VALUE);
}
else
{
EXPECT_ROCBLAS_STATUS(hipsolver_sytrf(API,
handle,
uplo,
n,
(T*)nullptr,
lda,
stA,
(int*)nullptr,
stP,
(T*)nullptr,
0,
(int*)nullptr,
bc),
HIPSOLVER_STATUS_INVALID_VALUE);
}
if(argus.timing)
rocsolver_bench_inform(inform_invalid_args);
return;
}
// determine sizes
size_t size_A = size_t(lda) * n;
size_t size_P = size_t(n);
double max_error = 0, gpu_time_used = 0, cpu_time_used = 0;
size_t size_ARes = (argus.unit_check || argus.norm_check) ? size_A : 0;
size_t size_PRes = (argus.unit_check || argus.norm_check) ? size_P : 0;
// check invalid sizes
bool invalid_size = (n < 0 || lda < n || bc < 0);
if(invalid_size)
{
if(BATCHED)
{
// EXPECT_ROCBLAS_STATUS(hipsolver_sytrf(API,
// handle,
// uplo,
// n,
// (T* const*)nullptr,
// lda,
// stA,
// (int*)nullptr,
// stP,
// (T*)nullptr,
// 0,
// (int*)nullptr,
// bc),
// HIPSOLVER_STATUS_INVALID_VALUE);
}
else
{
EXPECT_ROCBLAS_STATUS(hipsolver_sytrf(API,
handle,
uplo,
n,
(T*)nullptr,
lda,
stA,
(int*)nullptr,
stP,
(T*)nullptr,
0,
(int*)nullptr,
bc),
HIPSOLVER_STATUS_INVALID_VALUE);
}
if(argus.timing)
rocsolver_bench_inform(inform_invalid_size);
return;
}
// memory size query is necessary
int size_W;
hipsolver_sytrf_bufferSize(API, handle, n, (T*)nullptr, lda, &size_W);
size_t bytes_W
= std::getenv("HIPSOLVER_BUFFERSIZE_RETURN_BYTES") != nullptr ? size_W : sizeof(T) * size_W;
if(argus.mem_query)
{
rocsolver_bench_inform(inform_mem_query, bytes_W);
return;
}
if(BATCHED)
{
// // memory allocations
// host_batch_vector<T> hA(size_A, 1, bc);
// host_batch_vector<T> hARes(size_ARes, 1, bc);
// host_strided_batch_vector<int> hIpiv(size_P, 1, stP, bc);
// host_strided_batch_vector<int> hIpivRes(size_PRes, 1, stPRes, bc);
// host_strided_batch_vector<int> hInfo(1, 1, 1, bc);
// host_strided_batch_vector<int> hInfoRes(1, 1, 1, bc);
// device_batch_vector<T> dA(size_A, 1, bc);
// device_strided_batch_vector<int> dIpiv(size_P, 1, stP, bc);
// device_strided_batch_vector<int> dInfo(1, 1, 1, bc);
// device_strided_batch_vector<T> dWork(bytes_W, 1, bytes_W, 1); // bytes_W accounts for bc
// if(size_A)
// CHECK_HIP_ERROR(dA.memcheck());
// CHECK_HIP_ERROR(dInfo.memcheck());
// if(size_P)
// CHECK_HIP_ERROR(dIpiv.memcheck());
// if(size_W)
// CHECK_HIP_ERROR(dWork.memcheck());
// // check computations
// if(argus.unit_check || argus.norm_check)
// sytrf_getError<API, T>(handle,
// uplo,
// n,
// dA,
// lda,
// stA,
// dIpiv,
// stP,
// dWork,
// size_W,
// dInfo,
// bc,
// hA,
// hARes,
// hIpiv,
// hIpivRes,
// hInfo,
// hInfoRes,
// &max_error);
// // collect performance data
// if(argus.timing)
// sytrf_getPerfData<API, T>(handle,
// uplo,
// n,
// dA,
// lda,
// stA,
// dIpiv,
// stP,
// dWork,
// size_W,
// dInfo,
// bc,
// hA,
// hIpiv,
// hInfo,
// &gpu_time_used,
// &cpu_time_used,
// hot_calls,
// argus.perf);
}
else
{
// memory allocations
host_strided_batch_vector<T> hA(size_A, 1, stA, bc);
host_strided_batch_vector<T> hARes(size_ARes, 1, stARes, bc);
host_strided_batch_vector<int> hIpiv(size_P, 1, stP, bc);
host_strided_batch_vector<int> hIpivRes(size_PRes, 1, stPRes, bc);
host_strided_batch_vector<int> hInfo(1, 1, 1, bc);
host_strided_batch_vector<int> hInfoRes(1, 1, 1, bc);
device_strided_batch_vector<T> dA(size_A, 1, stA, bc);
device_strided_batch_vector<int> dIpiv(size_P, 1, stP, bc);
device_strided_batch_vector<int> dInfo(1, 1, 1, bc);
device_strided_batch_vector<T> dWork(bytes_W, 1, bytes_W, 1); // bytes_W accounts for bc
if(size_A)
CHECK_HIP_ERROR(dA.memcheck());
CHECK_HIP_ERROR(dInfo.memcheck());
if(size_P)
CHECK_HIP_ERROR(dIpiv.memcheck());
if(size_W)
CHECK_HIP_ERROR(dWork.memcheck());
// check computations
if(argus.unit_check || argus.norm_check)
sytrf_getError<API, T>(handle,
uplo,
n,
dA,
lda,
stA,
dIpiv,
stP,
dWork,
size_W,
dInfo,
bc,
hA,
hARes,
hIpiv,
hIpivRes,
hInfo,
hInfoRes,
&max_error);
// collect performance data
if(argus.timing)
sytrf_getPerfData<API, T>(handle,
uplo,
n,
dA,
lda,
stA,
dIpiv,
stP,
dWork,
size_W,
dInfo,
bc,
hA,
hIpiv,
hInfo,
&gpu_time_used,
&cpu_time_used,
hot_calls,
argus.perf);
}
// validate results for rocsolver-test
// using n * machine_precision as tolerance
if(argus.unit_check)
ROCSOLVER_TEST_CHECK(T, max_error, n);
// output results for rocsolver-bench
if(argus.timing)
{
if(!argus.perf)
{
std::cerr << "\n============================================\n";
std::cerr << "Arguments:\n";
std::cerr << "============================================\n";
if(BATCHED)
{
rocsolver_bench_output("uplo", "n", "lda", "strideP", "batch_c");
rocsolver_bench_output(uploC, n, lda, stP, bc);
}
else if(STRIDED)
{
rocsolver_bench_output("uplo", "n", "lda", "strideA", "strideP", "batch_c");
rocsolver_bench_output(uploC, n, lda, stA, stP, bc);
}
else
{
rocsolver_bench_output("uplo", "n", "lda");
rocsolver_bench_output(uploC, n, lda);
}
std::cerr << "\n============================================\n";
std::cerr << "Results:\n";
std::cerr << "============================================\n";
if(argus.norm_check)
{
rocsolver_bench_output("cpu_time", "gpu_time", "error");
rocsolver_bench_output(cpu_time_used, gpu_time_used, max_error);
}
else
{
rocsolver_bench_output("cpu_time", "gpu_time");
rocsolver_bench_output(cpu_time_used, gpu_time_used);
}
std::cerr << std::endl;
}
else
{
if(argus.norm_check)
rocsolver_bench_output(gpu_time_used, max_error);
else
rocsolver_bench_output(gpu_time_used);
}
}
// ensure all arguments were consumed
argus.validate_consumed();
}