derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
54 lines
2.2 KiB
C++
54 lines
2.2 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "DurationDivisionCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "clang/Lex/Lexer.h"
|
|
|
|
namespace clang::tidy::abseil {
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
void DurationDivisionCheck::registerMatchers(MatchFinder *Finder) {
|
|
const auto DurationExpr =
|
|
expr(hasType(cxxRecordDecl(hasName("::absl::Duration"))));
|
|
Finder->addMatcher(
|
|
traverse(TK_AsIs,
|
|
implicitCastExpr(
|
|
hasSourceExpression(ignoringParenCasts(
|
|
cxxOperatorCallExpr(hasOverloadedOperatorName("/"),
|
|
hasArgument(0, DurationExpr),
|
|
hasArgument(1, DurationExpr))
|
|
.bind("OpCall"))),
|
|
hasImplicitDestinationType(qualType(unless(isInteger()))),
|
|
unless(hasParent(cxxStaticCastExpr())),
|
|
unless(hasParent(cStyleCastExpr())),
|
|
unless(isInTemplateInstantiation()))),
|
|
this);
|
|
}
|
|
|
|
void DurationDivisionCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *OpCall = Result.Nodes.getNodeAs<CXXOperatorCallExpr>("OpCall");
|
|
diag(OpCall->getOperatorLoc(),
|
|
"operator/ on absl::Duration objects performs integer division; "
|
|
"did you mean to use FDivDuration()?")
|
|
<< FixItHint::CreateInsertion(OpCall->getBeginLoc(),
|
|
"absl::FDivDuration(")
|
|
<< FixItHint::CreateReplacement(
|
|
SourceRange(OpCall->getOperatorLoc(), OpCall->getOperatorLoc()),
|
|
", ")
|
|
<< FixItHint::CreateInsertion(
|
|
Lexer::getLocForEndOfToken(
|
|
Result.SourceManager->getSpellingLoc(OpCall->getEndLoc()), 0,
|
|
*Result.SourceManager, Result.Context->getLangOpts()),
|
|
")");
|
|
}
|
|
|
|
} // namespace clang::tidy::abseil
|