CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
111 lines
4.6 KiB
C++
111 lines
4.6 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "StringFindStrContainsCheck.h"
|
|
|
|
#include "../utils/OptionsUtils.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchers.h"
|
|
#include "clang/Tooling/Transformer/RewriteRule.h"
|
|
#include "clang/Tooling/Transformer/Stencil.h"
|
|
|
|
// FixItHint - Hint to check documentation script to mark this check as
|
|
// providing a FixIt.
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::abseil {
|
|
|
|
using ::clang::transformer::addInclude;
|
|
using ::clang::transformer::applyFirst;
|
|
using ::clang::transformer::cat;
|
|
using ::clang::transformer::changeTo;
|
|
using ::clang::transformer::makeRule;
|
|
using ::clang::transformer::node;
|
|
using ::clang::transformer::RewriteRuleWith;
|
|
|
|
namespace {
|
|
AST_MATCHER(Type, isCharType) { return Node.isCharType(); }
|
|
} // namespace
|
|
|
|
static constexpr char DefaultStringLikeClasses[] = "::std::basic_string;"
|
|
"::std::basic_string_view;"
|
|
"::absl::string_view";
|
|
static constexpr char DefaultAbseilStringsMatchHeader[] =
|
|
"absl/strings/match.h";
|
|
|
|
static transformer::RewriteRuleWith<std::string>
|
|
makeRewriteRule(ArrayRef<StringRef> StringLikeClassNames,
|
|
StringRef AbseilStringsMatchHeader) {
|
|
auto StringLikeClass = cxxRecordDecl(hasAnyName(StringLikeClassNames));
|
|
auto StringType =
|
|
hasUnqualifiedDesugaredType(recordType(hasDeclaration(StringLikeClass)));
|
|
auto CharStarType =
|
|
hasUnqualifiedDesugaredType(pointerType(pointee(isAnyCharacter())));
|
|
auto CharType = hasUnqualifiedDesugaredType(isCharType());
|
|
auto StringNpos = declRefExpr(
|
|
to(varDecl(hasName("npos"), hasDeclContext(StringLikeClass))));
|
|
auto StringFind = cxxMemberCallExpr(
|
|
callee(cxxMethodDecl(
|
|
hasName("find"), parameterCountIs(2),
|
|
hasParameter(
|
|
0, parmVarDecl(anyOf(hasType(StringType), hasType(CharStarType),
|
|
hasType(CharType)))))),
|
|
on(hasType(StringType)), hasArgument(0, expr().bind("parameter_to_find")),
|
|
anyOf(hasArgument(1, integerLiteral(equals(0))),
|
|
hasArgument(1, cxxDefaultArgExpr())),
|
|
onImplicitObjectArgument(expr().bind("string_being_searched")));
|
|
|
|
RewriteRuleWith<std::string> Rule = applyFirst(
|
|
{makeRule(
|
|
binaryOperator(hasOperatorName("=="),
|
|
hasOperands(ignoringParenImpCasts(StringNpos),
|
|
ignoringParenImpCasts(StringFind))),
|
|
{changeTo(cat("!absl::StrContains(", node("string_being_searched"),
|
|
", ", node("parameter_to_find"), ")")),
|
|
addInclude(AbseilStringsMatchHeader)},
|
|
cat("use !absl::StrContains instead of find() == npos")),
|
|
makeRule(
|
|
binaryOperator(hasOperatorName("!="),
|
|
hasOperands(ignoringParenImpCasts(StringNpos),
|
|
ignoringParenImpCasts(StringFind))),
|
|
{changeTo(cat("absl::StrContains(", node("string_being_searched"),
|
|
", ", node("parameter_to_find"), ")")),
|
|
addInclude(AbseilStringsMatchHeader)},
|
|
cat("use absl::StrContains instead "
|
|
"of find() != npos"))});
|
|
return Rule;
|
|
}
|
|
|
|
StringFindStrContainsCheck::StringFindStrContainsCheck(
|
|
StringRef Name, ClangTidyContext *Context)
|
|
: TransformerClangTidyCheck(Name, Context),
|
|
StringLikeClassesOption(utils::options::parseStringList(
|
|
Options.get("StringLikeClasses", DefaultStringLikeClasses))),
|
|
AbseilStringsMatchHeaderOption(Options.get(
|
|
"AbseilStringsMatchHeader", DefaultAbseilStringsMatchHeader)) {
|
|
setRule(
|
|
makeRewriteRule(StringLikeClassesOption, AbseilStringsMatchHeaderOption));
|
|
}
|
|
|
|
bool StringFindStrContainsCheck::isLanguageVersionSupported(
|
|
const LangOptions &LangOpts) const {
|
|
return LangOpts.CPlusPlus11;
|
|
}
|
|
|
|
void StringFindStrContainsCheck::storeOptions(
|
|
ClangTidyOptions::OptionMap &Opts) {
|
|
TransformerClangTidyCheck::storeOptions(Opts);
|
|
Options.store(Opts, "StringLikeClasses",
|
|
utils::options::serializeStringList(StringLikeClassesOption));
|
|
Options.store(Opts, "AbseilStringsMatchHeader",
|
|
AbseilStringsMatchHeaderOption);
|
|
}
|
|
|
|
} // namespace clang::tidy::abseil
|