CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
56 lines
2.1 KiB
C++
56 lines
2.1 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "TimeComparisonCheck.h"
|
|
#include "DurationRewriter.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include <optional>
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::abseil {
|
|
|
|
void TimeComparisonCheck::registerMatchers(MatchFinder *Finder) {
|
|
auto Matcher =
|
|
expr(comparisonOperatorWithCallee(functionDecl(
|
|
functionDecl(timeConversionFunction()).bind("function_decl"))))
|
|
.bind("binop");
|
|
|
|
Finder->addMatcher(Matcher, this);
|
|
}
|
|
|
|
void TimeComparisonCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *Binop = Result.Nodes.getNodeAs<BinaryOperator>("binop");
|
|
|
|
std::optional<DurationScale> Scale = getScaleForTimeInverse(
|
|
Result.Nodes.getNodeAs<FunctionDecl>("function_decl")->getName());
|
|
if (!Scale)
|
|
return;
|
|
|
|
if (isInMacro(Result, Binop->getLHS()) || isInMacro(Result, Binop->getRHS()))
|
|
return;
|
|
|
|
// In most cases, we'll only need to rewrite one of the sides, but we also
|
|
// want to handle the case of rewriting both sides. This is much simpler if
|
|
// we unconditionally try and rewrite both, and let the rewriter determine
|
|
// if nothing needs to be done.
|
|
const std::string LhsReplacement =
|
|
rewriteExprFromNumberToTime(Result, *Scale, Binop->getLHS());
|
|
const std::string RhsReplacement =
|
|
rewriteExprFromNumberToTime(Result, *Scale, Binop->getRHS());
|
|
|
|
diag(Binop->getBeginLoc(), "perform comparison in the time domain")
|
|
<< FixItHint::CreateReplacement(Binop->getSourceRange(),
|
|
(llvm::Twine(LhsReplacement) + " " +
|
|
Binop->getOpcodeStr() + " " +
|
|
RhsReplacement)
|
|
.str());
|
|
}
|
|
|
|
} // namespace clang::tidy::abseil
|