CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
72 lines
2.9 KiB
C++
72 lines
2.9 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "UndefinedMemoryManipulationCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::bugprone {
|
|
|
|
namespace {
|
|
AST_MATCHER(CXXRecordDecl, isNotTriviallyCopyable) {
|
|
// For incomplete types, assume they are TriviallyCopyable.
|
|
return Node.hasDefinition() ? !Node.isTriviallyCopyable() : false;
|
|
}
|
|
} // namespace
|
|
|
|
void UndefinedMemoryManipulationCheck::registerMatchers(MatchFinder *Finder) {
|
|
const auto HasNotTriviallyCopyableDecl =
|
|
hasDeclaration(cxxRecordDecl(isNotTriviallyCopyable()));
|
|
const auto ArrayOfNotTriviallyCopyable =
|
|
arrayType(hasElementType(HasNotTriviallyCopyableDecl));
|
|
const auto NotTriviallyCopyableObject = hasType(hasCanonicalType(
|
|
anyOf(pointsTo(qualType(anyOf(HasNotTriviallyCopyableDecl,
|
|
ArrayOfNotTriviallyCopyable))),
|
|
ArrayOfNotTriviallyCopyable)));
|
|
|
|
// Check whether destination object is not TriviallyCopyable.
|
|
// Applicable to all three memory manipulation functions.
|
|
Finder->addMatcher(callExpr(callee(functionDecl(hasAnyName(
|
|
"::memset", "::memcpy", "::memmove"))),
|
|
hasArgument(0, NotTriviallyCopyableObject))
|
|
.bind("dest"),
|
|
this);
|
|
|
|
// Check whether source object is not TriviallyCopyable.
|
|
// Only applicable to memcpy() and memmove().
|
|
Finder->addMatcher(
|
|
callExpr(callee(functionDecl(hasAnyName("::memcpy", "::memmove"))),
|
|
hasArgument(1, NotTriviallyCopyableObject))
|
|
.bind("src"),
|
|
this);
|
|
}
|
|
|
|
void UndefinedMemoryManipulationCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
if (const auto *Call = Result.Nodes.getNodeAs<CallExpr>("dest")) {
|
|
QualType DestType = Call->getArg(0)->IgnoreImplicit()->getType();
|
|
if (!DestType->getPointeeType().isNull())
|
|
DestType = DestType->getPointeeType();
|
|
diag(Call->getBeginLoc(), "undefined behavior, destination object type %0 "
|
|
"is not TriviallyCopyable")
|
|
<< DestType;
|
|
}
|
|
if (const auto *Call = Result.Nodes.getNodeAs<CallExpr>("src")) {
|
|
QualType SourceType = Call->getArg(1)->IgnoreImplicit()->getType();
|
|
if (!SourceType->getPointeeType().isNull())
|
|
SourceType = SourceType->getPointeeType();
|
|
diag(Call->getBeginLoc(),
|
|
"undefined behavior, source object type %0 is not TriviallyCopyable")
|
|
<< SourceType;
|
|
}
|
|
}
|
|
|
|
} // namespace clang::tidy::bugprone
|