CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
84 lines
3.3 KiB
C++
84 lines
3.3 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "NoAutomaticMoveCheck.h"
|
|
#include "../utils/Matchers.h"
|
|
#include "../utils/OptionsUtils.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::performance {
|
|
|
|
namespace {
|
|
|
|
AST_MATCHER(VarDecl, isNRVOVariable) { return Node.isNRVOVariable(); }
|
|
|
|
} // namespace
|
|
|
|
NoAutomaticMoveCheck::NoAutomaticMoveCheck(StringRef Name,
|
|
ClangTidyContext *Context)
|
|
: ClangTidyCheck(Name, Context),
|
|
AllowedTypes(
|
|
utils::options::parseStringList(Options.get("AllowedTypes", ""))) {}
|
|
|
|
void NoAutomaticMoveCheck::registerMatchers(MatchFinder *Finder) {
|
|
const auto NonNrvoConstLocalVariable =
|
|
varDecl(hasLocalStorage(), unless(hasType(lValueReferenceType())),
|
|
unless(isNRVOVariable()),
|
|
hasType(qualType(
|
|
isConstQualified(),
|
|
hasCanonicalType(matchers::isExpensiveToCopy()),
|
|
unless(hasDeclaration(namedDecl(
|
|
matchers::matchesAnyListedRegexName(AllowedTypes)))))))
|
|
.bind("vardecl");
|
|
|
|
// A matcher for a `DstT::DstT(const Src&)` where DstT also has a
|
|
// `DstT::DstT(Src&&)`.
|
|
const auto LValueRefCtor = cxxConstructorDecl(
|
|
hasParameter(0, hasType(hasCanonicalType(
|
|
lValueReferenceType(pointee(type().bind("SrcT")))))),
|
|
ofClass(cxxRecordDecl(hasMethod(cxxConstructorDecl(
|
|
hasParameter(0, hasType(hasCanonicalType(rValueReferenceType(
|
|
pointee(type(equalsBoundNode("SrcT"))))))))))));
|
|
|
|
// A matcher for `DstT::DstT(const Src&&)`, which typically comes from an
|
|
// instantiation of `template <typename U> DstT::DstT(U&&)`.
|
|
const auto ConstRefRefCtor = cxxConstructorDecl(
|
|
parameterCountIs(1),
|
|
hasParameter(0,
|
|
hasType(rValueReferenceType(pointee(isConstQualified())))));
|
|
|
|
Finder->addMatcher(
|
|
traverse(
|
|
TK_AsIs,
|
|
returnStmt(hasReturnValue(
|
|
ignoringElidableConstructorCall(ignoringParenImpCasts(
|
|
cxxConstructExpr(
|
|
hasDeclaration(anyOf(LValueRefCtor, ConstRefRefCtor)),
|
|
hasArgument(0, ignoringParenImpCasts(declRefExpr(
|
|
to(NonNrvoConstLocalVariable)))))
|
|
.bind("ctor_call")))))),
|
|
this);
|
|
}
|
|
|
|
void NoAutomaticMoveCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *Var = Result.Nodes.getNodeAs<VarDecl>("vardecl");
|
|
const auto *CtorCall = Result.Nodes.getNodeAs<Expr>("ctor_call");
|
|
diag(CtorCall->getExprLoc(), "constness of '%0' prevents automatic move")
|
|
<< Var->getName();
|
|
}
|
|
|
|
void NoAutomaticMoveCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
|
|
Options.store(Opts, "AllowedTypes",
|
|
utils::options::serializeStringList(AllowedTypes));
|
|
}
|
|
|
|
} // namespace clang::tidy::performance
|