CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
74 lines
2.7 KiB
C++
74 lines
2.7 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "RedundantParenthesesCheck.h"
|
|
#include "../utils/Matchers.h"
|
|
#include "../utils/OptionsUtils.h"
|
|
#include "clang/AST/Expr.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "clang/ASTMatchers/ASTMatchers.h"
|
|
#include "clang/ASTMatchers/ASTMatchersMacros.h"
|
|
#include <cassert>
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::readability {
|
|
|
|
namespace {
|
|
|
|
AST_MATCHER_P(ParenExpr, subExpr, ast_matchers::internal::Matcher<Expr>,
|
|
InnerMatcher) {
|
|
return InnerMatcher.matches(*Node.getSubExpr(), Finder, Builder);
|
|
}
|
|
|
|
AST_MATCHER(ParenExpr, isInMacro) {
|
|
const Expr *E = Node.getSubExpr();
|
|
return Node.getLParen().isMacroID() || Node.getRParen().isMacroID() ||
|
|
E->getBeginLoc().isMacroID() || E->getEndLoc().isMacroID();
|
|
}
|
|
|
|
} // namespace
|
|
|
|
RedundantParenthesesCheck::RedundantParenthesesCheck(StringRef Name,
|
|
ClangTidyContext *Context)
|
|
: ClangTidyCheck(Name, Context),
|
|
AllowedDecls(utils::options::parseStringList(
|
|
Options.get("AllowedDecls", "std::max;std::min"))) {}
|
|
|
|
void RedundantParenthesesCheck::storeOptions(
|
|
ClangTidyOptions::OptionMap &Opts) {
|
|
Options.store(Opts, "AllowedDecls",
|
|
utils::options::serializeStringList(AllowedDecls));
|
|
}
|
|
|
|
void RedundantParenthesesCheck::registerMatchers(MatchFinder *Finder) {
|
|
const auto ConstantExpr =
|
|
expr(anyOf(integerLiteral(), floatLiteral(), characterLiteral(),
|
|
cxxBoolLiteral(), stringLiteral(), cxxNullPtrLiteralExpr()));
|
|
Finder->addMatcher(
|
|
parenExpr(subExpr(anyOf(
|
|
parenExpr(), ConstantExpr,
|
|
declRefExpr(to(namedDecl(unless(
|
|
matchers::matchesAnyListedRegexName(AllowedDecls))))),
|
|
memberExpr(), callExpr(unless(cxxOperatorCallExpr())))),
|
|
unless(anyOf(isInMacro(),
|
|
// sizeof(...) is common used.
|
|
hasParent(unaryExprOrTypeTraitExpr()))))
|
|
.bind("dup"),
|
|
this);
|
|
}
|
|
|
|
void RedundantParenthesesCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *PE = Result.Nodes.getNodeAs<ParenExpr>("dup");
|
|
diag(PE->getBeginLoc(), "redundant parentheses around expression")
|
|
<< FixItHint::CreateRemoval(PE->getLParen())
|
|
<< FixItHint::CreateRemoval(PE->getRParen());
|
|
}
|
|
|
|
} // namespace clang::tidy::readability
|