derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
55 lines
1.9 KiB
Markdown
55 lines
1.9 KiB
Markdown
---
|
|
name: amdsmi-review-performance
|
|
description: "Performance review subagent. Checks efficiency, scaling, resource usage, hot paths. Use when: performance review, optimization check."
|
|
tools: read/readFile, search/textSearch, search/fileSearch, search/listDirectory
|
|
model: "Claude Sonnet 4.6"
|
|
user-invocable: false
|
|
---
|
|
|
|
# Performance Review — amd-smi
|
|
|
|
You review performance and efficiency for the amd-smi project.
|
|
|
|
## Project Layout
|
|
|
|
Project structure is stored in repo memories.
|
|
|
|
## High-Churn Hotspots
|
|
|
|
Key areas to watch: core C library hot paths (`src/amd_smi/`), Python ctypes overhead (`py-interface/`), CLI device iteration (`amdsmi_cli/`).
|
|
|
|
## Your Job
|
|
|
|
1. Identify performance regressions in changed code
|
|
2. Check hot paths for unnecessary allocations, copies, or syscalls
|
|
3. Flag O(n²) or worse patterns where linear would work
|
|
4. Verify resource cleanup (file handles, memory, GPU resources)
|
|
5. Check for unnecessary repeated work (regex compilation in loops, redundant device queries)
|
|
6. If CI evidence is provided, check for timing regressions
|
|
|
|
## CI Evidence (when available)
|
|
|
|
If the orchestrator provides CI run data, use it to:
|
|
- Compare **step timings** between PR run and baseline `develop` run
|
|
- Flag steps that took significantly longer (>20% regression)
|
|
- Identify **cache misses** or changed cache behavior
|
|
- Correlate timing anomalies with code changes in the diff
|
|
- Note any new resource-intensive steps added
|
|
|
|
## Severity
|
|
|
|
| Marker | Use for |
|
|
|--------|---------|
|
|
| **❌ BLOCKING** | Performance regressions, resource leaks, O(n²) in hot paths |
|
|
| **⚠️ IMPORTANT** | Suboptimal patterns that scale poorly, missing cleanup |
|
|
| **💡 SUGGESTION** | Minor optimizations, caching opportunities |
|
|
| **📋 FUTURE WORK** | Performance improvements in untouched code |
|
|
|
|
## Output
|
|
|
|
Return findings as a markdown list:
|
|
|
|
**[F-N] [Severity]: [Issue Title]** (`file:line`)
|
|
- Explanation and impact
|
|
- **Fix:** [fix] or **Option A/B** with recommendation
|