derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
71 lines
2.5 KiB
Markdown
71 lines
2.5 KiB
Markdown
---
|
|
description: "Review the current local branch using the AMD-SMI Review Agent"
|
|
agent: "AMD-SMI Review Agent"
|
|
argument-hint: "[review-type ...] — style, tests, docs, architecture, security, performance, build, skeptic (or blank for comprehensive). Add 'fast' to skip rebuttal. Add 'no-build' to skip build step. Add 'inherit' to use the orchestrator's model for subagents instead of the default (Sonnet 4.6)."
|
|
tools: [execute, read, edit, search, agent, todo]
|
|
---
|
|
|
|
Review the current local branch using the AMD-SMI Review Agent.
|
|
|
|
## Arguments
|
|
|
|
- `$ARGUMENTS` contains: `[review-type ...]`
|
|
- Valid types: `style`, `tests`, `docs`, `architecture`, `security`, `performance`, `build`, `skeptic`
|
|
- Special modifier: `fast` — skips the rebuttal round (comprehensive mode only)
|
|
- Special modifier: `no-build` — skips the build & install step
|
|
- Special modifier: `inherit` — makes all subagents inherit the orchestrator's model (the model you selected in the VS Code model picker) instead of their default (Sonnet 4.6)
|
|
- If no types specified, perform a **comprehensive** review (all subagents, with rebuttal)
|
|
|
|
## Process
|
|
|
|
### 1. Get Branch Information
|
|
|
|
```bash
|
|
git branch --show-current
|
|
git log --oneline develop..HEAD
|
|
git diff --stat develop..HEAD
|
|
```
|
|
|
|
Determine: branch name, base branch, commit count, files changed.
|
|
|
|
### 2. Get the Diff
|
|
|
|
```bash
|
|
git diff develop..HEAD
|
|
```
|
|
|
|
### 3. Gather CI Evidence (if available)
|
|
|
|
If a CI system is configured, attempt to fetch recent run data for this branch to pass to test and performance subagents.
|
|
|
|
### 4. Dispatch Review
|
|
|
|
Invoke the **AMD-SMI Review Agent** with:
|
|
- The diff
|
|
- The review type(s) from `$ARGUMENTS` (or "comprehensive" if none)
|
|
- Any CI evidence gathered
|
|
- If `inherit` was specified, tell the agent to have subagents inherit the orchestrator's model (ignore their frontmatter `model` field)
|
|
|
|
The agent will dispatch to the appropriate subagent(s) and produce a formatted review.
|
|
By default, comprehensive reviews include a rebuttal round (Round 2) with the skeptic subagent. If `fast` was specified, the rebuttal round is skipped.
|
|
|
|
### 5. Report Results
|
|
|
|
- Present the review inline
|
|
- Summarize the overall assessment
|
|
- List any blocking issues found
|
|
- If saving requested, use: `reviews/local_{COUNTER}_{branch-name}[_{TYPE}].md`
|
|
|
|
## Examples
|
|
|
|
```
|
|
/amdsmi-review-branch
|
|
/amdsmi-review-branch style
|
|
/amdsmi-review-branch tests security
|
|
/amdsmi-review-branch build
|
|
/amdsmi-review-branch fast
|
|
/amdsmi-review-branch skeptic
|
|
/amdsmi-review-branch inherit
|
|
/amdsmi-review-branch fast inherit
|
|
```
|