derek.holloway
7502bf64a4
CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
19 lines
1.3 KiB
Markdown
19 lines
1.3 KiB
Markdown
---
|
|
applyTo: "projects/hipblaslt/**"
|
|
---
|
|
|
|
# hipBLASLt PR review guidance (for Copilot code review)
|
|
|
|
These instructions apply when reviewing pull requests that touch `projects/hipblaslt/**` (the hipBLASLt component, including `tensilelite/`).
|
|
|
|
## Use the hipBLASLt PR-quality skill
|
|
|
|
hipBLASLt maintains an agent skill named `hipblaslt-pr-quality`. A skill is a self-contained set of review instructions plus a rubric that an AI reviewer follows to produce a consistent, substance-focused review; among other actions it defines how to **review** a pull request (change classification, the required-test bar, test-substance checks, device/arch coverage, coupling risks, and severity-ordered findings).
|
|
|
|
When reviewing a hipBLASLt PR, read and follow that skill as your review rubric:
|
|
|
|
- hipBLASLt overlay (start here): `projects/hipblaslt/skills/hipblaslt-pr-quality/SKILL.md`
|
|
- Base skill it extends (in `ROCm/TheRock`, not present in this repo): https://github.com/ROCm/TheRock/blob/develop/skills/rocm-pr-quality/SKILL.md and https://github.com/ROCm/TheRock/blob/develop/skills/rocm-pr-quality/reference.md
|
|
|
|
The overlay tightens the base skill for hipBLASLt and never relaxes a base rule; on any conflict, the skill files are the source of truth. This guidance is advisory: it points at the rubric and raises the review floor, but does not by itself approve or block a merge.
|