CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
67 lines
2.5 KiB
C++
67 lines
2.5 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "UncheckedStatusOrAccessCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "clang/ASTMatchers/ASTMatchers.h"
|
|
#include "clang/Analysis/FlowSensitive/DataflowAnalysis.h"
|
|
#include "clang/Analysis/FlowSensitive/Models/UncheckedStatusOrAccessModel.h"
|
|
#include "clang/Basic/SourceLocation.h"
|
|
#include "llvm/ADT/SmallVector.h"
|
|
#include "llvm/Support/Error.h"
|
|
|
|
namespace clang::tidy::abseil {
|
|
using ast_matchers::MatchFinder;
|
|
using dataflow::statusor_model::UncheckedStatusOrAccessDiagnoser;
|
|
using dataflow::statusor_model::UncheckedStatusOrAccessModel;
|
|
|
|
static constexpr StringRef FuncID = "fun";
|
|
|
|
void UncheckedStatusOrAccessCheck::registerMatchers(MatchFinder *Finder) {
|
|
using namespace ast_matchers;
|
|
|
|
auto HasStatusOrCallDescendant =
|
|
hasDescendant(callExpr(callee(cxxMethodDecl(ofClass(hasAnyName(
|
|
"absl::StatusOr", "absl::internal_statusor::OperatorBase"))))));
|
|
Finder->addMatcher(
|
|
functionDecl(hasBody(HasStatusOrCallDescendant)).bind(FuncID), this);
|
|
Finder->addMatcher(
|
|
cxxConstructorDecl(hasAnyConstructorInitializer(
|
|
withInitializer(HasStatusOrCallDescendant)))
|
|
.bind(FuncID),
|
|
this);
|
|
}
|
|
|
|
void UncheckedStatusOrAccessCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
if (Result.SourceManager->getDiagnostics().hasUncompilableErrorOccurred())
|
|
return;
|
|
|
|
const auto *FuncDecl = Result.Nodes.getNodeAs<FunctionDecl>(FuncID);
|
|
if (FuncDecl->isTemplated())
|
|
return;
|
|
|
|
UncheckedStatusOrAccessDiagnoser Diagnoser;
|
|
if (llvm::Expected<SmallVector<SourceLocation>> Locs =
|
|
dataflow::diagnoseFunction<UncheckedStatusOrAccessModel,
|
|
SourceLocation>(*FuncDecl, *Result.Context,
|
|
Diagnoser))
|
|
for (const SourceLocation &Loc : *Locs)
|
|
diag(Loc, "unchecked access to 'absl::StatusOr' value");
|
|
else
|
|
llvm::consumeError(Locs.takeError());
|
|
}
|
|
|
|
bool UncheckedStatusOrAccessCheck::isLanguageVersionSupported(
|
|
const LangOptions &LangOpts) const {
|
|
return LangOpts.CPlusPlus;
|
|
}
|
|
|
|
} // namespace clang::tidy::abseil
|