CodeQL / Analyze (actions) (push) Canceled after 0s
CodeQL / Analyze (python) (push) Canceled after 0s
pre-commit / pre-commit (push) Canceled after 0s
Multi-Arch CI / setup (push) Canceled after 0s
Publish build_manylinux_x86_64 images / publish_build_manylinux_x86_64 (push) Canceled after 0s
Setup (Multi-Arch) / setup (push) Canceled after 0s
Multi-Arch CI / Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubi10 image / publish_no_rocm_image_ubi10 (push) Canceled after 0s
Multi-Arch CI / Windows::${{ fromJSON(needs.setup.outputs.windows_build_config || '{}').build_variant_label || 'skip' }} (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Multi-Arch CI / Manifest Diff (push) Canceled after 0s
TheRock Manifest Diff Report / Generate Manifest Diff Report (push) Canceled after 0s
Multi-Arch CI / CI Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_ocl_rt images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04_rocgdb images / publish_no_rocm_image_ubuntu24_04_rocgdb (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_ocl_rt (push) Canceled after 0s
Publish TheRock Docker image / build-and-push-image (push) Canceled after 0s
Unit Tests / Unit Tests :: ubuntu-24.04 (push) Canceled after 0s
Unit Tests / Unit Tests :: windows-2022 (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_media (push) Canceled after 0s
Unit Tests / Unit Tests Summary (push) Canceled after 0s
Publish no_rocm_image_ubuntu24_04 images / publish_no_rocm_image_ubuntu24_04_openmpi (push) Canceled after 0s
56 lines
1.9 KiB
C++
56 lines
1.9 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "UsingNamespaceDirectiveCheck.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "clang/ASTMatchers/ASTMatchers.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::google::build {
|
|
|
|
void UsingNamespaceDirectiveCheck::registerMatchers(
|
|
ast_matchers::MatchFinder *Finder) {
|
|
Finder->addMatcher(usingDirectiveDecl().bind("usingNamespace"), this);
|
|
}
|
|
|
|
void UsingNamespaceDirectiveCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
const auto *U = Result.Nodes.getNodeAs<UsingDirectiveDecl>("usingNamespace");
|
|
const SourceLocation Loc = U->getBeginLoc();
|
|
if (U->isImplicit() || !Loc.isValid())
|
|
return;
|
|
|
|
// Do not warn if namespace is a std namespace with user-defined literals. The
|
|
// user-defined literals can only be used with a using directive.
|
|
if (isStdLiteralsNamespace(U->getNominatedNamespace()))
|
|
return;
|
|
|
|
diag(Loc, "do not use namespace using-directives; "
|
|
"use using-declarations instead");
|
|
// TODO: We could suggest a list of using directives replacing the using
|
|
// namespace directive.
|
|
}
|
|
|
|
bool UsingNamespaceDirectiveCheck::isStdLiteralsNamespace(
|
|
const NamespaceDecl *NS) {
|
|
if (!NS->getName().ends_with("literals"))
|
|
return false;
|
|
|
|
const auto *Parent = dyn_cast_or_null<NamespaceDecl>(NS->getParent());
|
|
if (!Parent)
|
|
return false;
|
|
|
|
if (Parent->isStdNamespace())
|
|
return true;
|
|
|
|
return Parent->getName() == "literals" && Parent->getParent() &&
|
|
Parent->getParent()->isStdNamespace();
|
|
}
|
|
} // namespace clang::tidy::google::build
|